Files
oldschoola a2854ba768 fix: migrate coding-agent tests from fs.rm to removeWithRetries
Migrate 203 test files (356 call sites) from fs.rm/fs.rmSync to
removeWithRetries/removeSyncWithRetries to reduce EBUSY test failures
on Windows. removeWithRetries is now exported from @oh-my-pi/pi-utils.

The migration uses a regex-based approach that:
- Replaces fs.rm(path, { recursive, force }) → removeWithRetries(path)
- Replaces fs.rmSync(path, { recursive, force }) → removeSyncWithRetries(path)
- Replaces fs.rm(path) → removeWithRetries(path) (no options)
- Skips fs.rm/fs.rmSync inside template literals (bun --eval scripts)
- Adds imports to existing @oh-my-pi/pi-utils import or creates new one
- Removes unused fs imports where fs.rm was the only fs usage (4 files)
2026-06-23 15:28:05 -07:00

59 lines
2.1 KiB
TypeScript

import { afterEach, beforeEach, describe, expect, mock, spyOn, test } from "bun:test";
import * as fs from "node:fs/promises";
import * as os from "node:os";
import * as path from "node:path";
import { PluginManager } from "@oh-my-pi/pi-coding-agent/extensibility/plugins/manager";
import * as piUtils from "@oh-my-pi/pi-utils";
import { removeWithRetries } from "@oh-my-pi/pi-utils";
describe("plugin config", () => {
let tmpRoot: string;
let pluginsDir: string;
let lockfile: string;
beforeEach(async () => {
tmpRoot = await fs.mkdtemp(path.join(os.tmpdir(), "omp-plugin-config-"));
pluginsDir = path.join(tmpRoot, "plugins");
lockfile = path.join(pluginsDir, "omp-plugins.lock.json");
spyOn(piUtils, "getPluginsDir").mockReturnValue(pluginsDir);
spyOn(piUtils, "getPluginsLockfile").mockReturnValue(lockfile);
spyOn(piUtils, "getProjectDir").mockReturnValue(tmpRoot);
spyOn(piUtils, "getProjectPluginOverridesPath").mockReturnValue(path.join(tmpRoot, "plugin-overrides.json"));
});
afterEach(async () => {
mock.restore();
await removeWithRetries(tmpRoot);
});
async function writeLegacyLockfile(pluginName: string): Promise<void> {
await Bun.write(
lockfile,
JSON.stringify({
plugins: {
[pluginName]: { version: "0.2.2", enabledFeatures: null, enabled: true },
},
}),
);
}
test("set initializes missing settings in legacy runtime config", async () => {
const pluginName = "@gaodes/pi-graphify";
await writeLegacyLockfile(pluginName);
await new PluginManager(tmpRoot).setPluginSetting(pluginName, "autoContext.enabled", true);
const lock = await Bun.file(lockfile).json();
expect(lock.settings[pluginName]).toEqual({ "autoContext.enabled": true });
expect(lock.plugins[pluginName]).toEqual({ version: "0.2.2", enabledFeatures: null, enabled: true });
});
test("list treats missing settings in legacy runtime config as empty", async () => {
const pluginName = "@gaodes/pi-graphify";
await writeLegacyLockfile(pluginName);
await expect(new PluginManager(tmpRoot).getPluginSettings(pluginName)).resolves.toEqual({});
});
});