roboomp
fe4e553be3
waitForManagedBashJob raced job completion against a bare Bun.sleep(thresholdMs), which cannot be cancelled. When completion, abort, or steering won the race, the losing Bun.sleep timer stayed scheduled and ref'd, keeping Bun's event loop alive until the threshold expired — delaying SDK/headless shutdown and accumulating timers under fast command rates. Replace the Bun.sleep with a Promise.withResolvers settled by a cancellable setTimeout, and route every outcome (including the former no-signal early return) through one try/finally that clears the timer and removes the abort/steer listeners. Add a child-process regression test that runs the real auto-background path for a fast command against a 30s threshold and asserts the process exits promptly instead of being held for the full threshold. Fixes #7235
53 lines
2.0 KiB
TypeScript
53 lines
2.0 KiB
TypeScript
/**
|
|
* Regression test for #7235: Bash auto-background must release the threshold
|
|
* timer once the command finishes first, instead of leaving a live `Bun.sleep`
|
|
* timer that keeps the event loop alive until the threshold expires (delaying
|
|
* SDK/headless shutdown). Timer keep-alive is only observable in a child
|
|
* process, so this spawns the real BashTool auto-background path against a 30s
|
|
* threshold and asserts the process exits promptly rather than after 30s.
|
|
*/
|
|
import { describe, expect, it } from "bun:test";
|
|
import * as path from "node:path";
|
|
|
|
const PROBE_PATH = path.join(import.meta.dir, "fixtures", "bash-autobg-exit-probe.ts");
|
|
const REPO_ROOT = path.resolve(import.meta.dir, "../../..");
|
|
// Fixed: probe exits ~0.5s. Buggy: held ~30s by the retained threshold timer.
|
|
const PROMPT_EXIT_MS = 15_000;
|
|
|
|
describe("bash auto-background threshold timer (#7235)", () => {
|
|
it("does not keep the event loop alive after a fast command completes", async () => {
|
|
const start = performance.now();
|
|
const proc = Bun.spawn([process.execPath, PROBE_PATH], {
|
|
cwd: REPO_ROOT,
|
|
stdin: "ignore",
|
|
stdout: "pipe",
|
|
stderr: "pipe",
|
|
});
|
|
// Integration test of real event-loop keep-alive across a process boundary:
|
|
// the child's wall-clock exit time IS the contract, so fake timers cannot
|
|
// apply (they cannot control another process's clock). This real-timer
|
|
// watchdog only bounds a wedged child — a retained threshold timer would
|
|
// otherwise hold it for the full 30s.
|
|
const watchdog = setTimeout(() => {
|
|
try {
|
|
proc.kill("SIGKILL");
|
|
} catch {}
|
|
}, 28_000);
|
|
try {
|
|
const [exitCode, stdout, stderr] = await Promise.all([
|
|
proc.exited,
|
|
new Response(proc.stdout).text(),
|
|
new Response(proc.stderr).text(),
|
|
]);
|
|
const elapsedMs = performance.now() - start;
|
|
|
|
expect(stderr).toBe("");
|
|
expect(exitCode).toBe(0);
|
|
expect(JSON.parse(stdout.trim())).toEqual({ done: true, output: "hi" });
|
|
expect(elapsedMs).toBeLessThan(PROMPT_EXIT_MS);
|
|
} finally {
|
|
clearTimeout(watchdog);
|
|
}
|
|
}, 30_000);
|
|
});
|