Commit Graph

6808 Commits

Author SHA1 Message Date
roboomp dbdc77697c fix(coding-agent): retried session resume even when initial restore failed
Post-extension session-model retry now covers the case where the initial restore failed entirely (e.g. saved default unavailable, last active role supplied by an extension) and the settings default filled in the active model. Also recomputes thinking-level from full precedence against the reclaimed model so a fallback model's defaultLevel does not become sticky.\n\nFixes #1649
2026-06-02 09:15:45 +02:00
roboomp 0494454528 fix(coding-agent): retried role restore after extension providers
Initial startup resume runs before extension providers register, so a role model supplied by an extension fell back to the saved default. Retry the preferred session-model candidates once provider registrations are processed and re-resolve thinking level for the new model.\n\nFixes #1649
2026-06-02 09:15:45 +02:00
roboomp cf9eb5b0f9 fix(coding-agent): skipped temporary resume models
Treat temporary model_change roles as non-restorable when resuming sessions so context-promotion and retry-fallback models do not override the saved default.\n\nFixes #1649
2026-06-02 09:15:45 +02:00
roboomp 43405962b7 style: bun run fix 2026-06-02 09:15:45 +02:00
roboomp 00adc9c5d6 fix(coding-agent): fell back to saved default on resume
Try the last active role model first, then the saved default model when the role model cannot be restored during session switching or startup resume.\n\nFixes #1649
2026-06-02 09:15:45 +02:00
roboomp 8e1f53fee6 style: bun run fix 2026-06-02 09:15:44 +02:00
roboomp bb0991e6f3 fix(coding-agent): restored last active role model
Use the last model_change role when resuming an existing session instead of always restoring models.default. Covered both /resume switchSession and startup continue paths.\n\nFixes #1649
2026-06-02 09:15:44 +02:00
can1357 ab935e992c fix(legacy-pi-compat): scope rewrite hook to the import graph, not a dir
Address review of the in-place loader: the directory-subtree filter had two
regressions vs the old mirror.

- It only rewrote files under the entry's package root, so a `dist/`
  entry importing `../../shared/helper.ts` (or a symlink-escaping sibling)
  left that module's legacy `@(scope)/pi-*` / `@sinclair/typebox` imports
  un-rewritten.
- `findExtensionRoot` walked up to the nearest package.json, which for an
  ad-hoc extension under a project (e.g. `/repo/.omp/extensions/foo.ts`)
  resolved to the project root — so the permanent onLoad hook would then
  rewrite unrelated project/host source imported later.

Replace the directory filter with a precise scope: pre-walk the entry's
relative-import graph (static + dynamic `./`/`../` specifiers), collect each
module's realpath, and build the onLoad filter as an exact-path alternation
of just those modules. This matches exactly the set the old mirror tracked
(minus the copy): it covers `../src`/symlinked siblings and never touches
the host, other extensions, node_modules deps, or unrelated project files.

Adds a regression test that a non-imported sibling stays outside the rewrite
scope, and renames the ../src test to reflect graph-following.
2026-06-02 09:15:44 +02:00
can1357 c5e3698f45 fix(legacy-pi-compat): load extensions in place instead of mirroring
Legacy Pi extensions were mirrored module-by-module into a flat temp dir
(`omp-legacy-pi-file/entry-<hash>/`) with imports rewritten to absolute
URLs. Running from that temp root made `import.meta.url`/`__dirname`
resolve to the mirror, so `readFileSync(join(__dirname, "ui.html"))`-style
asset loads ENOENT'd — e.g. @plannotator/pi-extension's HTML never loaded
and it auto-approved plans (#1674). The standing remedy (#1675) copied
~30MB of .html/.css per startup with a fragile extension whitelist.

Bun's runtime plugins don't fire onResolve for transitive imports, which
is why the mirror pre-resolved everything. But onLoad does fire
transitively for file-namespace modules matching its filter, and a real
file import keeps import.meta.url pointing at the source. So:

- Load the extension entry in place via `import(pathToFileURL(real))`;
  realpath first so the path matches what Bun hands onLoad (macOS
  /var->/private/var, bun link/pnpm symlinks).
- Register one Bun.plugin() onLoad per extension *package root* (nearest
  package.json), filtered to that root's .js/.ts but excluding any
  node_modules segment, that rewrites only `@(scope)/pi-*` and the bare
  `@sinclair/typebox` specifier to absolute bundled/shim URLs.
- Everything else — relative siblings (incl. ../src), the extension's own
  node_modules deps (CJS/ESM), and bundled assets — resolves natively.

Removes the flat mirror, the temp-dir writes, the asset-copy problem, and
the now-dead `omp-legacy-pi-file:` namespace machinery. import.meta.url is
the real source file, so assets resolve exactly as under the original Pi
runtime. Adds an in-place load regression test covering asset reads,
submodule .css siblings, node_modules-excluded native deps, and
package-root-scoped ../src rewrites.

Fixes #1674.
2026-06-02 09:15:44 +02:00
can1357 f30648b725 chore: fixup changelog 2026-06-02 09:15:44 +02:00
Can Bölük 8baf2c8940 Merge pull request #1546 from superhedge22/fix/plan-approval-context-usage
fix(coding-agent): show execution context in plan approval
2026-06-02 09:59:27 +03:00
can1357 38977b8450 test: replaced exact sleep assertions with tolerance-aware helper
- Added `expectSleepNear` to allow ±100ms variance on sleep duration checks.
- Updated `--thinking` test value from `"extended"` to `Effort.XHigh` enum constant.
2026-06-02 08:57:29 +02:00
SuperHedge 811c9e65d0 fix(coding-agent): show execution context in plan approval 2026-06-02 08:57:11 +02:00
can1357 f18eb90324 feat(agent): added implementation authorization gate for branch/PR tools
- Added `is_implementation_authorizer` check requiring OWNER or allowlisted maintainer to authorize implementation work.
- Blocked `gh_push_branch` and `gh_open_pr` for unclassified/enhancement/proposal issues without explicit directive authorization.
- Auto-allowed bug and documentation issues without requiring a directive.
- Propagated `authorizes_impl` flag through events, server, tasks, and worker bindings.
2026-06-02 08:44:59 +02:00
can1357 2ecb5fd9fa chore: reformat 2026-06-02 08:43:23 +02:00
can1357 0bc9bc25b4 fix(agent): gated tool_arg harmony detection on trailing-garbage T co-signal
- Added T co-signal requirement for tool_arg surface so legitimate edits carrying the marker are never hard-aborted.
- Extended detectHarmonyLeakInAssistantMessage with optional toolArgParseEnd resolver; agent loop omits it, keeping tool_arg inert.
- Updated tests to inject a boundary-at-0 helper for corpus cases and added T-gate unit tests.
2026-06-02 08:42:52 +02:00
can1357 7b5517b255 fix(open): fixed WSL local file opening via wslpath and wslview
- Converted existing local paths to Windows paths via `wslpath -w` before opening.
- Used `wslview` directly in WSL environments, bypassing `xdg-open`'s broken file-handler translation.
- Fell back to `xdg-open` for URLs or when `wslview` is unavailable.
- Added unit tests covering WSL file, URL, and fallback scenarios.
2026-06-02 08:42:44 +02:00
can1357 05d44836dd chore: typo 2026-06-02 08:42:43 +02:00
Can Bölük 30ab3b9db9 Merge pull request #1660 from DarkPhilosophy/fix/harmony-final-response-retry
Engage harmony leak detection on the committed assistant message
2026-06-02 09:42:37 +03:00
Can Bölük e5109e6c92 Merge pull request #1318 from ogormans-deptstack/feat/1313-hide-thinking-flag
feat: add --hide-thinking CLI flag to suppress thinking blocks in TUI
2026-06-02 09:31:49 +03:00
Can Bölük be2719f03d Merge pull request #1371 from can1357/farm/b73cb08b/acp-background-opt-in
fix(acp): preserve background job opt-ins
2026-06-02 09:31:06 +03:00
Can Bölük 20bcea6830 Merge branch 'main' into farm/b73cb08b/acp-background-opt-in 2026-06-02 09:30:07 +03:00
Can Bölük ad8017cb5a Merge pull request #1673 from can1357/farm/6d6ea973/document-system-md-templating-contract
docs: documented SYSTEM.md / APPEND_SYSTEM.md customization contract
2026-06-02 09:28:34 +03:00
Can Bölük 4a21d39e61 Merge pull request #1272 from thismat/main
feat(web-search): Added Kagi V1 API Provider
2026-06-02 09:28:17 +03:00
Can Bölük 9488cb52fe Merge branch 'main' into main 2026-06-02 09:28:09 +03:00
can1357 77c2b0bd8f chore: minor fixes 2026-06-02 08:27:04 +02:00
can1357 1a1c473e7f refactor(web-search): fold Kagi V1 into the kagi provider
Replace the sunset V0 Search API with V1 (POST /api/v1/search) under the
existing `kagi` provider id instead of shipping a parallel `kagi-v1`
provider. Credentials still resolve through the shared AuthStorage broker
(Bearer token, KAGI_API_KEY, /login kagi), and recency now maps to a
UTC-deterministic filters.after date.

- Merge V1 client into src/web/kagi.ts (categorized result buckets, direct
  answer, related/adjacent questions)
- Keep classifyProviderHttpError mapping for auth/quota signals
- Drop the kagi-v1 entries from the provider registry, order, type union,
  and settings schema
- Consolidate tests into web-search-kagi.test.ts
2026-06-02 08:26:55 +02:00
can1357 b503f7d86b feat(robomp): added incoming PR review feature with classify and submit
- Added `review_pr` task that checks out PR head in a detached worktree, classifies rank/type/area, and posts a batched GitHub review as `event=COMMENT`.
- Added four new host tools: `fetch_pr`, `classify_pr`, `pr_review_comment`, and `submit_pr_review`; review tools self-gate on `review_mode`, push/open-PR tools refuse when `review_mode` is set.
- Added sqlite staging table `pr_review_comments` with `stage_review_comment`, `list_staged_review_comments`, and `clear_staged_review_comments` DAOs.
- Routed `pull_request.opened/reopened/ready_for_review` to `review_pr` and extended `pull_request.closed` cleanup to any tracked PR regardless of author.
2026-06-02 08:23:09 +02:00
can1357 04cc014c16 fix(tui): deferred eager scrollback rebuild on ED3-risk POSIX terminals
- Added `terminalHasEagerEraseScrollbackRisk` to detect WezTerm, kitty, ghostty, and alacritty on POSIX, where xterm ED3 (`CSI 3 J`) can snap scrolled-up readers back to the tail during streaming.
- Kept direct user-input and checkpoint rebuilds unaffected by the deferral.
- Added regression tests covering the deferred and non-deferred paths (issue #1682).
2026-06-02 08:23:09 +02:00
Can Bölük 3c024aa5ce Merge pull request #1687 from can1357/farm/802d1a6a/update-bypass-bun-manifest-cache
fix(update): bypass bun manifest cache so omp update sees fresh releases
2026-06-02 09:22:33 +03:00
roboomp a3fbeb4a0a style: bun run fix 2026-06-02 06:19:00 +00:00
roboomp 9abce6e974 fix(update): pinned npm registry and bypassed bun cache for omp update
omp resolves the update target by querying https://registry.npmjs.org/ directly, but `bun install -g pkg@<version>` would then consult bun's on-disk manifest snapshot AND honour the user's npm-mirror configuration (corporate proxy, Taobao, …). Either source can lag the upstream registry by minutes-to-hours, in which case bun rejects the version with `No version matching "X" found for specifier "@oh-my-pi/pi-coding-agent" (but package exists)` even though the registry omp just queried is serving it.

The bun install step now runs with both `--no-cache` (skip the manifest snapshot) and `--registry=https://registry.npmjs.org/` (pin the official catalog regardless of bunfig/.npmrc) so the install observes the same registry state the version check used. The registry URL is centralised in an `NPM_REGISTRY` constant shared by `getLatestRelease` and `buildBunInstallArgs`.

Fixes #1686
2026-06-02 06:18:54 +00:00
Can Bölük 7b20de4ef1 Merge pull request #1587 from devxplay-forks/feat/raw-paste
feat(clipboard): add raw text paste functionality with keyboard shortcut
2026-06-02 09:18:16 +03:00
Can Bölük 38360c0c3c Merge pull request #1311 from jiwangyihao/acp-terminal-release-content
fix(acp): show live execute tool details
2026-06-02 09:17:58 +03:00
Can Bölük f7d1ed868b Merge pull request #1679 from JacobZyy/fix/xiaomi-tp-cn-validation
fix(ai): add CN token-plan host to Xiaomi MiMo login validation
2026-06-02 09:14:26 +03:00
Can Bölük c394822423 Merge pull request #1667 from can1357/farm/032afa26/fix-edit-collision-duplicates
fix(hashline): repair duplicated edit boundary echoes
2026-06-02 09:12:42 +03:00
Can Bölük 12970e2412 Merge pull request #1646 from can1357/farm/2a94e89d/honor-todo-clear-delay
fix(tui): honor todo auto-clear delay
2026-06-02 09:11:07 +03:00
Can Bölük 2935627d7e Merge pull request #1662 from can1357/farm/b88f2093/fix-opencode-qwen37
fix(ai): use bearer auth for OpenCode Anthropic models
2026-06-02 09:00:19 +03:00
Can Bölük c9e2e89f7c Merge pull request #1312 from basedcorp99/fix/cursor-last-user-message
Fix Cursor request user message selection
2026-06-02 08:55:35 +03:00
Can Bölük ea05ed8345 Merge pull request #1621 from can1357/farm/3a53b91e/fix-exit-cursor-position
Fix shell prompt placement after quitting TUI
2026-06-02 08:55:10 +03:00
Can Bölük 94177c2ab0 Merge branch 'main' into farm/3a53b91e/fix-exit-cursor-position 2026-06-02 08:55:01 +03:00
Can Bölük d9960f1142 Merge pull request #1659 from can1357/farm/d05e786c/cannot-log-out-opencode
fix(auth): limit logout to stored credentials
2026-06-02 08:53:17 +03:00
Can Bölük 2909b068d1 Merge branch 'main' into farm/d05e786c/cannot-log-out-opencode 2026-06-02 08:52:53 +03:00
Can Bölük 858b758ee3 Merge pull request #1669 from can1357/farm/cc346f1b/fix-resume-decline-fork-exit
fix(coding-agent): exited cleanly when declining cross-project resume fork
2026-06-02 08:52:05 +03:00
Can Bölük 1f0e0a490b Merge branch 'main' into farm/cc346f1b/fix-resume-decline-fork-exit 2026-06-02 08:49:46 +03:00
can1357 384a206737 refactor(task): replaced numeric-prefix ids with name-first agent output ids
- Changed `AgentOutputManager` to use requested names verbatim, adding `-2`/`-3` suffixes only on repeats (e.g. `Anna`, `Anna-2`).
- Renamed main agent id from `0-Main` to `Main`; nested ids now use dot notation without numeric prefix (e.g. `Parent.Child`).
- Updated task widget to render dotted hierarchy as `Parent>Child` breadcrumb without leading index.
- Resume scan now tracks seen names instead of a counter to avoid clobbering prior outputs.
2026-06-02 06:50:03 +02:00
can1357 c4e157590e feat(eval): replaced fixed concurrency cap with task.maxConcurrency bridge
- Removed the `concurrency` argument from `parallel()` and `pipeline()` in both JS and Python runtimes.
- Added `__concurrency__` bridge to resolve the pool ceiling live from `task.maxConcurrency` (default 32; 0 = unbounded).
- Eval fan-outs now run as wide as a `task` tool batch instead of being capped at 16.
2026-06-02 06:49:15 +02:00
can1357 a25b4dc2cc docs(coding-agent/prompts): added shared executor reuse guidance to eval tool
- Encouraged staging helpers, datasets, and clients once, then fanning out subagents that call them directly.
- Clarified that re-importing, re-fetching, or serializing across the task boundary is unnecessary.
2026-06-02 06:43:58 +02:00
can1357 a4dc8b597d docs(coding-agent/prompts): reworked orchestrator prompt for trivial inline edits and batching
- Updated the role contract to allow direct trivial edits while reserving substantial work for subagents.
- Reinforced that parallel work must be fanned out broadly and that one-off task dispatches are disallowed.
- Clarified that subagents make edits only, while the orchestrator runs verification for changed files.
2026-06-02 06:33:30 +02:00
can1357 1fcb49601a fix(coding-agent): synchronized preview diff updates to settle before rendering
- Tracked the latest in-flight preview diff recompute in ToolExecutionComponent and exposed it through a new whenPreviewSettled method.
- Updated component paths that trigger preview recomputation to retain the returned promise instead of fire-and-forget calls.
- Updated the streaming preview height test to await settled diff recomputation before assertions, eliminating requestRender race-based flakes.
2026-06-02 06:27:09 +02:00