smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(tui): support ctrl+j as an additional newline key (#2473)

Browse Source
This commit is contained in:
metaphorics
2026-06-14 05:52:46 +09:00
parent eac1d21f93
commit ef366cc871
3 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/tui/CHANGELOG.md
+4
View File
@@ -2,6 +2,10 @@
## [Unreleased]
### Added
- Added `ctrl+j` as a second default binding for the `tui.input.newLine` action alongside `shift+enter`, so terminals that cannot emit `shift+enter` still have a newline key. On terminals with Kitty-protocol / `modifyOtherKeys` disambiguation `ctrl+j` inserts a newline while `Enter` still submits; on legacy terminals where `ctrl+j` and `Enter` are both byte-identical `LF` it submits (documented limitation). User keybinding overrides still take precedence ([#2473](https://github.com/can1357/oh-my-pi/issues/2473))
## [15.12.5] - 2026-06-13
### Added
packages/tui/src/keybindings.ts
+1 -1
View File
@@ -118,7 +118,7 @@ export const TUI_KEYBINDINGS = {
"tui.editor.yank": { defaultKeys: "ctrl+y", description: "Yank" },
"tui.editor.yankPop": { defaultKeys: "alt+y", description: "Yank pop" },
"tui.editor.undo": { defaultKeys: ["ctrl+-", "ctrl+_"], description: "Undo" },
"tui.input.newLine": { defaultKeys: "shift+enter", description: "Insert newline" },
"tui.input.newLine": { defaultKeys: ["shift+enter", "ctrl+j"], description: "Insert newline" },
"tui.input.submit": { defaultKeys: "enter", description: "Submit input" },
"tui.input.tab": { defaultKeys: "tab", description: "Tab / autocomplete" },
"tui.input.copy": { defaultKeys: "ctrl+c", description: "Copy selection" },
packages/tui/test/keybindings.test.ts
+8
View File
@@ -44,6 +44,14 @@ describe("KeybindingsManager", () => {
expect(keybindings.getKeys("tui.editor.cursorLeft")).toEqual(["left", "ctrl+b"]);
});
it("ships ctrl+j alongside shift+enter as default newline keys", () => {
const keybindings = new KeybindingsManager(TUI_KEYBINDINGS);
const newLineKeys = keybindings.getKeys("tui.input.newLine");
expect(newLineKeys).toContain("ctrl+j");
expect(newLineKeys).toContain("shift+enter");
});
it("exports the canonical alias helpers used by matching", () => {
const aliases = new Set<string>();
for (const key of ["esc", "return", "?", "shift+a"] as const) {