smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(tui): prune settled-component cache to rendered messages on rebuild

Browse Source 
Session entries keep AgentMessage objects strongly reachable for the whole
session, so WeakMap entries for compacted-away history pinned their
components' rendered layout caches forever. Rebuild now retains only
components for messages the new transcript context actually renders.
This commit is contained in:
can1357
2026-07-22 20:51:04 +02:00
parent e1173b8aeb
commit e7f3fde12b
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/coding-agent/src/modes/interactive-mode.ts
+11
View File
@@ -1691,6 +1691,17 @@ export class InteractiveMode implements InteractiveModeContext {
const context = this.viewSession.buildTranscriptSessionContext({
collapseCompactedHistory: settings.get("display.collapseCompacted"),
});
// Prune the settled-component cache to the messages this rebuild will
// actually render. Message objects stay strongly reachable through
// session entries for the whole session, so entries for compacted-away
// history would otherwise pin their components' rendered layout caches
// forever — exactly the memory a collapsed compaction used to release.
const retained = new WeakMap<AgentMessage, Component>();
for (const message of context.messages) {
const component = this.transcriptMessageComponents.get(message);
if (component) retained.set(message, component);
}
this.transcriptMessageComponents = retained;
this.renderSessionContext(context, { reuseSettledComponents: options.reuseSettledComponents });
for (const child of liveComponents) {
this.chatContainer.addChild(child);