smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(coding-agent): drop api filter from getOpenAICompat fixture helper

Browse Source 
The helper guarded `model.api === "openai-completions"` and returned undefined
for openai-responses models. The discoverable-custom-compat test sets
`api: "openai-responses"` on a custom model with `compat.extraBody`, so the
post-refresh assertion saw `undefined` instead of the configured proxy hint.

The OpenAICompatSchema gates user-facing custom-model compat regardless of the
underlying api wire format, so reading the field as OpenAICompat for any api
matches what the registry actually stores.
This commit is contained in:
can1357
2026-04-30 05:35:00 +02:00
parent fed95ce524
commit bf1faf8842
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/coding-agent/test/model-registry.test.ts
+4 -1
View File
@@ -94,7 +94,10 @@ describe("ModelRegistry", () => {
}
function getOpenAICompat(model: Model | undefined): OpenAICompat | undefined {
return model?.api === "openai-completions" ? (model.compat as OpenAICompat | undefined) : undefined;
// All custom-model compat overrides flow through OpenAICompatSchema regardless of
// the underlying api ("openai-completions" vs "openai-responses"), so we can read
// the field for any model in this fixture.
return model?.compat as OpenAICompat | undefined;
}
/** Create a baseUrl-only override (no custom models) */