smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(stats): bind port-conflict test listeners to the wildcard address

Browse Source 
On macOS SO_REUSEADDR lets startServer's wildcard bind coexist with a
127.0.0.1-only listener, so the EADDRINUSE path was never exercised and
three of the four conflict tests failed. Wildcard-bind the holders and
the reused dashboard so the conflict is real on every platform.
This commit is contained in:
can1357
2026-07-18 19:34:02 +02:00
parent 5d5fcd27e3
commit b7c8fce83c
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/stats/test/server-port-conflict.test.ts
+4 -3
View File
@@ -6,15 +6,17 @@ import { startServer } from "../src/server";
const holderProcesses: Array<Subprocess<"ignore", "pipe", "pipe">> = [];
async function startBunHolder(responseExpr: string, options?: { statsOwned?: boolean }) {
// Bind the wildcard address: `startServer` binds the wildcard too, and on
// macOS SO_REUSEADDR lets a wildcard bind coexist with a 127.0.0.1-only
// listener, which would bypass the EADDRINUSE path this suite exercises.
const reservation = Bun.serve({
hostname: "127.0.0.1",
port: 0,
fetch: () => new Response("reserved"),
});
const port = reservation.port;
reservation.stop(true);
const source = `Bun.serve({ hostname: "127.0.0.1", port: ${port}, fetch: () => ${responseExpr} }); process.stdout.write("ready"); await Promise.withResolvers().promise;`;
const source = `Bun.serve({ port: ${port}, fetch: () => ${responseExpr} }); process.stdout.write("ready"); await Promise.withResolvers().promise;`;
const args = [process.execPath, "-e", source];
if (options?.statsOwned) args.push("omp-stats");
const child = Bun.spawn(args, {
@@ -47,7 +49,6 @@ afterEach(async () => {
describe("startServer port conflicts", () => {
it("reuses a live stats dashboard identified by its header", async () => {
const existing = Bun.serve({
hostname: "127.0.0.1",
port: 0,
fetch: request =>
new URL(request.url).pathname === "/api/stats/models"