smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(ai): renamed thinkingLevel to reasoning in OpenAI

Browse Source 
- Renamed thinkingLevel to reasoning in OpenAI completions API calls for consistency.
- Introduced reasoningEffort variable to normalize 'off' value to undefined across Anthropic and OpenAI providers.
- Updated all test cases to use reasoning parameter instead of thinkingLevel.
This commit is contained in:
can1357
2026-03-05 00:35:43 +01:00
parent 5b60309ebc
commit a7c02e4ddf
5 changed files with 46 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/ai/src/providers/gitlab-duo.ts
+11 -6
View File
@@ -267,6 +267,11 @@ export function streamGitLabDuo(
...options.headers,
};
const reasoningEffort =
options.reasoning === "off"
? undefined
: (options.reasoning as "minimal" | "low" | "medium" | "high" | "xhigh" | undefined);
const inner =
mapping.provider === "anthropic"
? streamAnthropic(
@@ -295,11 +300,11 @@ export function streamGitLabDuo(
sessionId: options.sessionId,
providerSessionState: options.providerSessionState,
onPayload: options.onPayload,
thinkingEnabled: Boolean(options.reasoning) && model.reasoning,
thinkingBudgetTokens: options.reasoning
? (options.thinkingBudgets?.[options.reasoning] ?? ANTHROPIC_THINKING[options.reasoning])
thinkingEnabled: Boolean(reasoningEffort) && model.reasoning,
thinkingBudgetTokens: reasoningEffort
? (options.thinkingBudgets?.[reasoningEffort] ?? ANTHROPIC_THINKING[reasoningEffort])
: undefined,
reasoning: options.reasoning,
reasoning: reasoningEffort,
toolChoice: mapAnthropicToolChoice(options.toolChoice),
},
)
@@ -329,7 +334,7 @@ export function streamGitLabDuo(
sessionId: options.sessionId,
providerSessionState: options.providerSessionState,
onPayload: options.onPayload,
reasoning: options.reasoning,
reasoning: reasoningEffort,
toolChoice: options.toolChoice,
} satisfies OpenAIResponsesOptions,
)
@@ -358,7 +363,7 @@ export function streamGitLabDuo(
sessionId: options.sessionId,
providerSessionState: options.providerSessionState,
onPayload: options.onPayload,
thinkingLevel: options.reasoning,
reasoning: reasoningEffort,
toolChoice: options.toolChoice,
} satisfies OpenAICompletionsOptions,
);
packages/ai/src/providers/kimi.ts
+6 -4
View File
@@ -62,9 +62,10 @@ export function streamKimi(
// Calculate thinking budget from reasoning level
const reasoning = options?.reasoning;
const thinkingEnabled = !!reasoning && model.reasoning;
const thinkingBudget = reasoning
? (options?.thinkingBudgets?.[reasoning] ?? ANTHROPIC_THINKING[reasoning])
const reasoningEffort = reasoning === "off" ? undefined : reasoning;
const thinkingEnabled = !!reasoningEffort && model.reasoning;
const thinkingBudget = reasoningEffort
? (options?.thinkingBudgets?.[reasoningEffort] ?? ANTHROPIC_THINKING[reasoningEffort])
: undefined;
const innerStream = streamAnthropic(anthropicModel, context, {
@@ -89,6 +90,7 @@ export function streamKimi(
}
} else {
// OpenAI format - use original model with Kimi headers
const reasoningEffort = options?.reasoning === "off" ? undefined : options?.reasoning;
const innerStream = streamOpenAICompletions(model, context, {
apiKey: options?.apiKey,
temperature: options?.temperature,
@@ -102,7 +104,7 @@ export function streamKimi(
headers: mergedHeaders,
sessionId: options?.sessionId,
onPayload: options?.onPayload,
thinkingLevel: options?.reasoning,
reasoning: reasoningEffort,
});
for await (const event of innerStream) {
packages/ai/src/providers/synthetic.ts
+6 -4
View File
@@ -59,9 +59,10 @@ export function streamSynthetic(
// Calculate thinking budget from reasoning level
const reasoning = options?.reasoning;
const thinkingEnabled = !!reasoning && model.reasoning;
const thinkingBudget = reasoning
? (options?.thinkingBudgets?.[reasoning] ?? ANTHROPIC_THINKING[reasoning])
const reasoningEffort = reasoning === "off" ? undefined : reasoning;
const thinkingEnabled = !!reasoningEffort && model.reasoning;
const thinkingBudget = reasoningEffort
? (options?.thinkingBudgets?.[reasoningEffort] ?? ANTHROPIC_THINKING[reasoningEffort])
: undefined;
const innerStream = streamAnthropic(anthropicModel, context, {
@@ -92,6 +93,7 @@ export function streamSynthetic(
headers: mergedHeaders,
};
const reasoningEffort = options?.reasoning === "off" ? undefined : options?.reasoning;
const innerStream = streamOpenAICompletions(syntheticModel, context, {
apiKey: options?.apiKey,
temperature: options?.temperature,
@@ -105,7 +107,7 @@ export function streamSynthetic(
headers: mergedHeaders,
sessionId: options?.sessionId,
onPayload: options?.onPayload,
thinkingLevel: options?.reasoning,
reasoning: reasoningEffort,
});
for await (const event of innerStream) {
packages/ai/test/stream.test.ts
+20 -20
View File
@@ -534,7 +534,7 @@ describe("Generate E2E Tests", () => {
it(
"should handle thinking",
async () => {
await handleThinking(llm, { thinkingLevel: "high" });
await handleThinking(llm, { reasoning: "high" });
},
{ retry: 2 },
);
@@ -542,7 +542,7 @@ describe("Generate E2E Tests", () => {
it(
"should handle multi-turn with thinking and tools",
async () => {
await multiTurn(llm, { thinkingLevel: "high" });
await multiTurn(llm, { reasoning: "high" });
},
{ retry: 3 },
);
@@ -658,7 +658,7 @@ describe("Generate E2E Tests", () => {
it(
"should handle thinking mode",
async () => {
await handleThinking(llm, { thinkingLevel: "medium" });
await handleThinking(llm, { reasoning: "medium" });
},
{ retry: 3 },
);
@@ -666,7 +666,7 @@ describe("Generate E2E Tests", () => {
it(
"should handle multi-turn with thinking and tools",
async () => {
await multiTurn(llm, { thinkingLevel: "medium" });
await multiTurn(llm, { reasoning: "medium" });
},
{ retry: 3 },
);
@@ -702,7 +702,7 @@ describe("Generate E2E Tests", () => {
it(
"should handle thinking mode",
async () => {
await handleThinking(llm, { thinkingLevel: "medium" });
await handleThinking(llm, { reasoning: "medium" });
},
{ retry: 3 },
);
@@ -710,7 +710,7 @@ describe("Generate E2E Tests", () => {
it(
"should handle multi-turn with thinking and tools",
async () => {
await multiTurn(llm, { thinkingLevel: "medium" });
await multiTurn(llm, { reasoning: "medium" });
},
{ retry: 3 },
);
@@ -746,7 +746,7 @@ describe("Generate E2E Tests", () => {
it(
"should handle thinking mode",
async () => {
await handleThinking(llm, { thinkingLevel: "medium" });
await handleThinking(llm, { reasoning: "medium" });
},
{ retry: 3 },
);
@@ -754,7 +754,7 @@ describe("Generate E2E Tests", () => {
it(
"should handle multi-turn with thinking and tools",
async () => {
await multiTurn(llm, { thinkingLevel: "medium" });
await multiTurn(llm, { reasoning: "medium" });
},
{ retry: 3 },
);
@@ -790,7 +790,7 @@ describe("Generate E2E Tests", () => {
it(
"should handle thinking mode",
async () => {
await handleThinking(llm, { thinkingLevel: "medium" });
await handleThinking(llm, { reasoning: "medium" });
},
{ retry: 3 },
);
@@ -798,7 +798,7 @@ describe("Generate E2E Tests", () => {
it(
"should handle multi-turn with thinking and tools",
async () => {
await multiTurn(llm, { thinkingLevel: "medium" });
await multiTurn(llm, { reasoning: "medium" });
},
{ retry: 2 },
);
@@ -842,7 +842,7 @@ describe("Generate E2E Tests", () => {
it.skip(
"should handle thinking mode",
async () => {
await handleThinking(llm, { thinkingLevel: "medium" });
await handleThinking(llm, { reasoning: "medium" });
},
{ retry: 3 },
);
@@ -850,7 +850,7 @@ describe("Generate E2E Tests", () => {
it(
"should handle multi-turn with thinking and tools",
async () => {
await multiTurn(llm, { thinkingLevel: "medium" });
await multiTurn(llm, { reasoning: "medium" });
},
{ retry: 3 },
);
@@ -886,7 +886,7 @@ describe("Generate E2E Tests", () => {
it(
"should handle thinking mode",
async () => {
await handleThinking(llm, { thinkingLevel: "medium" });
await handleThinking(llm, { reasoning: "medium" });
},
{ retry: 3 },
);
@@ -894,7 +894,7 @@ describe("Generate E2E Tests", () => {
it(
"should handle multi-turn with thinking and tools",
async () => {
await multiTurn(llm, { thinkingLevel: "medium" });
await multiTurn(llm, { reasoning: "medium" });
},
{ retry: 3 },
);
@@ -950,7 +950,7 @@ describe("Generate E2E Tests", () => {
it(
"should handle multi-turn with thinking and tools",
async () => {
await multiTurn(llm, { thinkingLevel: "medium" });
await multiTurn(llm, { reasoning: "medium" });
},
{ retry: 3 },
);
@@ -1076,7 +1076,7 @@ describe("Generate E2E Tests", () => {
"should handle thinking",
async () => {
const thinkingModel = getBundledModel("github-copilot", "gpt-5-mini");
await handleThinking(thinkingModel, { apiKey: githubCopilotToken, thinkingLevel: "high" });
await handleThinking(thinkingModel, { apiKey: githubCopilotToken, reasoning: "high" });
},
{ retry: 2 },
);
@@ -1085,7 +1085,7 @@ describe("Generate E2E Tests", () => {
"should handle multi-turn with thinking and tools",
async () => {
const thinkingModel = getBundledModel("github-copilot", "gpt-5-mini");
await multiTurn(thinkingModel, { apiKey: githubCopilotToken, thinkingLevel: "high" });
await multiTurn(thinkingModel, { apiKey: githubCopilotToken, reasoning: "high" });
},
{ retry: 3 },
);
@@ -1318,7 +1318,7 @@ describe("Generate E2E Tests", () => {
it.skipIf(!openaiCodexToken)(
"should handle thinking",
async () => {
await handleThinking(llm, { apiKey: openaiCodexToken, thinkingLevel: "high" });
await handleThinking(llm, { apiKey: openaiCodexToken, reasoning: "high" });
},
{ retry: 3 },
);
@@ -1490,7 +1490,7 @@ describe("Generate E2E Tests", () => {
"should handle thinking mode",
async () => {
if (!llm) return;
await handleThinking(llm, { apiKey: "test", thinkingLevel: "medium" });
await handleThinking(llm, { apiKey: "test", reasoning: "medium" });
},
{ retry: 3 },
);
@@ -1499,7 +1499,7 @@ describe("Generate E2E Tests", () => {
"should handle multi-turn with thinking and tools",
async () => {
if (!llm) return;
await multiTurn(llm, { apiKey: "test", thinkingLevel: "medium" });
await multiTurn(llm, { apiKey: "test", reasoning: "medium" });
},
{ retry: 3 },
);
packages/ai/test/xhigh.test.ts
+3 -3
View File
@@ -21,7 +21,7 @@ describe.skipIf(!e2eApiKey("OPENAI_API_KEY"))("xhigh reasoning", () => {
// Note: codex models only support the responses API, not chat completions
it("should work with openai-responses", async () => {
const model = getBundledModel("openai", "gpt-5.1-codex-max");
const s = stream(model, makeContext(), { thinkingLevel: "xhigh" });
const s = stream(model, makeContext(), { reasoning: "xhigh" });
let hasThinking = false;
for await (const event of s) {
@@ -40,7 +40,7 @@ describe.skipIf(!e2eApiKey("OPENAI_API_KEY"))("xhigh reasoning", () => {
describe("gpt-5-mini (does not support xhigh)", () => {
it("should error with openai-responses when using xhigh", async () => {
const model = getBundledModel("openai", "gpt-5-mini");
const s = stream(model, makeContext(), { thinkingLevel: "xhigh" });
const s = stream(model, makeContext(), { reasoning: "xhigh" });
for await (const _ of s) {
// drain events
@@ -56,7 +56,7 @@ describe.skipIf(!e2eApiKey("OPENAI_API_KEY"))("xhigh reasoning", () => {
...getBundledModel("openai", "gpt-5-mini"),
api: "openai-completions",
};
const s = stream(model, makeContext(), { thinkingLevel: "xhigh" });
const s = stream(model, makeContext(), { reasoning: "xhigh" });
for await (const _ of s) {
// drain events