smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(patches): resolved puppeteer locator timeouts

Browse Source 
- Corrected `QueryHandler.waitFor` to return results within the isolated Puppeteer world instead of transferring them to the main world.
- Prevented cross-context handle errors in Locator actions that previously caused silent retries until timeout.
This commit is contained in:
can1357
2026-07-11 06:05:13 +02:00
parent 5a4a6670b1
commit 980d24e24c
2 changed files with 38 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/coding-agent/CHANGELOG.md
+1
View File
@@ -21,6 +21,7 @@
### Fixed
- Fixed `tab.fill`/`tab.click` (and every puppeteer Locator action) timing out after 15s on all pages: the stealth patch routes default `Frame.evaluate`/`waitForFunction` through the isolated world, but `waitForSelector`/Locator results were still transferred to the main world, so Locator's enabled-precondition (`handle.frame.waitForFunction(pred, opts, handle)`) and `page.evaluate(fn, handle)` threw a cross-context handle error that Locators retried silently until timeout. `QueryHandler.waitFor` now returns its result in the isolated world, matching the patched default realm; explicit `//!world=main` evaluation still adopts handles via ElementHandle
- Fixed silent failures in ACP mode when provider errors occurred before streaming assistant text
- Prevented duplicate error messages in ACP when a provider error was both streamed and final
- Fixed `glob` reporting the contradictory "No files found matching pattern" next to a "timed out; returning 0 partial matches" notice. A timed-out empty scan now states explicitly that the result is incomplete (not proof of absence) and suggests scoping to a deeper directory, and the TUI renders it as "No matches before timeout (scan incomplete)" instead of a definitive no-files claim.
patches/puppeteer-core@25.3.0.patch
+37
View File
@@ -1,3 +1,6 @@
diff --git a/node_modules/puppeteer-core/.bun-tag-a797aeb3ca2bd69f b/.bun-tag-a797aeb3ca2bd69f
new file mode 100644
index 0000000000000000000000000000000000000000..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
diff --git a/lib/puppeteer/api/ElementHandle.js b/lib/puppeteer/api/ElementHandle.js
index 81454fe2af73518f7e76f04cbe3a7f170d735fa5..6f9eedb9fc1344901705bc83cb3cf415e6271e28 100644
--- a/lib/puppeteer/api/ElementHandle.js
@@ -614,6 +617,40 @@ index 3d68f887920ded269eb641273a5a13dee235ae1d..dcdd86c8697c0dbd2dd2162c9a739dd9
}
mainRealm() {
return this.#world;
diff --git a/lib/puppeteer/common/QueryHandler.js b/lib/puppeteer/common/QueryHandler.js
index 8c406cf90e0f9d899efaa5acb6a636a86f32e37e..185ef5954b2b95b708855ed68e8327a8c51f9e70 100644
--- a/lib/puppeteer/common/QueryHandler.js
+++ b/lib/puppeteer/common/QueryHandler.js
@@ -152,8 +152,8 @@ export class QueryHandler {
* Waits until a single node appears for a given selector and
* {@link ElementHandle}.
*
- * This will always query the handle in the Puppeteer world and migrate the
- * result to the main world.
+ * This will always query the handle in the Puppeteer world and return the
+ * result in that world.
*/
static async waitFor(elementOrFrame, selector, options) {
const env_3 = { stack: [], error: void 0, hasError: false };
@@ -191,7 +191,17 @@ export class QueryHandler {
if (!(_isElementHandle in handle)) {
return null;
}
- return await frame.mainRealm().transferHandle(handle);
+ // xxx-stealth: keep the result in the isolated (Puppeteer)
+ // world instead of upstream's mainRealm transfer. The stealth
+ // patch routes default Frame.evaluate/waitForFunction and $/$$
+ // through the isolated world, so a main-world handle here made
+ // every consumer that passes the handle back in (Locator's
+ // enabled precondition, page.evaluate(fn, handle)) throw
+ // "JSHandles can be evaluated only in the context they were
+ // created!" — Locators retried that silently until timeout.
+ // Intentional main-world evaluation still adopts via the
+ // //!world=main directive path in ElementHandle.
+ return handle.move();
}
catch (e_3) {
env_4.error = e_3;
diff --git a/lib/puppeteer/node/ChromeLauncher.js b/lib/puppeteer/node/ChromeLauncher.js
index fb7fe66ecb99fd207b99c1e9a9ae00769f0b9a20..af5284b9ee8226e78fa0243ec2f83a631bbaca9d 100644
--- a/lib/puppeteer/node/ChromeLauncher.js