smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(coding-agent): fixed Task tool output duplication from streaming events

Browse Source 
message_update events contain full accumulated text, not deltas.
Previously appending them caused repeated content in artifacts and
progress display. Now message_update only updates progress display
(replacing, not accumulating) and message_end handles final output.
This commit is contained in:
can1357
2026-01-03 05:30:37 +01:00
parent 50ab6b8b1b
commit 8aaeaadcdc
2 changed files with 23 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/coding-agent/CHANGELOG.md
+5
View File
@@ -17,6 +17,11 @@
- Updated bundled `reviewer` agent to use structured review tools with priority-based findings (P0-P3) and formal verdict submission
### Fixed
- Fixed Task tool output artifacts (`out.md`) containing duplicated text from streaming updates
- Fixed Task tool progress display showing repeated nearly-identical lines during streaming
## [1.341.0] - 2026-01-03
### Added
packages/coding-agent/src/core/tools/task/executor.ts
+18 -11
View File
@@ -259,22 +259,29 @@ export async function runSubprocess(options: ExecutorOptions): Promise<SingleRes
progress.currentToolStartMs = undefined;
break;
case "message_update":
case "message_update": {
// Extract text for progress display only (replace, don't accumulate)
const updateContent = event.message?.content || event.content;
if (updateContent && Array.isArray(updateContent)) {
const allText: string[] = [];
for (const block of updateContent) {
if (block.type === "text" && block.text) {
const lines = block.text.split("\n").filter((l: string) => l.trim());
allText.push(...lines);
}
}
// Show last 8 lines from current state (not accumulated)
progress.recentOutput = allText.slice(-8).reverse();
}
break;
}
case "message_end": {
// Extract text content for recent output (prefer message.content, fallback to event.content)
// Extract final text content from completed message
const messageContent = event.message?.content || event.content;
if (messageContent && Array.isArray(messageContent)) {
for (const block of messageContent) {
if (block.type === "text" && block.text) {
const lines = block.text.split("\n").filter((l: string) => l.trim());
for (const l of lines) {
if (!progress.recentOutput.includes(l)) {
progress.recentOutput.unshift(l);
if (progress.recentOutput.length > 8) {
progress.recentOutput.pop();
}
}
}
output += block.text;
}
}