smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(collab): converted guest prompts in side requests

Browse Source 
Routed direct custom-message conversion through the collab steering transform so side requests and compaction see the same enveloped user turn as primary requests.

Extended the regression test to exercise convertToLlm without transformContext.
This commit is contained in:
roboomp
2026-08-01 17:10:36 +00:00
parent 352c0fdce2
commit 8378d523ce
2 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/coding-agent/src/session/messages.ts
+4
View File
@@ -1166,6 +1166,10 @@ function convertOne(m: AgentMessage, interruptedNext: boolean): Message[] {
}
case "custom": {
if (!isCustomMessageContent(m.content)) return [];
if (isSteeringUserMessage(m)) {
const converted = convertMessageToLlm(wrapSteeringUserMessage(m));
return converted ? [converted] : [];
}
if (isUserInvokedSkillPrompt(m)) {
return [
{
packages/coding-agent/test/session-messages.test.ts
+9 -4
View File
@@ -383,7 +383,7 @@ describe("wrapSteeringForModel", () => {
expect(wrappedText).not.toContain("&");
});
it("presents user-attributed collab prompts as wrapped user turns", () => {
it("presents user-attributed collab prompts as wrapped user turns on every conversion path", () => {
const message: AgentMessage = {
role: "custom",
customType: COLLAB_PROMPT_MESSAGE_TYPE,
@@ -394,14 +394,19 @@ describe("wrapSteeringForModel", () => {
timestamp: 1,
};
const directlyConverted = convertToLlm([message]);
const wrapped = wrapSteeringForModel([message]);
const providerMessages = convertToLlm(wrapped);
const primaryProviderMessages = convertToLlm(wrapped);
expect(directlyConverted).toHaveLength(1);
expect(directlyConverted[0]?.role).toBe("user");
expect(getUserText(directlyConverted[0])).toContain("<system-notice>");
expect(getUserText(directlyConverted[0])).toContain("Reply with exactly PONG");
expect(wrapped[0]?.role).toBe("user");
expect(getUserText(wrapped[0])).toContain("<system-notice>");
expect(getUserText(wrapped[0])).toContain("Reply with exactly PONG");
expect(providerMessages).toHaveLength(1);
expect(providerMessages[0]?.role).toBe("user");
expect(primaryProviderMessages).toHaveLength(1);
expect(primaryProviderMessages[0]?.role).toBe("user");
expect(message).toMatchObject({
role: "custom",
details: { from: "guest" },