smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(tui): respected resize-in-place opt-out after detection

Browse Source 
Gate the runtime alt-toggle resize latch when PI_TUI_RESIZE_IN_PLACE explicitly forces the fast path off, while preserving multiplexer handling.

Add regression coverage that auto-detects the alt-toggle echo, then verifies a later width resize still borrows the alternate screen and performs the authoritative ED3 rewrap.
This commit is contained in:
roboomp
2026-07-24 12:30:23 +00:00
parent fe4dec9b9b
commit 44586a9324
2 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/tui/src/tui.ts
+5 -1
View File
@@ -3850,9 +3850,13 @@ export class TUI extends Container {
* ({@link resizeRepaintsInPlace}) with the runtime {@link #altToggleResizesInPlace}
* latch, so a terminal that re-reports its size on alt-screen toggles is
* treated like Warp once observed, breaking the overlay-exit ED3 flash loop.
* An explicit `PI_TUI_RESIZE_IN_PLACE=0|false` suppresses the runtime latch;
* multiplexer handling remains authoritative through the static predicate.
*/
#resizeRepaintsInPlace(): boolean {
return resizeRepaintsInPlace() || this.#altToggleResizesInPlace;
const override = Bun.env.PI_TUI_RESIZE_IN_PLACE;
const allowAutoDetection = override !== "0" && override !== "false";
return resizeRepaintsInPlace() || (allowAutoDetection && this.#altToggleResizesInPlace);
}
/**
packages/tui/test/overlay-exit-flicker.test.ts
+12 -1
View File
@@ -87,7 +87,7 @@ class Modal implements Component {
describe("fullscreen overlay exit on alt-toggle-size terminals (#6511)", () => {
afterEach(() => vi.restoreAllMocks());
it("does not flash an ED3 rebuild when the terminal echoes a size on alt toggle", async () => {
it("auto-detects alt-toggle size echoes while respecting the explicit opt-out", async () => {
await withEnv(ENV, async () => {
const term = new VirtualTerminal(40, 10, 1000);
const scheduler = new Scheduler();
@@ -124,6 +124,17 @@ describe("fullscreen overlay exit on alt-toggle-size terminals (#6511)", () => {
await scheduler.flushAll(term);
expect(writes.slice(exitWrites).join("")).not.toContain("\x1b[3J");
expect(term.getViewport().at(-1)?.trimEnd()).toBe("line-29");
// The explicit opt-out must win even after runtime auto-detection.
// A later width drag therefore borrows the alt buffer and performs
// its authoritative ED3 rewrap at settle.
Bun.env.PI_TUI_RESIZE_IN_PLACE = "0";
const optOutWrites = writes.length;
term.resize(50, 10);
await scheduler.flushAll(term);
const optOut = writes.slice(optOutWrites).join("");
expect(optOut).toContain("\x1b[?1049h");
expect(optOut).toContain("\x1b[3J");
} finally {
tui.stop();
}