smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use centralized busy timeout in auth credential store

Browse Source 
SqliteAuthCredentialStore re-ran PRAGMA busy_timeout = 5000 on the
shared agent.db connection, overwriting the headless 1000ms bound set by
AgentStorage — so RPC/ACP/eval hosts could still stall synchronously for
five seconds per statement after auth-store initialization. Route it
through getDbBusyTimeoutMs() so the headless bound survives.
This commit is contained in:
pi3123
2026-07-31 23:41:08 -07:00
parent 4a9350963f
commit 15ebb96f0f
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/ai/src/auth-storage.ts
+5 -3
View File
@@ -12,7 +12,7 @@ import { createHash } from "node:crypto";
import * as fs from "node:fs/promises";
import * as path from "node:path";
import { parseAlibabaTokenPlanCredential } from "@oh-my-pi/pi-catalog/wire/alibaba-token-plan";
import { $env, getAgentDbPath, logger } from "@oh-my-pi/pi-utils";
import { $env, getAgentDbPath, getDbBusyTimeoutMs, logger } from "@oh-my-pi/pi-utils";
import type { ApiKeyResolver } from "./auth-retry";
import * as AIError from "./error";
import { isUsageLimitOutcome } from "./error/rate-limit";
@@ -6929,8 +6929,10 @@ export class SqliteAuthCredentialStore implements AuthCredentialStore {
// Install the busy handler BEFORE any lock-taking statement (incl.
// `PRAGMA journal_mode=WAL`, which acquires an exclusive lock during WAL
// recovery). Without this, concurrent omp startups can crash here with
// `SQLITE_BUSY` / `SQLITE_BUSY_RECOVERY`. See issue #2421.
this.#db.run("PRAGMA busy_timeout = 5000");
// `SQLITE_BUSY` / `SQLITE_BUSY_RECOVERY`. See issue #2421. Uses the
// centralized timeout so a headless host keeps its bounded busy wait
// instead of overwriting it with the interactive 5s value.
this.#db.run(`PRAGMA busy_timeout = ${getDbBusyTimeoutMs()}`);
this.#db.run(`
PRAGMA journal_mode=WAL;
PRAGMA synchronous=NORMAL;