smashimo/oh-my-pi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(agent): skip V2 retries for compaction auth errors

Browse Source 
(cherry picked from commit 07a54771834435b7897208ab9d6d42401f0203e1)
This commit is contained in:
usr-bin-roygbiv
2026-07-28 10:23:50 +00:00
committed by can1357
parent b927da95e6
commit 0c31095d34
2 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/agent/src/compaction/compaction-v2-streaming.ts
+8 -4
View File
@@ -8,7 +8,7 @@
*/
import type { Api, CodexCompactionContext, FetchImpl, Model, ProviderSessionState } from "@oh-my-pi/pi-ai";
import { isTransientStatus, ProviderHttpError } from "@oh-my-pi/pi-ai/error";
import * as AIError from "@oh-my-pi/pi-ai/error";
import { applyCodexResponsesLiteShape } from "@oh-my-pi/pi-ai/providers/openai-codex/request-transformer";
import {
createOpenAICodexCompactionRequestContext,
@@ -342,7 +342,7 @@ async function attemptCompactionV2Streaming(
statusText: response.statusText,
errorText: cause.captured.bodyText ?? "",
});
throw new ProviderHttpError(
throw new AIError.ProviderHttpError(
`V2 remote compaction failed (${response.status} ${response.statusText})`,
response.status,
{
@@ -562,6 +562,10 @@ function formatCompactionV2Failure(event: Record<string, unknown>, type: string)
}
function isRetryableCompactionError(error: Error): boolean {
// The gateway's synthetic auth_unavailable is an HTTP 503, but the
// captured response cause classifies it as auth. Let provider fallback run
// immediately instead of spending the transient retry budget.
if (AIError.is(AIError.classify(error), AIError.Flag.AuthFailed)) return false;
if (
error.name === "AbortError" ||
error.name === "TimeoutError" ||
@@ -569,8 +573,8 @@ function isRetryableCompactionError(error: Error): boolean {
) {
return true;
}
if (error instanceof ProviderHttpError) {
return isTransientStatus(error.status);
if (error instanceof AIError.ProviderHttpError) {
return AIError.isTransientStatus(error.status);
}
const message = error.message.toLowerCase();
return (
packages/agent/test/remote-compaction.test.ts
+2 -2
View File
@@ -736,7 +736,7 @@ describe("requestCompactionV2Streaming", () => {
expect(attempts).toBe(2);
});
test("preserves auth_unavailable from V2 HTTP failures", async () => {
test("does not retry and preserves auth_unavailable from V2 HTTP failures", async () => {
const model = makeOpenAiModel({
remoteCompaction: {
enabled: true,
@@ -761,7 +761,7 @@ describe("requestCompactionV2Streaming", () => {
retryWait: async () => {},
}).catch(cause => cause);
expect(fetchMock).toHaveBeenCalled();
expect(fetchMock).toHaveBeenCalledTimes(1);
expect(error).toBeInstanceOf(AIError.ProviderHttpError);
expect(AIError.is(AIError.classify(error), AIError.Flag.AuthFailed)).toBe(true);
});