ghosty93 ffb816fe7f fix(coding-agent): classify destructive rm with long options as critical ...

`CRITICAL_BASH_PATTERNS` required the target to follow one short flag
cluster directly, so anything in between escaped the check:

    rm -rf /                      matched
    rm -rf -- /                   missed
    rm --recursive --force /      missed
    rm -rf --no-preserve-root /   missed
    rm --no-preserve-root -rf /   missed

The last two matter most. GNU coreutils already refuses `rm -rf /` with
"it is dangerous to operate recursively on '/'" and names
`--no-preserve-root` as the override, so the pattern matched the form
that fails safe and missed the form that does not.

Repeat the option separator instead of assuming the path follows one
cluster, and treat `--no-preserve-root` as critical wherever it appears.
Absolute targets are still required for the first pattern, so
`rm -rf -- ./build` and `rm --recursive --force ./dist` stay benign;
both are asserted in the test.

PR #5270 reported the `--` and long-option forms in July and was closed
unmerged by the contributor-vouch bot rather than on merit. This keeps
its cases, credits them in the tests, and adds the `--no-preserve-root`
forms that patch did not cover.

2026-08-16 22:41:44 +03:00

..

hub

fix(hub): wake owners when supervised processes exit

2026-08-03 01:31:39 -07:00

web-scrapers

…

apply-patch-renderer.test.ts

chore: update tests

2026-07-05 16:53:07 +02:00

approval-mode.test.ts

feat(coding-agent): added opt-in task prewalk and tightened --tools and xdev behavior

2026-07-15 18:39:36 +02:00

approval.test.ts

fix(coding-agent): classify destructive rm with long options as critical

2026-08-16 22:41:44 +03:00

ask.test.ts

fix(ask): preserved empty multi-select answers

2026-08-16 02:13:40 +02:00

ast-edit.test.ts

test: refactored test suites to eliminate time-based sleeps and polling loops

2026-08-13 19:32:22 +02:00

ast-grep.test.ts

test: refactored test suites to eliminate time-based sleeps and polling loops

2026-08-13 19:32:22 +02:00

auto-generated-guard.test.ts

fix(coding-agent): used session settings in file guards

2026-07-24 22:42:38 +00:00

bash-interceptor.test.ts

fix(tool): preserved piped stdin across continuations

2026-08-03 12:45:50 +00:00

bash-pty-selection.test.ts

…

bash-sixel-render.test.ts

test: refactored test suites to eliminate time-based sleeps and polling loops

2026-08-13 19:32:22 +02:00

bash-skill-urls.test.ts

fix: treat escaped quotes inside double-quoted backticks as inner quoting

2026-07-23 22:15:23 +02:00

browser-aria-snapshot.test.ts

Merge PR #5778: fix(browser): reject non-string tab selectors with a named error (@roboomp)

2026-07-18 20:13:44 +02:00

browser-attach.test.ts

Merge PR #8569: fix(browser): probe CDP endpoints over raw TCP to bypass HTTP_PROXY (@roboomp)

2026-08-16 02:43:33 +02:00

browser-cmux-eval-envelope.test.ts

test(coding-agent): validated behavioral consistency across core toolset

2026-07-11 05:47:55 +02:00

browser-cmux-guest-rejection.test.ts

fix(browser): scoped cmux attribution to guest stacks

2026-08-02 09:37:17 +00:00

browser-cmux-kind.test.ts

…

browser-cmux-observation.test.ts

…

browser-cmux-release-mid-run.test.ts

test: refactored test suites to eliminate time-based sleeps and polling loops

2026-08-13 19:32:22 +02:00

browser-cmux-socket.test.ts

fix(browser): supported authenticated cmux tcp relays

2026-07-17 03:42:01 +00:00

browser-display-format.test.ts

feat(coding-agent/tools): introduced language-specific code formatters for display rendering

2026-07-24 16:26:03 +02:00

browser-dispose-timeout.test.ts

test: refactored test suites to eliminate time-based sleeps and polling loops

2026-08-13 19:32:22 +02:00

browser-launch.test.ts

Merge PR #8624: fix(browser): suppress blank shared startup window (@roboomp)

2026-08-16 02:43:32 +02:00

browser-lifecycle-leak.test.ts

fix(browser): bounded tab teardown waits

2026-07-14 17:37:01 +00:00

browser-op-tracking.test.ts

chore: applied formatter and deduplicated observer stubs in task fixtures

2026-07-31 19:51:52 +02:00

browser-open-lease.test.ts

fix(browser): bound open timeout and lease browser across tab acquisition

2026-07-23 19:02:38 +00:00

browser-profile-cleanup.test.ts

fix(browser): reused shared temp removal retries

2026-07-30 05:22:14 +00:00

browser-readable.test.ts

…

browser-relay-bridge.test.ts

fix(coding-agent/tools): serialized tab grouping operations in the relay bridge

2026-08-02 18:07:07 +02:00

browser-relay-daemon.test.ts

fix(browser): bypassed proxies for relay probes

2026-08-16 02:43:33 +02:00

browser-relay-kind.test.ts

feat: introduced OMP Browser Relay extension with CDP RPC execution

2026-08-02 05:33:07 +02:00

browser-run-cancellation.test.ts

feat(coding-agent): supported allSettled and any promise combinators in browser scope

2026-08-14 00:11:04 +02:00

browser-run-output.test.ts

feat(coding-agent): integrated google search with shared browser utilities

2026-07-11 07:33:19 +02:00

browser-schema.test.ts

feat: implemented shared serialization utilities and standardized inventories

2026-08-03 05:06:49 +02:00

browser-stealth-acquire-debugerror.test.ts

fix(browser): use debugCatchError in stealth acquire paths

2026-07-14 18:14:14 +00:00

browser-tab-timeouts.test.ts

feat(computer): implemented modular desktop backend and script workflows

2026-08-02 19:46:25 +02:00

browser-tab-worker-startup.test.ts

…

chromium-probe.ts

test(browser): stop gating chromium tests on a top-level-await export

2026-08-02 05:00:26 -07:00

computer.test.ts

test: refactored test suites to eliminate time-based sleeps and polling loops

2026-08-13 19:32:22 +02:00

conflict-detect.test.ts

feat(coding-agent-tools): implemented auto-trimming for echo lines

2026-07-11 17:04:23 +02:00

conflict-integration.test.ts

Merge PR #5044: fix(cli): parse max-time duration suffixes (@roboomp)

2026-07-14 18:46:14 +02:00

edit-diff.test.ts

feat(diff): implemented native UTF-16 diff processing and removed jsdiff

2026-07-23 01:35:31 +02:00

edit-renderer.test.ts

Merge PR #8662: perf(coding-agent): bound streaming diff previews (@lemonleks)

2026-08-16 02:13:37 +02:00

eval-agent-progress.test.ts

…

eval-clone-error.test.ts

propagate ipc clone errors to eval cells

2026-07-13 09:57:20 -04:00

eval-code-preview.test.ts

…

eval-commit-stability.test.ts

chore: update tests

2026-07-05 16:53:07 +02:00

eval-description-spawn-default.test.ts

chore: reorg tests

2026-07-27 16:43:53 +02:00

eval-description.test.ts

feat(coding-agent/prompts): refined tool prompts for shell, browser, and eval workflows

2026-07-15 03:28:21 +02:00

eval-display-format.test.ts

feat(coding-agent/tools): introduced language-specific code formatters for display rendering

2026-07-24 16:26:03 +02:00

eval-display-text.test.ts

…

eval-fallback.test.ts

…

eval-format-javascript.test.ts

feat(natives): enabled per-language rewrite rules for mixed-language paths

2026-07-24 21:52:29 +02:00

eval-format-julia.test.ts

feat(natives): enabled per-language rewrite rules for mixed-language paths

2026-07-24 21:52:29 +02:00

eval-format-python.test.ts

feat(coding-agent/tools): introduced language-specific code formatters for display rendering

2026-07-24 16:26:03 +02:00

eval-format-ruby.test.ts

chore(coding-agent): format eval display helpers

2026-07-24 16:49:31 +02:00

eval-streaming-output.test.ts

fix(eval): preserve column truncation metadata

2026-07-16 03:32:03 +02:00

eval-timeout.test.ts

test: refactored test suites to eliminate time-based sleeps and polling loops

2026-08-13 19:32:22 +02:00

fetch-binary-dispatch.test.ts

…

fetch-jina-stall.test.ts

test: refactored test suites to eliminate time-based sleeps and polling loops

2026-08-13 19:32:22 +02:00

fetch-kagi-toggle.test.ts

test(coding-agent): dropped stale URL read-cache assertions

2026-07-17 22:16:21 +02:00

fetch-raw-mode.test.ts

fix(read): refreshed URL responses on each invocation

2026-07-17 07:45:06 +00:00

fetch-url-selectors.test.ts

…

gh-cache-invalidation.test.ts

test: refactored test suites to eliminate time-based sleeps and polling loops

2026-08-13 19:32:22 +02:00

gh.test.ts

test: refactored test suites to eliminate time-based sleeps and polling loops

2026-08-13 19:32:22 +02:00

github-cache.test.ts

test: refactored test suites to eliminate time-based sleeps and polling loops

2026-08-13 19:32:22 +02:00

glob-renderer.test.ts

test(coding-agent): validated behavioral consistency across core toolset

2026-07-11 05:47:55 +02:00

glob-validate-paths.test.ts

fix(coding-agent): split semicolon path lists that trip ENAMETOOLONG

2026-08-04 06:07:42 +00:00

glob.test.ts

chore: reorg tests

2026-07-27 16:43:53 +02:00

grep-internal-urls.test.ts

test: refactored test suites to eliminate time-based sleeps and polling loops

2026-08-13 19:32:22 +02:00

grep-path-lists.test.ts

test: cleaned test suites and documented filtering guidelines

2026-08-13 08:28:42 +02:00

grep-renderer.test.ts

…

grouped-file-output.test.ts

…

hub-list.test.ts

feat: added live tracking and stale status warnings for agent activity snapshots

2026-08-16 10:18:56 +03:00

hub-wait.test.ts

feat: added live tracking and stale status warnings for agent activity snapshots

2026-08-16 10:18:56 +03:00

image-gen.test.ts

test: refactored test suites to eliminate time-based sleeps and polling loops

2026-08-13 19:32:22 +02:00

index.test.ts

test(coding-agent): included think tool in HIDDEN_TOOLS expectation

2026-08-11 21:01:02 +02:00

inspect-image.test.ts

test: refactored test suites to eliminate time-based sleeps and polling loops

2026-08-13 19:32:22 +02:00

irc-renderer.test.ts

refactor(coding-agent): consolidated tool surface onto xd:// devices and hub

2026-07-15 15:16:29 +02:00

irc-roster-activity.test.ts

refactor(coding-agent): consolidated tool surface onto xd:// devices and hub

2026-07-15 15:16:29 +02:00

irc.test.ts

fix(hub): prevented stale agent refs from blocking wait

2026-08-15 10:19:05 +00:00

json-tree.test.ts

chore: reorg tests

2026-07-27 16:43:53 +02:00

jtd-to-json-schema.test.ts

fix(coding-agent/tools): deduplicate JTD primitive detection

2026-08-07 00:17:38 +07:00

launch-eisdir-fallback.test.ts

fix(coding-agent/launch): handle EISDIR from realpath on drive roots

2026-07-16 13:55:22 +00:00

launch-renderer.test.ts

fix(coding-agent/launch): surfaced pre-ready exits in TUI

2026-07-22 16:43:35 +00:00

lsp-batching.test.ts

fix(coding-agent): preserve BOMs in LSP batch flushes

2026-07-30 17:02:16 +08:00

lsp-diagnostics-dedup.test.ts

…

lsp-diagnostics-freshness.test.ts

fix(lsp): normalized published diagnostic uri keys

2026-08-04 23:53:08 +00:00

lsp-regressions.test.ts

fix(lsp): preserved rust-analyzer reload params

2026-08-16 02:43:33 +02:00

memory-renderer.test.ts

test: refactored test suites to eliminate time-based sleeps and polling loops

2026-08-13 19:32:22 +02:00

multi-grep-path.test.ts

test: refactored test suites to eliminate time-based sleeps and polling loops

2026-08-13 19:32:22 +02:00

multi-path-missing.test.ts

test: refactored test suites to eliminate time-based sleeps and polling loops

2026-08-13 19:32:22 +02:00

output-caps.test.ts

…

output-schema-validator.test.ts

…

path-literal-colon-selector.test.ts

test: refactored test suites to eliminate time-based sleeps and polling loops

2026-08-13 19:32:22 +02:00

path-renderer-invalid-args.test.ts

fix(tui): handled invalid path render args

2026-07-04 15:47:52 +00:00

path-utils-dotdot-selector.test.ts

…

plan-mode-guard-local.test.ts

…

provider-schema-compatibility.test.ts

test: refactored test suites to eliminate time-based sleeps and polling loops

2026-08-13 19:32:22 +02:00

puppeteer-stealth-patch.test.ts

fix(test): repair auth-storage-rotation merge resolution and normalize changelogs

2026-07-14 18:50:47 +02:00

read-artifact-large.test.ts

fix(read): expose artifact source line totals

2026-08-05 01:11:59 +02:00

read-directory-range.test.ts

…

read-fs-not-abortable.test.ts

…

read-local-image.test.ts

fix(coding-agent): declared restricted slate in local image read test

2026-07-27 23:53:47 +02:00

read-pdf-line-range.test.ts

Revert "Merge PR #5812: fix(read): honor exact line selector bounds (@roboomp)"

2026-07-18 22:04:43 +02:00

read-pdf-rendering.test.ts

feat(coding-agent/tools): implemented pdf page screenshot rendering

2026-08-14 14:37:56 +02:00

read-raw-range.test.ts

fix(cursor): corrected inline read range metadata

2026-08-04 04:13:35 +00:00

read-renderer.test.ts

fix(coding-agent): preserved default markdown rendering for internal-URL reads

2026-07-23 17:30:33 +02:00

render-utils.test.ts

perf(coding-agent): bound completed diff rendering

2026-08-15 20:39:36 +04:00

report-tool-issue-consent.test.ts

fix(coding-agent): renamed settings keys to avoid nested-value lookup collisions

2026-07-15 19:08:37 +02:00

report-tool-issue.test.ts

fix(tools): autoqa consent handling from default off to opt-in

2026-07-23 13:24:45 +02:00

resolve.test.ts

refactor(coding-agent): consolidated tool surface onto xd:// devices and hub

2026-07-15 15:16:29 +02:00

review.test.ts

refactor(coding-agent): consolidated tool surface onto xd:// devices and hub

2026-07-15 15:16:29 +02:00

root-path-alias.test.ts

refactor(coding-agent): consolidated tool surface onto xd:// devices and hub

2026-07-15 15:16:29 +02:00

schema-validation.test.ts

Revert "fix(agent-loop): discard incomplete sibling tool calls"

2026-07-16 04:08:59 +02:00

search-url-paths.test.ts

fix(read): refreshed URL responses on each invocation

2026-07-17 07:45:06 +00:00

shell-tokenize.test.ts

fix(bash): preserve escaped newline semantics

2026-08-07 13:39:54 +02:00

split-internal-url-sel.test.ts

…

sqlite.test.ts

…

ssh-url-approval-gate.test.ts

…

ssh-url-approval.test.ts

…

ssh-url-localhost-e2e.test.ts

…

ssh-url-ungated-tools.test.ts

…

strip-output-notice.test.ts

…

task-agent-capabilities.test.ts

feat(coding-agent): added opt-in task prewalk and tightened --tools and xdev behavior

2026-07-15 18:39:36 +02:00

task-async-fallback.test.ts

chore: fix stale tests

2026-07-11 19:10:40 +02:00

task-repair-args.test.ts

feat(coding-agent-task): implemented agent-centric flat task structure

2026-07-11 13:44:04 +02:00

think-renderer.test.ts

feat: implemented external thinking flags and transport reasoning controls

2026-08-12 02:23:17 +02:00

todo.test.ts

fix: kept out-of-order todo completions visible

2026-08-11 15:06:12 +02:00

tool-errors.test.ts

fix(coding-agent): resolved browser teardown crashes by tracking expected abort errors

2026-07-06 08:07:24 +02:00

tool-output-hyperlinks.test.ts

…

tool-timeouts.test.ts

fix(tools): cap per-tool default timeout with tools.maxTimeout

2026-07-22 15:18:27 +00:00

vibe-render.test.ts

chore: reorg tests

2026-07-27 16:43:53 +02:00

web-search-browser-headers.test.ts

refactor: migrated packages to internal utility modules and removed external dependencies

2026-08-05 13:39:09 +02:00

web-search-codex.test.ts

chore(format): applied biome formatting and removed dead code from merged prs

2026-08-11 15:14:15 +02:00

web-search-duckduckgo.test.ts

chore: applied biome formatting to merged pull request sources

2026-07-31 19:32:42 +02:00

web-search-exa.test.ts

chore(format): applied biome formatting and removed dead code from merged prs

2026-08-11 15:14:15 +02:00

web-search-firecrawl.test.ts

feat(coding-agent/web): expanded web search and fetching providers

2026-08-10 11:06:22 +02:00

web-search-gemini.test.ts

chore(format): applied biome formatting and removed dead code from merged prs

2026-08-11 15:14:15 +02:00

web-search-kagi.test.ts

chore(format): applied biome formatting and removed dead code from merged prs

2026-08-11 15:14:15 +02:00

web-search-kimi.test.ts

feat(coding-agent/web): introduced structured web-search query parsing module

2026-07-24 16:05:14 +02:00

web-search-mojeek.test.ts

feat(coding-agent/web): introduced structured web-search query parsing module

2026-07-24 16:05:14 +02:00

web-search-parallel.test.ts

feat(coding-agent/web): expanded web search and fetching providers

2026-08-10 11:06:22 +02:00

web-search-public.test.ts

refactor(coding-agent): removed unreliable web search providers

2026-07-13 00:34:27 +02:00

web-search-searxng.test.ts

chore(format): applied biome formatting and removed dead code from merged prs

2026-08-11 15:14:15 +02:00

web-search-tavily.test.ts

…

web-search-tinyfish.test.ts

chore(format): applied biome formatting and removed dead code from merged prs

2026-08-11 15:14:15 +02:00

web-search-xai.test.ts

feat(coding-agent/web): expanded web search and fetching providers

2026-08-10 11:06:22 +02:00

windows-drive-alias.test.ts

…

yield-extraction.test.ts

…

yield.test.ts

test: cleaned test suites and documented filtering guidelines

2026-08-13 08:28:42 +02:00