Carl
2b480f7da1
fixed retained-kernel restart and owner cleanup edge cases during recovery and disposal tracked async user_python hooks during disposal-sensitive execution paths and hardened startup warmup tracking strengthened cleanup and kernel lifecycle regressions to remove deadlocks, false positives, and timing flakes
97 lines
2.8 KiB
TypeScript
97 lines
2.8 KiB
TypeScript
import { afterEach, beforeEach, describe, expect, it } from "bun:test";
|
|
import { disposeAllKernelSessions, executePython } from "@oh-my-pi/pi-coding-agent/ipy/executor";
|
|
import type {
|
|
KernelExecuteOptions,
|
|
KernelExecuteResult,
|
|
KernelShutdownResult,
|
|
} from "@oh-my-pi/pi-coding-agent/ipy/kernel";
|
|
import { PythonKernel } from "@oh-my-pi/pi-coding-agent/ipy/kernel";
|
|
import { TempDir } from "@oh-my-pi/pi-utils";
|
|
|
|
class FakeKernel {
|
|
executeCalls = 0;
|
|
shutdownCalls = 0;
|
|
alive = true;
|
|
readonly id: string;
|
|
|
|
constructor(id: string) {
|
|
this.id = id;
|
|
}
|
|
|
|
async execute(_code: string, options?: KernelExecuteOptions): Promise<KernelExecuteResult> {
|
|
this.executeCalls += 1;
|
|
options?.onChunk?.("ok\n");
|
|
return { status: "ok", cancelled: false, timedOut: false, stdinRequested: false };
|
|
}
|
|
|
|
async shutdown(): Promise<KernelShutdownResult> {
|
|
this.shutdownCalls += 1;
|
|
this.alive = false;
|
|
return { confirmed: true };
|
|
}
|
|
|
|
isAlive(): boolean {
|
|
return this.alive;
|
|
}
|
|
|
|
async ping(): Promise<boolean> {
|
|
return this.alive;
|
|
}
|
|
}
|
|
|
|
describe("executePython kernel reuse", () => {
|
|
const originalStart = PythonKernel.start;
|
|
let startCalls = 0;
|
|
let kernels: FakeKernel[] = [];
|
|
|
|
beforeEach(() => {
|
|
Bun.env.PI_PYTHON_SKIP_CHECK = "1";
|
|
startCalls = 0;
|
|
kernels = [];
|
|
PythonKernel.start = (async () => {
|
|
startCalls += 1;
|
|
const kernel = new FakeKernel(`kernel-${startCalls}`);
|
|
kernels.push(kernel);
|
|
return kernel as unknown as PythonKernel;
|
|
}) as typeof PythonKernel.start;
|
|
});
|
|
|
|
afterEach(async () => {
|
|
PythonKernel.start = originalStart;
|
|
await disposeAllKernelSessions();
|
|
});
|
|
|
|
it("reuses kernels for session mode", async () => {
|
|
using tempDir = TempDir.createSync("@python-kernel-session-");
|
|
await executePython("print('one')", { cwd: tempDir.path(), sessionId: "session-a", kernelMode: "session" });
|
|
await executePython("print('two')", { cwd: tempDir.path(), sessionId: "session-a", kernelMode: "session" });
|
|
|
|
expect(startCalls).toBe(1);
|
|
expect(kernels[0]?.executeCalls).toBe(2);
|
|
});
|
|
|
|
it("creates and disposes per-call kernels", async () => {
|
|
using tempDir = TempDir.createSync("@python-kernel-session-");
|
|
await executePython("print('one')", { cwd: tempDir.path(), kernelMode: "per-call" });
|
|
await executePython("print('two')", { cwd: tempDir.path(), kernelMode: "per-call" });
|
|
|
|
expect(startCalls).toBe(2);
|
|
expect(kernels[0]?.shutdownCalls).toBe(1);
|
|
expect(kernels[1]?.shutdownCalls).toBe(1);
|
|
});
|
|
|
|
it("resets the session kernel when requested", async () => {
|
|
using tempDir = TempDir.createSync("@python-kernel-session-");
|
|
await executePython("print('one')", { cwd: tempDir.path(), sessionId: "session-b", kernelMode: "session" });
|
|
await executePython("print('two')", {
|
|
cwd: tempDir.path(),
|
|
sessionId: "session-b",
|
|
kernelMode: "session",
|
|
reset: true,
|
|
});
|
|
|
|
expect(startCalls).toBe(2);
|
|
expect(kernels[0]?.shutdownCalls).toBe(1);
|
|
});
|
|
});
|