Diogo Soares Rodrigues
4a946ad8c0
Advisor tools are built straight from the builtin table, outside the loop that wraps every registry tool in `ExtensionToolWrapper` - which is where the approval mode, per-tool `tools.approval.<tool>` policies and `autoApprove` are enforced. Both the advisor's own agent loop and its Cursor exec bridge (`pi_write`, `pi_bash`) run those instances directly, so an advisor granted `write` or `bash` executed them regardless of a configured `ask` or `deny`. Verified before the fix: a raw `write` instance created the file under `tools.approval.write: deny`; the wrapped one refuses. `bridgeToolMap` and the grep factory only ever wrapped the two tools they build themselves. The grep answer also now echoes `offset_applied`. Forwarding the offset without acknowledging it leaves the server unable to distinguish a honored page from a client that ignored the field, so it re-paginates from the same place. Set on all three result variants (files, count, content); absent when the frame requested no offset. (cherry picked from commit 13c2ed565f30ff86e31c8dc9896f940faf3aa088)
@oh-my-pi/pi-coding-agent
Core implementation package for the omp coding agent in the oh-my-pi monorepo.
For installation, setup, provider configuration, model roles, slash commands, and full CLI reference, see:
Package-specific references:
Memory backends
The agent supports three mutually-exclusive memory backends, selected via the memory.backend setting (Settings → Memory tab, or ~/.omp/config.yml):
off(default) — no memory subsystem runs.local— existing rollout-summarisation pipeline; writesmemory_summary.mdand consolidated artifacts under the agent dir.hindsight— talks to a Hindsight server (Cloud or self-hosted Docker), retains transcripts every Nth user turn, recalls memories on the first turn of a session, and exposesretain,recall, andreflect.
Hindsight quickstart
- Run a Hindsight server (Cloud or
docker run -p 8888:8888 ghcr.io/vectorize-io/hindsight:latest). - Set
memory.backend = "hindsight"andhindsight.apiUrl = "http://localhost:8888"(or your Cloud URL). - Optional environment overrides (env wins over settings):
HINDSIGHT_API_URL,HINDSIGHT_API_TOKEN— connectionHINDSIGHT_BANK_ID,HINDSIGHT_DYNAMIC_BANK_ID,HINDSIGHT_AGENT_NAME— bank addressingHINDSIGHT_AUTO_RECALL,HINDSIGHT_AUTO_RETAIN,HINDSIGHT_RETAIN_MODE— lifecycleHINDSIGHT_RECALL_BUDGET,HINDSIGHT_RECALL_MAX_TOKENS— recall sizingHINDSIGHT_BANK_MISSION,HINDSIGHT_DEBUG
Switching backends mid-session immediately replaces the live backend, memory tools, listeners, and system-prompt context. Existing users with memories.enabled = true|false are migrated to memory.backend = "local"|"off" exactly once on first launch; afterward, memory.backend is the sole runtime selector.