can1357
ef415e863b
- Replaced SettingsManager class with new Settings singleton providing synchronous get/set API and background persistence.
- Introduced settings-schema.ts as single source of truth for all configuration definitions with 100+ settings organized into logical groups.
- Migrated from method-based settings access (getTheme(), setTheme()) to path-based access using dot notation (settings.get('theme'), settings.set('theme', value)).
- Removed 2035-line settings-manager.ts file and replaced with modular settings.ts (693 lines) and settings-schema.ts (836 lines) for improved maintainability.
- Unified settings schema into single source of truth eliminating duplicate definitions across settings-defs.ts and settings-manager.ts.
79 lines
2.5 KiB
TypeScript
79 lines
2.5 KiB
TypeScript
import { afterEach, beforeEach, describe, expect, it, vi } from "bun:test";
|
|
import * as fs from "node:fs";
|
|
import * as os from "node:os";
|
|
import * as path from "node:path";
|
|
import { type SettingPath, Settings } from "@oh-my-pi/pi-coding-agent/config/settings";
|
|
import * as pythonExecutor from "@oh-my-pi/pi-coding-agent/ipy/executor";
|
|
import * as pythonKernel from "@oh-my-pi/pi-coding-agent/ipy/kernel";
|
|
import { createTools, type ToolSession } from "@oh-my-pi/pi-coding-agent/tools";
|
|
import { PythonTool } from "@oh-my-pi/pi-coding-agent/tools/python";
|
|
|
|
function createSession(cwd: string, overrides?: Partial<Record<SettingPath, unknown>>): ToolSession {
|
|
return {
|
|
cwd,
|
|
hasUI: false,
|
|
getSessionFile: () => "session.json",
|
|
getSessionSpawns: () => null,
|
|
settings: Settings.isolated({ "python.toolMode": "ipy-only", ...overrides }),
|
|
};
|
|
}
|
|
|
|
describe("python tool settings", () => {
|
|
let testDir: string;
|
|
|
|
beforeEach(() => {
|
|
testDir = path.join(os.tmpdir(), `python-tool-settings-${crypto.randomUUID()}`);
|
|
fs.mkdirSync(testDir, { recursive: true });
|
|
});
|
|
|
|
afterEach(() => {
|
|
vi.restoreAllMocks();
|
|
fs.rmSync(testDir, { recursive: true, force: true });
|
|
});
|
|
|
|
it("exposes python tool when kernel is available", async () => {
|
|
vi.spyOn(pythonKernel, "checkPythonKernelAvailability").mockResolvedValue({ ok: true });
|
|
const tools = await createTools(createSession(testDir), ["python"]);
|
|
|
|
expect(tools.map(tool => tool.name).sort()).toEqual(["exit_plan_mode", "python"]);
|
|
});
|
|
|
|
it("falls back to bash when python is unavailable", async () => {
|
|
vi.spyOn(pythonKernel, "checkPythonKernelAvailability").mockResolvedValue({
|
|
ok: false,
|
|
reason: "missing",
|
|
});
|
|
const tools = await createTools(createSession(testDir), ["python"]);
|
|
|
|
expect(tools.map(tool => tool.name).sort()).toEqual(["bash", "exit_plan_mode"]);
|
|
});
|
|
|
|
it("passes kernel mode from settings to executor", async () => {
|
|
const executeSpy = vi.spyOn(pythonExecutor, "executePython").mockResolvedValue({
|
|
output: "ok",
|
|
exitCode: 0,
|
|
cancelled: false,
|
|
truncated: false,
|
|
totalLines: 1,
|
|
totalBytes: 2,
|
|
outputLines: 1,
|
|
outputBytes: 2,
|
|
displayOutputs: [],
|
|
stdinRequested: false,
|
|
});
|
|
|
|
const session = createSession(testDir, { "python.kernelMode": "per-call" });
|
|
const pythonTool = new PythonTool(session);
|
|
|
|
await pythonTool.execute("tool-call", { cells: [{ code: "print(1)" }] });
|
|
|
|
expect(executeSpy).toHaveBeenCalledWith(
|
|
"print(1)",
|
|
expect.objectContaining({
|
|
kernelMode: "per-call",
|
|
sessionId: `session:session.json:cwd:${testDir}`,
|
|
}),
|
|
);
|
|
});
|
|
});
|