Files
oh-my-pi/packages/coding-agent/test/tools/review.test.ts
T
can1357 5ff277349c refactor(coding-agent): consolidated tool surface onto xd:// devices and hub
- Added the `xd://` virtual device protocol (`internal-urls/xd-protocol.ts`, `tools/xdev.ts`): tools declaring `loadMode: "discoverable"` are unmounted from the request tools array and driven via `read xd://` (list/docs+schema) and `write xd://<tool>` (execute), gated by the `tools.xdev` setting (default on) and inlined into the system prompt.
- Merged the `irc`, `job`, and `launch` tools into a single `hub` tool (`tools/hub/`, `async/job-manager.ts`): messaging keeps `send`/`inbox`/`list`, job control maps to `wait`/`cancel`/`jobs`, process supervision keeps `start`/`logs`/`stop`/`restart`/`describe` with `ps`, and the unified `wait` races background jobs against peer messages; SDK `IrcTool`/`JobTool`/`LaunchTool` are replaced by `HubTool`.
- Removed the hidden `resolve` tool in favor of the `xd://resolve`/`xd://reject`/`xd://propose` resolution devices, auto-including `write` whenever a deferrable tool or plan mode is present.
- Removed the BM25 tool-discovery system: the `search_tool_bm25` tool, the `tool-discovery` module, the `tools.discoveryMode`/`mcp.discoveryMode`/`mcp.discoveryDefaultServers`/`tools.essentialOverride` settings, per-tool MCP selection, and the `mcp_tool_selection` message type.
- Unified tool presentation on `ToolLoadMode` (`essential`|`discoverable`), replacing the custom-tool `xdev?: boolean` opt-out; custom, extension, MCP, RPC host, image-generation, and TTS tools now default to `discoverable`, and added a `satisfies` predicate to `SoftToolRequirement`.
- Removed the standalone `ssh` command tool and `ssh/ssh-executor` (the `ssh://` read/write/search protocol stays), and made `--tools` address hidden built-ins.
- Updated collab-web to render `xd://` dispatches and `hub` op families, dropped the `search_tool_bm25`/`ssh`/`report-finding` renderers, refreshed tool docs and prompts, and migrated the affected tests and changelogs.
2026-07-15 15:16:29 +02:00

41 lines
946 B
TypeScript

import { describe, expect, it } from "bun:test";
import { parseFindingDetails } from "@oh-my-pi/pi-coding-agent/tools/review";
describe("parseFindingDetails", () => {
it("returns undefined for malformed finding details", () => {
expect(parseFindingDetails({})).toBeUndefined();
expect(
parseFindingDetails({
title: "[P1] Missing file path",
body: "Body",
priority: "P1",
confidence: 0.8,
line_start: 12,
line_end: 12,
}),
).toBeUndefined();
});
it("parses a complete finding, coercing numeric priority", () => {
expect(
parseFindingDetails({
title: "[P1] Example finding",
body: "Body",
priority: 1,
confidence: 0.9,
file_path: "/tmp/example.ts",
line_start: 10,
line_end: 12,
}),
).toEqual({
title: "[P1] Example finding",
body: "Body",
priority: "P1",
confidence: 0.9,
file_path: "/tmp/example.ts",
line_start: 10,
line_end: 12,
});
});
});