roboomp
389add428b
Render Formula/omp.rb with two changes so the formula actually installs: - Stamp `using: :nounzip` on every per-platform `url` stanza so Homebrew leaves the downloaded bare Mach-O/ELF asset in the staging CWD; the default `CurlDownloadStrategy` was routing through `UnpackStrategy::Uncompressed#extract_nestedly`, nesting the file outside CWD so `Dir["omp-*"].first` returned `nil` and `bin.install nil => "omp"` raised. - Wrap `generate_completions_from_executable` in `with_env(HOME: buildpath)` so the popened binary's `os.homedir()` resolves into the writable staging dir instead of the real `/Users/<user>/.omp`, which Homebrew's sandbox profile denies read access to. Also export `renderFormula` (gated by `import.meta.main`) and add a unit test that pins the rendered stanza shape for future regressions. Fixes #2398
51 lines
2.0 KiB
TypeScript
51 lines
2.0 KiB
TypeScript
import { describe, expect, it } from "bun:test";
|
|
import { renderFormula } from "./ci-update-brew-formula";
|
|
|
|
const SUMS = {
|
|
"omp-darwin-arm64": "darwin_arm64_sha",
|
|
"omp-darwin-x64": "darwin_x64_sha",
|
|
"omp-linux-arm64": "linux_arm64_sha",
|
|
"omp-linux-x64": "linux_x64_sha",
|
|
};
|
|
|
|
describe("renderFormula", () => {
|
|
const formula = renderFormula("15.12.1", SUMS);
|
|
|
|
// Regression: bare-binary URLs must opt out of Homebrew's UnpackStrategy.
|
|
// Without `using: :nounzip` the default CurlDownloadStrategy nests the file
|
|
// outside the staging CWD, `Dir["omp-*"].first` returns `nil`, and
|
|
// `bin.install nil => "omp"` raises (issue #2398).
|
|
it("attaches `using: :nounzip` to every per-platform url stanza", () => {
|
|
const matches = formula.match(/using: :nounzip/g) ?? [];
|
|
expect(matches).toHaveLength(4);
|
|
for (const arch of ["omp-darwin-arm64", "omp-darwin-x64", "omp-linux-arm64", "omp-linux-x64"]) {
|
|
expect(formula).toMatch(
|
|
new RegExp(
|
|
`url "https://github\\.com/[^"]+/${arch}",\\s+using: :nounzip\\s+sha256 "${SUMS[arch as keyof typeof SUMS]}"`,
|
|
),
|
|
);
|
|
}
|
|
});
|
|
|
|
// Regression: completions generation must run with HOME redirected so the
|
|
// popened binary doesn't touch the real `~/.omp` (denied by Homebrew's
|
|
// sandbox profile) during the build (issue #2398).
|
|
it("wraps `generate_completions_from_executable` with a HOME redirect to buildpath", () => {
|
|
expect(formula).toMatch(
|
|
/with_env\(HOME: buildpath\) do\n\s+generate_completions_from_executable\(bin\/"omp", "completions", shells: \[:bash, :zsh, :fish\]\)\n\s+end/,
|
|
);
|
|
// And the bare form (which is what failed in the sandbox) must not appear
|
|
// outside the `with_env` block.
|
|
const blockless = formula.replace(/with_env\(HOME: buildpath\) do[\s\S]*?end/, "");
|
|
expect(blockless).not.toMatch(/generate_completions_from_executable/);
|
|
});
|
|
|
|
it("emits the expected per-asset sha256 next to each url", () => {
|
|
for (const name in SUMS) {
|
|
const sha = SUMS[name as keyof typeof SUMS];
|
|
expect(formula).toContain(`/${name}",`);
|
|
expect(formula).toContain(`sha256 "${sha}"`);
|
|
}
|
|
});
|
|
});
|