roboomp
de1368fd2d
PR #3474 review: the new export pass writes referenced env-var values into a snapshot file under `os.tmpdir()/omp-shell-snapshots`. On Linux where `os.tmpdir()` is `/tmp` and the umask is the default 022, the file ended up world-readable (0644) until postmortem cleanup. A user rcfile defining `deploy(){ curl -H "Authorization: $GITHUB_TOKEN" ...; }` would have its token written verbatim to that file. Three-layer mitigation: - `umask 077` at the top of the snapshot script so the file is 0600 from the first byte (the shell creates it via redirection, not JS). - JS caller now passes `mode: 0o700` to `mkdirSync` and chmods the dir + file defensively after the script exits, covering pre-existing dirs and exotic shells where the umask call might not take. - Helper denylist gained the common secret-shaped name patterns (`*TOKEN*`, `*SECRET*`, `*API_KEY*`, `*PASSWORD*`, `*PASSWD*`, `*PRIVATE_KEY*`, `*ACCESS_KEY*`, `*CREDENTIAL*`, `*SESSION_KEY*`) so even when the file is locked down, we don't materialise tokens onto disk in the first place. Tests cover both: a new helper-level test asserts none of the secret names (or their values) appear in the export stream, and the e2e test now stats the snapshot file + dir and asserts `mode & 0o077 === 0`.
@oh-my-pi/pi-coding-agent
Core implementation package for the omp coding agent in the oh-my-pi monorepo.
For installation, setup, provider configuration, model roles, slash commands, and full CLI reference, see:
Package-specific references:
Memory backends
The agent supports three mutually-exclusive memory backends, selected via the memory.backend setting (Settings → Memory tab, or ~/.omp/config.yml):
off(default) — no memory subsystem runs.local— existing rollout-summarisation pipeline; writesmemory_summary.mdand consolidated artifacts under the agent dir.hindsight— talks to a Hindsight server (Cloud or self-hosted Docker), retains transcripts every Nth user turn, recalls memories on the first turn of a session, and exposesretain,recall, andreflect.
Hindsight quickstart
- Run a Hindsight server (Cloud or
docker run -p 8888:8888 ghcr.io/vectorize-io/hindsight:latest). - Set
memory.backend = "hindsight"andhindsight.apiUrl = "http://localhost:8888"(or your Cloud URL). - Optional environment overrides (env wins over settings):
HINDSIGHT_API_URL,HINDSIGHT_API_TOKEN— connectionHINDSIGHT_BANK_ID,HINDSIGHT_DYNAMIC_BANK_ID,HINDSIGHT_AGENT_NAME— bank addressingHINDSIGHT_AUTO_RECALL,HINDSIGHT_AUTO_RETAIN,HINDSIGHT_RETAIN_MODE— lifecycleHINDSIGHT_RECALL_BUDGET,HINDSIGHT_RECALL_MAX_TOKENS— recall sizingHINDSIGHT_BANK_MISSION,HINDSIGHT_DEBUG
Switching backends mid-session is honoured on the next system-prompt rebuild and the next /memory slash command. Existing users with memories.enabled = true|false are migrated to memory.backend = "local"|"off" exactly once on first launch.