roboomp
7638f03121
createReportBundle's addSubagentSessions scanned path.dirname(sessionFile) - the sessions root holding every session in history - and bundled the 10 newest .jsonl files, leaking unrelated sessions' transcripts and bloating archives to tens of MB. Real subagent sessions live inside the current session's own artifacts dir, so recurse that subtree and drop the sessions-root scan entirely. Fixes #8648
77 lines
3.1 KiB
TypeScript
77 lines
3.1 KiB
TypeScript
import { afterEach, describe, expect, it } from "bun:test";
|
|
import * as fs from "node:fs/promises";
|
|
import * as os from "node:os";
|
|
import * as path from "node:path";
|
|
import { createReportBundle } from "@oh-my-pi/pi-coding-agent/debug/report-bundle";
|
|
import { getConfigRootDir, removeWithRetries, setAgentDir } from "@oh-my-pi/pi-utils";
|
|
|
|
const originalAgentDir = process.env.PI_CODING_AGENT_DIR;
|
|
const originalXdgStateHome = process.env.XDG_STATE_HOME;
|
|
const fallbackAgentDir = path.join(getConfigRootDir(), "agent");
|
|
let cleanupRoot: string | undefined;
|
|
|
|
afterEach(async () => {
|
|
if (originalXdgStateHome === undefined) {
|
|
delete process.env.XDG_STATE_HOME;
|
|
} else {
|
|
process.env.XDG_STATE_HOME = originalXdgStateHome;
|
|
}
|
|
if (originalAgentDir) {
|
|
setAgentDir(originalAgentDir);
|
|
} else {
|
|
setAgentDir(fallbackAgentDir);
|
|
delete process.env.PI_CODING_AGENT_DIR;
|
|
}
|
|
if (cleanupRoot) {
|
|
await removeWithRetries(cleanupRoot);
|
|
cleanupRoot = undefined;
|
|
}
|
|
});
|
|
|
|
async function archiveMembers(archivePath: string): Promise<string[]> {
|
|
const archive = new Bun.Archive(await Bun.file(archivePath).bytes());
|
|
return [...(await archive.files()).keys()].sort();
|
|
}
|
|
|
|
describe("report bundle sessions", () => {
|
|
it("bundles only the current session's subtree, not unrelated co-located sessions", async () => {
|
|
cleanupRoot = await fs.mkdtemp(path.join(os.tmpdir(), "omp-report-sessions-"));
|
|
const xdgStateHome = path.join(cleanupRoot, "state");
|
|
await fs.mkdir(path.join(xdgStateHome, "omp"), { recursive: true });
|
|
process.env.XDG_STATE_HOME = xdgStateHome;
|
|
setAgentDir(fallbackAgentDir);
|
|
|
|
const sessionsDir = path.join(cleanupRoot, "sessions");
|
|
await fs.mkdir(sessionsDir, { recursive: true });
|
|
|
|
// Current session and its artifacts subtree: a genuine subagent transcript
|
|
// plus a nested sub-subagent transcript one level deeper.
|
|
const sessionFile = path.join(sessionsDir, "2026-08-15T00-00-00_CURRENT.jsonl");
|
|
await Bun.write(sessionFile, '{"type":"session","id":"CURRENT"}\n');
|
|
const artifactsDir = sessionFile.slice(0, -6);
|
|
await fs.mkdir(path.join(artifactsDir, "SubTask"), { recursive: true });
|
|
await Bun.write(path.join(artifactsDir, "SubTask.jsonl"), '{"type":"session","id":"SubTask"}\n');
|
|
await Bun.write(path.join(artifactsDir, "SubTask", "NestedTask.jsonl"), '{"type":"session","id":"NestedTask"}\n');
|
|
|
|
// Unrelated top-level sessions co-located in the sessions root.
|
|
await Bun.write(
|
|
path.join(sessionsDir, "2026-08-10T00-00-00_OTHERA.jsonl"),
|
|
'{"type":"session","secret":"private-a"}\n',
|
|
);
|
|
await Bun.write(
|
|
path.join(sessionsDir, "2026-08-12T00-00-00_OTHERB.jsonl"),
|
|
'{"type":"session","secret":"private-b"}\n',
|
|
);
|
|
|
|
const result = await createReportBundle({ sessionFile });
|
|
const members = await archiveMembers(result.path);
|
|
await fs.rm(result.path, { force: true });
|
|
|
|
// Genuine subtree is captured recursively.
|
|
expect(members).toContain("artifacts/SubTask.jsonl");
|
|
expect(members).toContain("artifacts/SubTask/NestedTask.jsonl");
|
|
// Unrelated sessions never appear anywhere in the archive.
|
|
expect(members.some(name => name.includes("OTHERA") || name.includes("OTHERB"))).toBe(false);
|
|
});
|
|
});
|