can1357
83e914d075
- Added validation to submit_result tool to ensure status field is present and correctly typed as 'success' or 'aborted'. - Fixed executor to only mark submitResultCalled when submit_result tool succeeds or aborts, preventing false positives on validation failures. - Added type guards and error state checks to prevent setting completion flags on malformed tool execution results. - Added comprehensive test coverage for submit_result extraction with valid and malformed payload validation.
35 lines
1.1 KiB
TypeScript
35 lines
1.1 KiB
TypeScript
import { describe, expect, it } from "bun:test";
|
|
import "../../src/tools/submit-result";
|
|
import { subprocessToolRegistry } from "../../src/task/subprocess-tool-registry";
|
|
|
|
describe("submit_result subprocess extraction", () => {
|
|
const handler = subprocessToolRegistry.getHandler("submit_result");
|
|
|
|
it("extracts valid submit_result payloads", () => {
|
|
expect(handler?.extractData).toBeDefined();
|
|
const data = handler?.extractData?.({
|
|
toolName: "submit_result",
|
|
toolCallId: "call-1",
|
|
result: {
|
|
content: [{ type: "text", text: "Result submitted." }],
|
|
details: { status: "success", data: { ok: true } },
|
|
},
|
|
isError: false,
|
|
});
|
|
expect(data).toEqual({ status: "success", data: { ok: true }, error: undefined });
|
|
});
|
|
|
|
it("ignores malformed submit_result details without status", () => {
|
|
const data = handler?.extractData?.({
|
|
toolName: "submit_result",
|
|
toolCallId: "call-2",
|
|
result: {
|
|
content: [{ type: "text", text: "Tool execution was aborted." }],
|
|
details: {},
|
|
},
|
|
isError: true,
|
|
});
|
|
expect(data).toBeUndefined();
|
|
});
|
|
});
|