can1357
76a02c385a
- Added `hindsight.scoping` and `HINDSIGHT_SCOPING` with global, per-project, and per-project-tagged modes. - Migrated legacy `raw.hindsight` handling to scoping-based behavior and removed deprecated `dynamicBankId`/`agentName` keys. - Replaced `deriveBankId` with `computeBankScope`, returning `bankId` plus optional retain/recall tags by mode. - Forwarded scoped tags through memory ops so recall and retain/reflect calls use `tags`, `tagsMatch`, and `recallTags`. - Validated `scoping` values from env/settings, warning and defaulting to `per-project-tagged` when invalid.
90 lines
3.2 KiB
TypeScript
90 lines
3.2 KiB
TypeScript
import { afterEach, beforeEach, describe, expect, it, vi } from "bun:test";
|
|
import { _resetSettingsForTest, Settings } from "@oh-my-pi/pi-coding-agent/config/settings";
|
|
import { isHindsightConfigured, loadHindsightConfig } from "@oh-my-pi/pi-coding-agent/hindsight/config";
|
|
|
|
describe("loadHindsightConfig", () => {
|
|
beforeEach(() => {
|
|
_resetSettingsForTest();
|
|
});
|
|
|
|
afterEach(() => {
|
|
vi.restoreAllMocks();
|
|
});
|
|
|
|
it("returns sane defaults from an empty Settings", () => {
|
|
const settings = Settings.isolated();
|
|
const cfg = loadHindsightConfig(settings, {});
|
|
expect(cfg.hindsightApiUrl).toBe("http://localhost:8888"); // schema default
|
|
expect(cfg.recallBudget).toBe("mid");
|
|
expect(cfg.retainMode).toBe("full-session");
|
|
expect(cfg.recallTypes).toEqual(["world", "experience"]);
|
|
expect(cfg.autoRecall).toBe(true);
|
|
expect(cfg.autoRetain).toBe(true);
|
|
expect(cfg.scoping).toBe("per-project-tagged");
|
|
});
|
|
|
|
it("env overrides win over settings", () => {
|
|
const settings = Settings.isolated({
|
|
"hindsight.apiUrl": "http://settings.example",
|
|
"hindsight.autoRecall": true,
|
|
"hindsight.recallMaxTokens": 256,
|
|
"hindsight.scoping": "global",
|
|
"hindsight.retainMode": "full-session",
|
|
});
|
|
const cfg = loadHindsightConfig(settings, {
|
|
HINDSIGHT_API_URL: "http://env.example",
|
|
HINDSIGHT_AUTO_RECALL: "false",
|
|
HINDSIGHT_RECALL_MAX_TOKENS: "9999",
|
|
HINDSIGHT_SCOPING: "per-project",
|
|
HINDSIGHT_RETAIN_MODE: "last-turn",
|
|
});
|
|
expect(cfg.hindsightApiUrl).toBe("http://env.example");
|
|
expect(cfg.autoRecall).toBe(false);
|
|
expect(cfg.recallMaxTokens).toBe(9999);
|
|
expect(cfg.scoping).toBe("per-project");
|
|
expect(cfg.retainMode).toBe("last-turn");
|
|
});
|
|
|
|
it("ignores invalid scoping values and falls back to the schema default", () => {
|
|
const settings = Settings.isolated();
|
|
const cfg = loadHindsightConfig(settings, { HINDSIGHT_SCOPING: "garbage" });
|
|
expect(cfg.scoping).toBe("per-project-tagged");
|
|
});
|
|
|
|
it("ignores invalid retainMode env values and falls back to schema default", () => {
|
|
const settings = Settings.isolated();
|
|
const cfg = loadHindsightConfig(settings, { HINDSIGHT_RETAIN_MODE: "garbage" });
|
|
expect(cfg.retainMode).toBe("full-session");
|
|
});
|
|
|
|
it("coerces non-numeric ints back to undefined so settings/default takes over", () => {
|
|
const settings = Settings.isolated({ "hindsight.recallMaxTokens": 512 });
|
|
const cfg = loadHindsightConfig(settings, { HINDSIGHT_RECALL_MAX_TOKENS: "not-a-number" });
|
|
expect(cfg.recallMaxTokens).toBe(512);
|
|
});
|
|
|
|
it("respects falsy boolean env strings", () => {
|
|
const settings = Settings.isolated();
|
|
const cfg = loadHindsightConfig(settings, {
|
|
HINDSIGHT_AUTO_RECALL: "no",
|
|
HINDSIGHT_AUTO_RETAIN: "0",
|
|
});
|
|
expect(cfg.autoRecall).toBe(false);
|
|
expect(cfg.autoRetain).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe("isHindsightConfigured", () => {
|
|
it("returns true when an apiUrl is set", () => {
|
|
const cfg = loadHindsightConfig(Settings.isolated({ "hindsight.apiUrl": "http://x" }), {});
|
|
expect(isHindsightConfigured(cfg)).toBe(true);
|
|
});
|
|
|
|
it("returns false when apiUrl is missing", () => {
|
|
const cfg = loadHindsightConfig(Settings.isolated({ "hindsight.apiUrl": "" }), {
|
|
HINDSIGHT_API_URL: "",
|
|
});
|
|
expect(isHindsightConfigured(cfg)).toBe(false);
|
|
});
|
|
});
|