Carl
379064a0c9
scoped retained-kernel ownership to agent sessions and cleaned it up on session disposal cleaned up warmed python owners on session startup failure and rejected new direct and tool-based python starts during disposal, including async hook, preflight, and warmup races
85 lines
2.6 KiB
TypeScript
85 lines
2.6 KiB
TypeScript
import { afterEach, describe, expect, it, vi } from "bun:test";
|
|
import { Settings } from "@oh-my-pi/pi-coding-agent/config/settings";
|
|
import * as pythonExecutor from "@oh-my-pi/pi-coding-agent/ipy/executor";
|
|
import type { ToolSession } from "@oh-my-pi/pi-coding-agent/tools";
|
|
import { PythonTool } from "@oh-my-pi/pi-coding-agent/tools/python";
|
|
import { TempDir } from "@oh-my-pi/pi-utils";
|
|
|
|
function createSession(cwd: string, kernelOwnerId?: string): ToolSession {
|
|
return {
|
|
cwd,
|
|
hasUI: false,
|
|
getSessionFile: () => `${cwd}/session-file.jsonl`,
|
|
getSessionSpawns: () => "*",
|
|
getPythonKernelOwnerId: () => kernelOwnerId ?? null,
|
|
settings: Settings.isolated({
|
|
"lsp.formatOnWrite": true,
|
|
"bashInterceptor.enabled": true,
|
|
"python.toolMode": "ipy-only",
|
|
"python.kernelMode": "per-call",
|
|
}),
|
|
};
|
|
}
|
|
|
|
describe("python tool execution", () => {
|
|
afterEach(() => {
|
|
pythonExecutor.resetPreludeDocsCache();
|
|
vi.restoreAllMocks();
|
|
});
|
|
|
|
it("passes kernel owner and kernel options from settings and args", async () => {
|
|
const tempDir = TempDir.createSync("@python-tool-");
|
|
vi.spyOn(pythonExecutor, "getPreludeDocs").mockReturnValue([]);
|
|
const warmupSpy = vi.spyOn(pythonExecutor, "warmPythonEnvironment").mockResolvedValue({ ok: true, docs: [] });
|
|
const executeSpy = vi.spyOn(pythonExecutor, "executePython").mockResolvedValue({
|
|
output: "ok",
|
|
exitCode: 0,
|
|
cancelled: false,
|
|
truncated: false,
|
|
totalLines: 1,
|
|
totalBytes: 2,
|
|
outputLines: 1,
|
|
outputBytes: 2,
|
|
displayOutputs: [],
|
|
stdinRequested: false,
|
|
});
|
|
|
|
const kernelOwnerId = "owner-123";
|
|
const tool = new PythonTool(createSession(tempDir.path(), kernelOwnerId));
|
|
const result = await tool.execute(
|
|
"call-id",
|
|
{ cells: [{ code: "print('hi')" }], timeout: 5, cwd: tempDir.path(), reset: true },
|
|
undefined,
|
|
undefined,
|
|
undefined,
|
|
);
|
|
|
|
expect(warmupSpy).toHaveBeenCalledWith(
|
|
tempDir.path(),
|
|
`session:${tempDir.path()}/session-file.jsonl:cwd:${tempDir.path()}`,
|
|
true,
|
|
`${tempDir.path()}/session-file.jsonl`,
|
|
kernelOwnerId,
|
|
expect.any(AbortSignal),
|
|
);
|
|
expect(executeSpy).toHaveBeenCalledWith(
|
|
"print('hi')",
|
|
expect.objectContaining({
|
|
cwd: tempDir.path(),
|
|
deadlineMs: expect.any(Number),
|
|
signal: expect.any(AbortSignal),
|
|
sessionFile: `${tempDir.path()}/session-file.jsonl`,
|
|
sessionId: `session:${tempDir.path()}/session-file.jsonl:cwd:${tempDir.path()}`,
|
|
kernelOwnerId,
|
|
kernelMode: "per-call",
|
|
useSharedGateway: true,
|
|
reset: true,
|
|
}),
|
|
);
|
|
const text = result.content.find(item => item.type === "text")?.text;
|
|
expect(text).toBe("ok");
|
|
|
|
tempDir.removeSync();
|
|
});
|
|
});
|