can1357
b48b825344
Two review fixes for the extension-flag/initial-prompt work: 1. @file ordering — `processFileArguments` runs `process.exit(1)` on a missing/unreadable file. It had been moved after `createSession`, which writes the terminal breadcrumb eagerly (SessionManager.create → #newSessionSync), so `omp @missing.md "x"` left a junk session/breadcrumb behind before exiting. Resolve extension-registered CLI flags BEFORE creating the session: load the session's extensions up front (new `loadSessionExtensions` helper, the single source of createAgentSession's discovery-branch logic), build an ExtensionFlagSink straight from the loaded extensions + runtime, re-parse argv, then process @file args — all before any session exists. The loaded result is handed back to createAgentSession via `preloadedExtensions` (now checked before `disableExtensionDiscovery`, so it can't double-load) and the same EventBus is shared, so no extra work. This keeps the P1#1 fix (`--flag @value` is the flag's value, not a file) while failing fast with no session side effects. 2. "Can we avoid the big list of names?" — removed the hand-maintained `BUILTIN_FLAG_NAMES` set (and its stale "rejected at registration" doc). `applyExtensionFlags` now always falls back to recovering a flag's value from argv when parseArgs didn't surface it; the recovery scan mirrors parseArgs's consumption rules (flag-looking space-form values stay their own flag) and is a no-op for flags that were absent or already surfaced, so no list of built-in names is needed. Adds `ExtensionRunner.aggregateFlags` (static) so getFlags and the CLI's pre-session sink share one implementation. Tests: pre-session flag resolution via the exact main.ts sink pattern; list-free recovery of an arbitrary colliding built-in (`--model`); and the flag-looking-value rule. Verified typecheck + extension/runner/acp suites.
@oh-my-pi/pi-coding-agent
Core implementation package for the omp coding agent in the oh-my-pi monorepo.
For installation, setup, provider configuration, model roles, slash commands, and full CLI reference, see:
Package-specific references:
- CHANGELOG
- MCP configuration guide
- MCP runtime lifecycle
- MCP server/tool authoring
- DEVELOPMENT
- RenderMermaid guide
Memory backends
The agent supports three mutually-exclusive memory backends, selected via the memory.backend setting (Settings → Memory tab, or ~/.omp/config.yml):
off(default) — no memory subsystem runs.local— existing rollout-summarisation pipeline; writesmemory_summary.mdand consolidated artifacts under the agent dir.hindsight— talks to a Hindsight server (Cloud or self-hosted Docker), retains transcripts every Nth user turn, recalls memories on the first turn of a session, and exposesretain,recall, andreflect.
Hindsight quickstart
- Run a Hindsight server (Cloud or
docker run -p 8888:8888 ghcr.io/vectorize-io/hindsight:latest). - Set
memory.backend = "hindsight"andhindsight.apiUrl = "http://localhost:8888"(or your Cloud URL). - Optional environment overrides (env wins over settings):
HINDSIGHT_API_URL,HINDSIGHT_API_TOKEN— connectionHINDSIGHT_BANK_ID,HINDSIGHT_DYNAMIC_BANK_ID,HINDSIGHT_AGENT_NAME— bank addressingHINDSIGHT_AUTO_RECALL,HINDSIGHT_AUTO_RETAIN,HINDSIGHT_RETAIN_MODE— lifecycleHINDSIGHT_RECALL_BUDGET,HINDSIGHT_RECALL_MAX_TOKENS— recall sizingHINDSIGHT_BANK_MISSION,HINDSIGHT_DEBUG
Switching backends mid-session is honoured on the next system-prompt rebuild and the next /memory slash command. Existing users with memories.enabled = true|false are migrated to memory.backend = "local"|"off" exactly once on first launch.