roboomp
b38eba2be7
Codex reviewer flagged that the ranged-read fallback recommended by the patcher's over-cap reveal path (`path:N-M`) itself applies the 512-column cap and still records the displayed line numbers via `recordSeenLinesFromBody`. On a minified wide anchor line, `read file:N` shows only the clipped prefix but the line lands in the tag's seenLines — a subsequent edit anchored at N then slips past the seen-line guard. - `packages/coding-agent/src/edit/file-snapshot-store.ts`: `recordSeenLinesFromBody` grows an optional `excludedLines` set; parsed line numbers matching it are filtered before recording. - `packages/coding-agent/src/tools/read.ts`: `#readLocalFileMultiRange` and the single-range disk path build a `clippedLines` set alongside `columnTruncated` for both direct-range lines and `buildLineEntriesWithBlockContext` context lines, then pass it into `recordSeenLinesFromBody`. - `packages/coding-agent/src/tools/grep.ts`: same wiring for the match line via `match.truncated`, plus a conservative length+`...`-marker heuristic for context lines (native `crates/pi-natives/src/grep.rs` `truncate_line` doesn't propagate a per-line flag on `contextBefore`/`contextAfter`; a proper native-side flag is a follow-up). - `packages/coding-agent/test/edit/seen-line-guard.test.ts`: new case reads a 4KB single line and asserts the clipped line number stays out of `seenLines` and the edit against it still rejects with the seen-line guard.
@oh-my-pi/pi-coding-agent
Core implementation package for the omp coding agent in the oh-my-pi monorepo.
For installation, setup, provider configuration, model roles, slash commands, and full CLI reference, see:
Package-specific references:
Memory backends
The agent supports three mutually-exclusive memory backends, selected via the memory.backend setting (Settings → Memory tab, or ~/.omp/config.yml):
off(default) — no memory subsystem runs.local— existing rollout-summarisation pipeline; writesmemory_summary.mdand consolidated artifacts under the agent dir.hindsight— talks to a Hindsight server (Cloud or self-hosted Docker), retains transcripts every Nth user turn, recalls memories on the first turn of a session, and exposesretain,recall, andreflect.
Hindsight quickstart
- Run a Hindsight server (Cloud or
docker run -p 8888:8888 ghcr.io/vectorize-io/hindsight:latest). - Set
memory.backend = "hindsight"andhindsight.apiUrl = "http://localhost:8888"(or your Cloud URL). - Optional environment overrides (env wins over settings):
HINDSIGHT_API_URL,HINDSIGHT_API_TOKEN— connectionHINDSIGHT_BANK_ID,HINDSIGHT_DYNAMIC_BANK_ID,HINDSIGHT_AGENT_NAME— bank addressingHINDSIGHT_AUTO_RECALL,HINDSIGHT_AUTO_RETAIN,HINDSIGHT_RETAIN_MODE— lifecycleHINDSIGHT_RECALL_BUDGET,HINDSIGHT_RECALL_MAX_TOKENS— recall sizingHINDSIGHT_BANK_MISSION,HINDSIGHT_DEBUG
Switching backends mid-session is honoured on the next system-prompt rebuild and the next /memory slash command. Existing users with memories.enabled = true|false are migrated to memory.backend = "local"|"off" exactly once on first launch.