Leo Kimandcan1357
b373c54cd7
Bug: Ctrl+C on the ask tool selector threw ToolAbortError, the turn ended with stopReason === "aborted", and handleBackgroundEvent fired sendCompletionNotification() unconditionally — producing a misleading "Task complete" desktop toast for a turn that never actually completed. Fix mirrors the stopReason filter already used by #currentContextTokens, #handleMessageEnd, and the retry / TTSR / compaction skip paths across agent-session.ts: check the most recent assistant message via session.getLastAssistantMessage() and return early when stopReason is "aborted" or "error". Test coverage (event-controller-abort-guard.test.ts, 6 cases): - aborted -> 0 sendNotification calls - error -> 0 calls - stop -> 1 call (normal completion) - no last assistant message -> proceeds (defensive) - isBackgrounded=false (foreground) -> still 0 - completion.notify=off -> still 0 Matching guard applied to the standalone desktop-notify extension (~/.omp/agent/extensions/desktop-notify/index.ts) which is currently the live producer of completion toasts after Phase 1 of seed_0ca7e1143ac1.
@oh-my-pi/pi-coding-agent
Core implementation package for the omp coding agent in the oh-my-pi monorepo.
For installation, setup, provider configuration, model roles, slash commands, and full CLI reference, see:
Package-specific references:
- CHANGELOG
- MCP configuration guide
- MCP runtime lifecycle
- MCP server/tool authoring
- DEVELOPMENT
- RenderMermaid guide
Memory backends
The agent supports three mutually-exclusive memory backends, selected via the memory.backend setting (Settings → Memory tab, or ~/.omp/config.yml):
off(default) — no memory subsystem runs.local— existing rollout-summarisation pipeline; writesmemory_summary.mdand consolidated artifacts under the agent dir.hindsight— talks to a Hindsight server (Cloud or self-hosted Docker), retains transcripts every Nth user turn, recalls memories on the first turn of a session, and exposesretain,recall, andreflect.
Hindsight quickstart
- Run a Hindsight server (Cloud or
docker run -p 8888:8888 ghcr.io/vectorize-io/hindsight:latest). - Set
memory.backend = "hindsight"andhindsight.apiUrl = "http://localhost:8888"(or your Cloud URL). - Optional environment overrides (env wins over settings):
HINDSIGHT_API_URL,HINDSIGHT_API_TOKEN— connectionHINDSIGHT_BANK_ID,HINDSIGHT_DYNAMIC_BANK_ID,HINDSIGHT_AGENT_NAME— bank addressingHINDSIGHT_AUTO_RECALL,HINDSIGHT_AUTO_RETAIN,HINDSIGHT_RETAIN_MODE— lifecycleHINDSIGHT_RECALL_BUDGET,HINDSIGHT_RECALL_MAX_TOKENS— recall sizingHINDSIGHT_BANK_MISSION,HINDSIGHT_DEBUG
Switching backends mid-session is honoured on the next system-prompt rebuild and the next /memory slash command. Existing users with memories.enabled = true|false are migrated to memory.backend = "local"|"off" exactly once on first launch.