roboomp
62cb7a0e62
Selected PUPPETEER_EXECUTABLE_PATH before probing system browser installations so compatible headless-shell binaries remain usable by the shared daemon. Added an isolated Windows candidate-selection regression probe. Fixes #7601
71 lines
2.5 KiB
TypeScript
71 lines
2.5 KiB
TypeScript
import { describe, expect, it } from "bun:test";
|
|
import * as path from "node:path";
|
|
import { stealthIgnoreDefaultArgsForTest } from "@oh-my-pi/pi-coding-agent/tools/browser/launch";
|
|
import { TempDir } from "@oh-my-pi/pi-utils";
|
|
|
|
const EXECUTABLE_PROBE = path.resolve(import.meta.dir, "../fixtures/browser-executable-probe.ts");
|
|
|
|
const AUTOMATION_FLAG = "--enable-automation";
|
|
|
|
const EDGE_EXECUTABLE_PATHS = [
|
|
"C:\\Program Files\\Microsoft\\Edge\\Application\\msedge.exe",
|
|
"/Applications/Microsoft Edge.app/Contents/MacOS/Microsoft Edge",
|
|
"/usr/bin/microsoft-edge-stable",
|
|
] as const;
|
|
|
|
const CHROME_EXECUTABLE_PATHS = [
|
|
"C:\\Program Files\\Google\\Chrome\\Application\\chrome.exe",
|
|
"/Applications/Google Chrome.app/Contents/MacOS/Google Chrome",
|
|
"/usr/bin/chromium",
|
|
] as const;
|
|
|
|
describe("browser launch stealth defaults", () => {
|
|
it("keeps Puppeteer's automation default for Microsoft Edge executables", () => {
|
|
for (const executablePath of EDGE_EXECUTABLE_PATHS) {
|
|
const ignoreDefaultArgs = stealthIgnoreDefaultArgsForTest(executablePath);
|
|
|
|
expect(ignoreDefaultArgs).not.toContain(AUTOMATION_FLAG);
|
|
expect(ignoreDefaultArgs).toContain("--disable-extensions");
|
|
}
|
|
});
|
|
|
|
it("continues filtering Puppeteer's automation default for Chrome and Chromium executables", () => {
|
|
for (const executablePath of CHROME_EXECUTABLE_PATHS) {
|
|
const ignoreDefaultArgs = stealthIgnoreDefaultArgsForTest(executablePath);
|
|
|
|
expect(ignoreDefaultArgs).toContain(AUTOMATION_FLAG);
|
|
}
|
|
});
|
|
});
|
|
|
|
describe("browser executable selection", () => {
|
|
it("honors PUPPETEER_EXECUTABLE_PATH before a detected Windows system Chrome", async () => {
|
|
const tempDir = TempDir.createSync("@browser-executable-");
|
|
try {
|
|
const override = path.join(tempDir.path(), "chrome-headless-shell.exe");
|
|
const systemChrome = path.join(tempDir.path(), "Google\\Chrome\\Application\\chrome.exe");
|
|
await Bun.write(override, "override");
|
|
await Bun.write(systemChrome, "system");
|
|
|
|
const result = Bun.spawnSync([process.execPath, EXECUTABLE_PROBE], {
|
|
env: {
|
|
...process.env,
|
|
OMP_BROWSER_PROBE_PLATFORM: "win32",
|
|
ProgramFiles: tempDir.path(),
|
|
"ProgramFiles(x86)": path.join(tempDir.path(), "missing-x86"),
|
|
LOCALAPPDATA: path.join(tempDir.path(), "missing-local"),
|
|
PUPPETEER_EXECUTABLE_PATH: override,
|
|
},
|
|
stdout: "pipe",
|
|
stderr: "pipe",
|
|
});
|
|
const stderr = new TextDecoder().decode(result.stderr);
|
|
|
|
expect(result.exitCode, stderr).toBe(0);
|
|
expect(new TextDecoder().decode(result.stdout)).toBe(override);
|
|
} finally {
|
|
await tempDir.remove();
|
|
}
|
|
});
|
|
});
|