metaphorics
a95be2860f
Addresses Copilot + Codex review on #2521: - computeEditorMaxHeight returned 1 on terminals too small to host both the editor and the chrome reserve, but the bordered editor never renders fewer than 3 rows (2 border + 1 content). The cap now floors at that real minimum (EDITOR_MIN_RENDERED_ROWS) so it no longer misreports the rows the editor occupies; rendering is unchanged, and the contract is documented honestly (reserve holds once terminalRows >= 7). - #resolveOverlayLayout now always resolves maxHeight (?? availHeight), so the maxHeight !== undefined branch in effectiveHeight, the composite slice guard, and the number | undefined return type were dead. Tightened all three. - Mirrored the maxHeight-default contract in the render stress oracle (resolveExpectedOverlayLayout + compositeExpectedOverlays) so the randomized sweep validates the real clipped geometry instead of the obsolete unclipped one; updated the oracle helper test expectation accordingly. Editor-height tests rewritten to assert the real contract (reserve when the terminal can host both; pinned to the bordered minimum below that).
@oh-my-pi/pi-coding-agent
Core implementation package for the omp coding agent in the oh-my-pi monorepo.
For installation, setup, provider configuration, model roles, slash commands, and full CLI reference, see:
Package-specific references:
- CHANGELOG
- MCP configuration guide
- MCP runtime lifecycle
- MCP server/tool authoring
- DEVELOPMENT
- RenderMermaid guide
Memory backends
The agent supports three mutually-exclusive memory backends, selected via the memory.backend setting (Settings → Memory tab, or ~/.omp/config.yml):
off(default) — no memory subsystem runs.local— existing rollout-summarisation pipeline; writesmemory_summary.mdand consolidated artifacts under the agent dir.hindsight— talks to a Hindsight server (Cloud or self-hosted Docker), retains transcripts every Nth user turn, recalls memories on the first turn of a session, and exposesretain,recall, andreflect.
Hindsight quickstart
- Run a Hindsight server (Cloud or
docker run -p 8888:8888 ghcr.io/vectorize-io/hindsight:latest). - Set
memory.backend = "hindsight"andhindsight.apiUrl = "http://localhost:8888"(or your Cloud URL). - Optional environment overrides (env wins over settings):
HINDSIGHT_API_URL,HINDSIGHT_API_TOKEN— connectionHINDSIGHT_BANK_ID,HINDSIGHT_DYNAMIC_BANK_ID,HINDSIGHT_AGENT_NAME— bank addressingHINDSIGHT_AUTO_RECALL,HINDSIGHT_AUTO_RETAIN,HINDSIGHT_RETAIN_MODE— lifecycleHINDSIGHT_RECALL_BUDGET,HINDSIGHT_RECALL_MAX_TOKENS— recall sizingHINDSIGHT_BANK_MISSION,HINDSIGHT_DEBUG
Switching backends mid-session is honoured on the next system-prompt rebuild and the next /memory slash command. Existing users with memories.enabled = true|false are migrated to memory.backend = "local"|"off" exactly once on first launch.