can1357
124 lines
4.1 KiB
TypeScript
124 lines
4.1 KiB
TypeScript
import { describe, expect, it } from "bun:test";
|
|
import { Settings } from "../../src/config/settings";
|
|
import type { ToolSession } from "../../src/tools/index";
|
|
import {
|
|
AskTool,
|
|
BUILTIN_TOOLS,
|
|
computeEssentialBuiltinNames,
|
|
createTools,
|
|
DEFAULT_ESSENTIAL_TOOL_NAMES,
|
|
IrcTool,
|
|
JobTool,
|
|
RecipeTool,
|
|
SshTool,
|
|
} from "../../src/tools/index";
|
|
|
|
const allToolsSettings = Settings.isolated({
|
|
"astGrep.enabled": true,
|
|
"astEdit.enabled": true,
|
|
"renderMermaid.enabled": true,
|
|
"debug.enabled": true,
|
|
"find.enabled": true,
|
|
"search.enabled": true,
|
|
"github.enabled": true,
|
|
"lsp.enabled": true,
|
|
"inspect_image.enabled": true,
|
|
"web_search.enabled": true,
|
|
"calc.enabled": true,
|
|
"browser.enabled": true,
|
|
"checkpoint.enabled": true,
|
|
"irc.enabled": true,
|
|
"recipe.enabled": true,
|
|
"todo.enabled": true,
|
|
"memory.backend": "hindsight",
|
|
"tools.discoveryMode": "all",
|
|
});
|
|
|
|
const toolSession: ToolSession = {
|
|
cwd: "/tmp/test",
|
|
hasUI: false,
|
|
getSessionFile: () => null,
|
|
getSessionSpawns: () => null,
|
|
settings: allToolsSettings,
|
|
isToolDiscoveryEnabled: () => true,
|
|
getSelectedDiscoveredToolNames: () => [],
|
|
activateDiscoveredTools: async names => names,
|
|
};
|
|
|
|
async function getToolMetadata(): Promise<Map<string, { loadMode?: string; summary?: string }>> {
|
|
const tools = await createTools(toolSession, Object.keys(BUILTIN_TOOLS));
|
|
const metadata = new Map(tools.map(tool => [tool.name, { loadMode: tool.loadMode, summary: tool.summary }]));
|
|
for (const tool of [
|
|
new AskTool({ ...toolSession, hasUI: true }),
|
|
new SshTool(toolSession, [], new Map(), ""),
|
|
new JobTool(toolSession),
|
|
new RecipeTool(toolSession, []),
|
|
new IrcTool(toolSession),
|
|
]) {
|
|
metadata.set(tool.name, { loadMode: tool.loadMode, summary: tool.summary });
|
|
}
|
|
return metadata;
|
|
}
|
|
describe("BUILTIN_TOOLS public factory map", () => {
|
|
it("sets loading fields on tool definitions without wrapping factories", async () => {
|
|
const metadata = await getToolMetadata();
|
|
const missing = Object.keys(BUILTIN_TOOLS).filter(name => metadata.get(name)?.loadMode === undefined);
|
|
expect(missing).toEqual([]);
|
|
});
|
|
});
|
|
|
|
describe("built-in tool loadMode annotations", () => {
|
|
it("provides a summary for every discoverable tool", async () => {
|
|
const missing: string[] = [];
|
|
const metadata = await getToolMetadata();
|
|
for (const [name, meta] of metadata) {
|
|
if (meta.loadMode === "discoverable" && !meta.summary) {
|
|
missing.push(name);
|
|
}
|
|
}
|
|
expect(missing).toEqual([]);
|
|
});
|
|
});
|
|
|
|
describe("computeEssentialBuiltinNames", () => {
|
|
it("returns DEFAULT_ESSENTIAL_TOOL_NAMES when override is empty", () => {
|
|
const settings = Settings.isolated({});
|
|
expect(computeEssentialBuiltinNames(settings).sort()).toEqual([...DEFAULT_ESSENTIAL_TOOL_NAMES].sort());
|
|
});
|
|
|
|
it("respects tools.essentialOverride when provided", () => {
|
|
const settings = Settings.isolated({ "tools.essentialOverride": ["read", "find"] });
|
|
expect(computeEssentialBuiltinNames(settings).sort()).toEqual(["find", "read"]);
|
|
});
|
|
|
|
it("filters override entries that are not known built-in tools", () => {
|
|
const settings = Settings.isolated({
|
|
"tools.essentialOverride": ["read", "not_a_real_tool", "edit"],
|
|
});
|
|
expect(computeEssentialBuiltinNames(settings).sort()).toEqual(["edit", "read"]);
|
|
});
|
|
|
|
it("trims whitespace and drops empty entries from the override", () => {
|
|
const settings = Settings.isolated({
|
|
"tools.essentialOverride": [" read ", "", " "],
|
|
});
|
|
expect(computeEssentialBuiltinNames(settings)).toEqual(["read"]);
|
|
});
|
|
|
|
it("falls back to defaults when override is non-empty but contains only invalid names", () => {
|
|
// The filtered list is empty (no valid names), but the override was provided —
|
|
// current behavior returns the empty filtered list (caller can decide). Document the behavior.
|
|
const settings = Settings.isolated({
|
|
"tools.essentialOverride": ["not_a_real_tool"],
|
|
});
|
|
expect(computeEssentialBuiltinNames(settings)).toEqual([]);
|
|
});
|
|
});
|
|
|
|
describe("tools.discoveryMode settings schema", () => {
|
|
it("back-compat: mcp.discoveryMode still accepted", () => {
|
|
const settings = Settings.isolated({ "mcp.discoveryMode": true });
|
|
expect(settings.get("mcp.discoveryMode")).toBe(true);
|
|
});
|
|
});
|