can1357
6385afdfb7
- Replaced Bun.sleep and wall-clock timing with fake timers (vi.useFakeTimers), release gates, and deterministic polling across 15+ test files to eliminate flakiness and improve speed. - Consolidated per-test fixture setup into beforeAll/afterAll lifecycle hooks across 20+ test files, reducing redundant initialization and improving test performance by reusing shared immutable fixtures. - Stubbed network calls in ModelRegistry and test discovery to prevent unintended outbound requests during test execution. - Replaced subprocess-based test coordination (file markers, Bun.sleep polling) with in-memory fakes (FakeWebSocket, FakeLspServer, VirtualClock) for deterministic, fast test execution.
620 lines
25 KiB
TypeScript
620 lines
25 KiB
TypeScript
import { afterAll, afterEach, beforeAll, beforeEach, describe, expect, it } from "bun:test";
|
|
import * as fs from "node:fs";
|
|
import * as os from "node:os";
|
|
import * as path from "node:path";
|
|
|
|
import {
|
|
MarketplaceManager,
|
|
readInstalledPluginsRegistry,
|
|
} from "@oh-my-pi/pi-coding-agent/extensibility/plugins/marketplace";
|
|
|
|
// Minimal marketplace fixture, built once into a temp dir (see beforeAll). It carries only
|
|
// what these tests assert — one plugin entry plus a plugin.json for the version-fallback path —
|
|
// so each install's recursive cache copy stays a single file rather than the full shared fixture.
|
|
let FIXTURE_DIR: string;
|
|
|
|
function buildMinimalFixture(): string {
|
|
const root = fs.mkdtempSync(path.join(os.tmpdir(), "omp-mgr-fixture-"));
|
|
const pluginDir = path.join(root, "plugins", "hello-plugin");
|
|
fs.mkdirSync(path.join(pluginDir, ".claude-plugin"), { recursive: true });
|
|
fs.mkdirSync(path.join(root, ".claude-plugin"), { recursive: true });
|
|
fs.writeFileSync(
|
|
path.join(root, ".claude-plugin", "marketplace.json"),
|
|
JSON.stringify({
|
|
name: "test-marketplace",
|
|
owner: { name: "Test Author", email: "test@example.com" },
|
|
metadata: { description: "A test marketplace for unit tests", version: "1.0.0" },
|
|
plugins: [
|
|
{
|
|
name: "hello-plugin",
|
|
source: "./plugins/hello-plugin",
|
|
description: "A test plugin that greets",
|
|
version: "1.0.0",
|
|
},
|
|
],
|
|
}),
|
|
);
|
|
// Consulted only when the catalog version is stripped (the version-fallback test).
|
|
fs.writeFileSync(
|
|
path.join(pluginDir, ".claude-plugin", "plugin.json"),
|
|
JSON.stringify({ name: "hello-plugin", version: "1.0.0" }),
|
|
);
|
|
return root;
|
|
}
|
|
|
|
// ── Test helper ───────────────────────────────────────────────────────────────
|
|
|
|
interface TestContext {
|
|
manager: MarketplaceManager;
|
|
tmpDir: string;
|
|
/** Incremented each time clearPluginRootsCache is called. */
|
|
clearCount: () => number;
|
|
}
|
|
|
|
function createTestContext(): TestContext {
|
|
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "omp-mgr-test-"));
|
|
|
|
const dirs = {
|
|
mktRegistry: path.join(tmpDir, "marketplaces.json"),
|
|
instRegistry: path.join(tmpDir, "installed_plugins.json"),
|
|
projectInstRegistry: path.join(tmpDir, "project_installed_plugins.json"),
|
|
mktCache: path.join(tmpDir, "cache", "marketplaces"),
|
|
plugCache: path.join(tmpDir, "cache", "plugins"),
|
|
};
|
|
|
|
let count = 0;
|
|
|
|
const manager = new MarketplaceManager({
|
|
marketplacesRegistryPath: dirs.mktRegistry,
|
|
installedRegistryPath: dirs.instRegistry,
|
|
projectInstalledRegistryPath: dirs.projectInstRegistry,
|
|
marketplacesCacheDir: dirs.mktCache,
|
|
pluginsCacheDir: dirs.plugCache,
|
|
clearPluginRootsCache: () => {
|
|
count++;
|
|
},
|
|
});
|
|
|
|
return { manager, tmpDir, clearCount: () => count };
|
|
}
|
|
|
|
// ── Tests ─────────────────────────────────────────────────────────────────────
|
|
|
|
describe("MarketplaceManager", () => {
|
|
let ctx: TestContext;
|
|
|
|
beforeAll(() => {
|
|
FIXTURE_DIR = buildMinimalFixture();
|
|
});
|
|
|
|
afterAll(() => {
|
|
fs.rmSync(FIXTURE_DIR, { recursive: true, force: true });
|
|
});
|
|
|
|
beforeEach(() => {
|
|
ctx = createTestContext();
|
|
});
|
|
|
|
afterEach(() => {
|
|
fs.rmSync(ctx.tmpDir, { recursive: true, force: true });
|
|
});
|
|
|
|
// ── Marketplace lifecycle ──────────────────────────────────────────────
|
|
|
|
it("addMarketplace with local fixture → appears in listMarketplaces", async () => {
|
|
const entry = await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
|
|
expect(entry.name).toBe("test-marketplace");
|
|
expect(entry.sourceType).toBe("local");
|
|
expect(entry.sourceUri).toBe(FIXTURE_DIR);
|
|
|
|
const list = await ctx.manager.listMarketplaces();
|
|
expect(list).toHaveLength(1);
|
|
expect(list[0].name).toBe("test-marketplace");
|
|
});
|
|
|
|
it("addMarketplace with duplicate name → throws", async () => {
|
|
await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
await expect(ctx.manager.addMarketplace(FIXTURE_DIR)).rejects.toThrow(/already exists/);
|
|
});
|
|
|
|
it("removeMarketplace → gone from list and catalog cache removed", async () => {
|
|
const entry = await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
|
|
// Catalog file should exist in cache
|
|
expect(fs.existsSync(entry.catalogPath)).toBe(true);
|
|
|
|
await ctx.manager.removeMarketplace("test-marketplace");
|
|
|
|
const list = await ctx.manager.listMarketplaces();
|
|
expect(list).toHaveLength(0);
|
|
|
|
// Catalog cache dir should be gone
|
|
const catalogDir = path.dirname(entry.catalogPath);
|
|
expect(fs.existsSync(catalogDir)).toBe(false);
|
|
});
|
|
|
|
it("updateMarketplace on nonexistent marketplace → throws", async () => {
|
|
await expect(ctx.manager.updateMarketplace("ghost")).rejects.toThrow(/not found/);
|
|
});
|
|
|
|
it("updateMarketplace re-fetches and updates updatedAt", async () => {
|
|
const added = await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
|
|
const updated = await ctx.manager.updateMarketplace("test-marketplace");
|
|
expect(updated.name).toBe("test-marketplace");
|
|
expect(updated.addedAt).toBe(added.addedAt);
|
|
// updatedAt must be at or after addedAt
|
|
expect(new Date(updated.updatedAt) >= new Date(added.addedAt)).toBe(true);
|
|
});
|
|
|
|
// ── Plugin discovery ───────────────────────────────────────────────────
|
|
|
|
it("listAvailablePlugins → returns catalog entries", async () => {
|
|
await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
const plugins = await ctx.manager.listAvailablePlugins();
|
|
expect(plugins).toHaveLength(1);
|
|
expect(plugins[0].name).toBe("hello-plugin");
|
|
});
|
|
|
|
it("listAvailablePlugins(marketplace) → filtered to that marketplace", async () => {
|
|
await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
const plugins = await ctx.manager.listAvailablePlugins("test-marketplace");
|
|
expect(plugins).toHaveLength(1);
|
|
expect(plugins[0].name).toBe("hello-plugin");
|
|
});
|
|
|
|
it("listAvailablePlugins(unknown) → throws", async () => {
|
|
await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
await expect(ctx.manager.listAvailablePlugins("no-such")).rejects.toThrow(/not found/);
|
|
});
|
|
|
|
// ── Install ────────────────────────────────────────────────────────────
|
|
|
|
it("installPlugin → plugin in cache + in registry", async () => {
|
|
await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
const instEntry = await ctx.manager.installPlugin("hello-plugin", "test-marketplace");
|
|
|
|
expect(instEntry.scope).toBe("user");
|
|
expect(instEntry.version).toBe("1.0.0");
|
|
expect(fs.existsSync(instEntry.installPath)).toBe(true);
|
|
|
|
const installed = await ctx.manager.listInstalledPlugins();
|
|
expect(installed).toHaveLength(1);
|
|
expect(installed[0].id).toBe("hello-plugin@test-marketplace");
|
|
});
|
|
|
|
it("installPlugin embeds config-only marketplace LSP metadata", async () => {
|
|
const marketplaceDir = path.join(ctx.tmpDir, "config-only-marketplace");
|
|
const pluginDir = path.join(marketplaceDir, "plugins", "csharp-lsp");
|
|
await fs.promises.mkdir(pluginDir, { recursive: true });
|
|
await Bun.write(path.join(pluginDir, "README.md"), "config-only C# LSP plugin\n");
|
|
await fs.promises.mkdir(path.join(marketplaceDir, ".claude-plugin"), { recursive: true });
|
|
await Bun.write(
|
|
path.join(marketplaceDir, ".claude-plugin", "marketplace.json"),
|
|
`${JSON.stringify(
|
|
{
|
|
name: "config-only-marketplace",
|
|
owner: { name: "Test Author" },
|
|
plugins: [
|
|
{
|
|
name: "csharp-lsp",
|
|
source: "./plugins/csharp-lsp",
|
|
version: "1.0.0",
|
|
lspServers: {
|
|
"csharp-ls": {
|
|
command: "csharp-ls",
|
|
extensionToLanguage: { ".cs": "csharp" },
|
|
},
|
|
},
|
|
},
|
|
],
|
|
},
|
|
null,
|
|
2,
|
|
)}\n`,
|
|
);
|
|
|
|
await ctx.manager.addMarketplace(marketplaceDir);
|
|
const instEntry = await ctx.manager.installPlugin("csharp-lsp", "config-only-marketplace");
|
|
|
|
const lspConfig = await Bun.file(path.join(instEntry.installPath, ".lsp.json")).json();
|
|
expect(lspConfig).toEqual({
|
|
servers: {
|
|
"csharp-ls": {
|
|
command: "csharp-ls",
|
|
extensionToLanguage: { ".cs": "csharp" },
|
|
},
|
|
},
|
|
});
|
|
});
|
|
|
|
it("installPlugin with scope:project → persisted in project registry, isolated from user", async () => {
|
|
await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
const instEntry = await ctx.manager.installPlugin("hello-plugin", "test-marketplace", {
|
|
scope: "project",
|
|
});
|
|
expect(instEntry.scope).toBe("project");
|
|
expect(instEntry.version).toBe("1.0.0");
|
|
expect(fs.existsSync(instEntry.installPath)).toBe(true);
|
|
|
|
// Persisted to the project registry with project scope — and absent from the user registry.
|
|
const projectReg = await readInstalledPluginsRegistry(path.join(ctx.tmpDir, "project_installed_plugins.json"));
|
|
expect(projectReg.plugins["hello-plugin@test-marketplace"]?.[0].scope).toBe("project");
|
|
const userReg = await readInstalledPluginsRegistry(path.join(ctx.tmpDir, "installed_plugins.json"));
|
|
expect(userReg.plugins["hello-plugin@test-marketplace"]).toBeUndefined();
|
|
});
|
|
|
|
it("installPlugin already installed → throws without force", async () => {
|
|
await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
await ctx.manager.installPlugin("hello-plugin", "test-marketplace");
|
|
await expect(ctx.manager.installPlugin("hello-plugin", "test-marketplace")).rejects.toThrow(/already installed/);
|
|
});
|
|
|
|
it("installPlugin with force:true → replaces existing", async () => {
|
|
await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
const first = await ctx.manager.installPlugin("hello-plugin", "test-marketplace");
|
|
const second = await ctx.manager.installPlugin("hello-plugin", "test-marketplace", {
|
|
force: true,
|
|
});
|
|
|
|
expect(second.installPath).toBe(first.installPath);
|
|
expect(fs.existsSync(second.installPath)).toBe(true);
|
|
|
|
const installed = await ctx.manager.listInstalledPlugins();
|
|
expect(installed).toHaveLength(1);
|
|
});
|
|
|
|
it("installPlugin with nonexistent marketplace → clear error", async () => {
|
|
await expect(ctx.manager.installPlugin("hello-plugin", "no-such-market")).rejects.toThrow(
|
|
/Marketplace "no-such-market" not found/,
|
|
);
|
|
});
|
|
|
|
it("installPlugin with nonexistent plugin in catalog → clear error", async () => {
|
|
await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
await expect(ctx.manager.installPlugin("ghost-plugin", "test-marketplace")).rejects.toThrow(
|
|
/Plugin "ghost-plugin" not found in marketplace "test-marketplace"/,
|
|
);
|
|
});
|
|
|
|
// ── Uninstall ──────────────────────────────────────────────────────────
|
|
|
|
it("uninstallPlugin → cache removed + deregistered", async () => {
|
|
await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
const instEntry = await ctx.manager.installPlugin("hello-plugin", "test-marketplace");
|
|
|
|
await ctx.manager.uninstallPlugin("hello-plugin@test-marketplace");
|
|
|
|
expect(fs.existsSync(instEntry.installPath)).toBe(false);
|
|
|
|
const installed = await ctx.manager.listInstalledPlugins();
|
|
expect(installed).toHaveLength(0);
|
|
});
|
|
|
|
it("uninstallPlugin nonexistent → throws", async () => {
|
|
await expect(ctx.manager.uninstallPlugin("ghost-plugin@nowhere")).rejects.toThrow(/not installed/);
|
|
});
|
|
|
|
it("uninstallPlugin with invalid ID format → throws clear error", async () => {
|
|
await expect(ctx.manager.uninstallPlugin("no-at-sign")).rejects.toThrow(/Invalid plugin ID format/);
|
|
});
|
|
|
|
// ── setPluginEnabled ───────────────────────────────────────────────────
|
|
|
|
it("setPluginEnabled → persisted in registry", async () => {
|
|
await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
await ctx.manager.installPlugin("hello-plugin", "test-marketplace");
|
|
|
|
await ctx.manager.setPluginEnabled("hello-plugin@test-marketplace", false);
|
|
|
|
const installed = await ctx.manager.listInstalledPlugins();
|
|
expect(installed[0].entries[0].enabled).toBe(false);
|
|
|
|
await ctx.manager.setPluginEnabled("hello-plugin@test-marketplace", true);
|
|
const updated = await ctx.manager.listInstalledPlugins();
|
|
expect(updated[0].entries[0].enabled).toBe(true);
|
|
});
|
|
|
|
it("setPluginEnabled on nonexistent plugin → throws", async () => {
|
|
await expect(ctx.manager.setPluginEnabled("ghost@nowhere", true)).rejects.toThrow(/not installed/);
|
|
});
|
|
|
|
// ── version fallback ───────────────────────────────────────────────────
|
|
|
|
it("installPlugin falls back to plugin.json version when catalog version is missing", async () => {
|
|
// Write a catalog without a version field on the plugin
|
|
await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
|
|
// Mutate the cached catalog to remove version
|
|
const list = await ctx.manager.listMarketplaces();
|
|
const catalogPath = list[0].catalogPath;
|
|
const content = await Bun.file(catalogPath).text();
|
|
const catalog = JSON.parse(content) as {
|
|
plugins: Array<Record<string, unknown>>;
|
|
};
|
|
catalog.plugins[0] = { ...catalog.plugins[0] };
|
|
delete catalog.plugins[0].version;
|
|
await Bun.write(catalogPath, `${JSON.stringify(catalog, null, 2)}\n`);
|
|
|
|
const instEntry = await ctx.manager.installPlugin("hello-plugin", "test-marketplace");
|
|
// No catalog version, but fixture's .claude-plugin/plugin.json has version "1.0.0"
|
|
expect(instEntry.version).toBe("1.0.0");
|
|
});
|
|
// ── Scope feature ────────────────────────────────────────────────────────
|
|
|
|
it("installPlugin scope:project when no projectInstalledRegistryPath → throws", async () => {
|
|
const tmp = fs.mkdtempSync(path.join(os.tmpdir(), "omp-mgr-noproj-"));
|
|
try {
|
|
const noProjectManager = new MarketplaceManager({
|
|
marketplacesRegistryPath: path.join(tmp, "marketplaces.json"),
|
|
installedRegistryPath: path.join(tmp, "installed_plugins.json"),
|
|
marketplacesCacheDir: path.join(tmp, "cache", "marketplaces"),
|
|
pluginsCacheDir: path.join(tmp, "cache", "plugins"),
|
|
});
|
|
await noProjectManager.addMarketplace(FIXTURE_DIR);
|
|
await expect(
|
|
noProjectManager.installPlugin("hello-plugin", "test-marketplace", { scope: "project" }),
|
|
).rejects.toThrow(/project directory/);
|
|
} finally {
|
|
fs.rmSync(tmp, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
it("plugin in both scopes, no scope arg → uninstall/setPluginEnabled/upgrade all throw disambiguation", async () => {
|
|
await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
await ctx.manager.installPlugin("hello-plugin", "test-marketplace", { scope: "user" });
|
|
await ctx.manager.installPlugin("hello-plugin", "test-marketplace", { scope: "project" });
|
|
|
|
// Each mutating op refuses an ambiguous (both-scope) target before touching any state,
|
|
// so the three assertions share one setup without interfering.
|
|
await expect(ctx.manager.uninstallPlugin("hello-plugin@test-marketplace")).rejects.toThrow(
|
|
/both user and project scope/,
|
|
);
|
|
await expect(ctx.manager.setPluginEnabled("hello-plugin@test-marketplace", false)).rejects.toThrow(
|
|
/both user and project scope/,
|
|
);
|
|
await expect(ctx.manager.upgradePlugin("hello-plugin@test-marketplace")).rejects.toThrow(
|
|
/both user and project scope/,
|
|
);
|
|
});
|
|
|
|
it("uninstallPlugin scope:user removes only user entry, keeps project entry", async () => {
|
|
await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
await ctx.manager.installPlugin("hello-plugin", "test-marketplace", { scope: "user" });
|
|
await ctx.manager.installPlugin("hello-plugin", "test-marketplace", { scope: "project" });
|
|
|
|
await ctx.manager.uninstallPlugin("hello-plugin@test-marketplace", "user");
|
|
|
|
const userReg = await readInstalledPluginsRegistry(path.join(ctx.tmpDir, "installed_plugins.json"));
|
|
expect(userReg.plugins["hello-plugin@test-marketplace"]).toBeUndefined();
|
|
|
|
const projectReg = await readInstalledPluginsRegistry(path.join(ctx.tmpDir, "project_installed_plugins.json"));
|
|
expect(projectReg.plugins["hello-plugin@test-marketplace"]).toBeDefined();
|
|
expect(projectReg.plugins["hello-plugin@test-marketplace"]![0].scope).toBe("project");
|
|
});
|
|
|
|
it("uninstallPlugin does not delete cache dir when other scope still references it", async () => {
|
|
await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
const userEntry = await ctx.manager.installPlugin("hello-plugin", "test-marketplace", {
|
|
scope: "user",
|
|
});
|
|
// Same plugin+version → same cache path for the project-scope install.
|
|
await ctx.manager.installPlugin("hello-plugin", "test-marketplace", { scope: "project" });
|
|
|
|
await ctx.manager.uninstallPlugin("hello-plugin@test-marketplace", "user");
|
|
|
|
// Cache must still exist — project scope still references it.
|
|
expect(fs.existsSync(userEntry.installPath)).toBe(true);
|
|
});
|
|
|
|
it("listInstalledPlugins marks user entry as shadowed when project entry exists for same ID", async () => {
|
|
await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
await ctx.manager.installPlugin("hello-plugin", "test-marketplace", { scope: "user" });
|
|
await ctx.manager.installPlugin("hello-plugin", "test-marketplace", { scope: "project" });
|
|
|
|
const installed = await ctx.manager.listInstalledPlugins();
|
|
const userSummary = installed.find(p => p.id === "hello-plugin@test-marketplace" && p.scope === "user");
|
|
expect(userSummary).toBeDefined();
|
|
expect(userSummary!.shadowedBy).toBe("project");
|
|
});
|
|
|
|
// ── auto-update ──────────────────────────────────────────────────────────
|
|
|
|
describe("auto-update", () => {
|
|
// Read catalogPath from the (single) registered marketplace.
|
|
async function getCatalogPath(): Promise<string> {
|
|
const list = await ctx.manager.listMarketplaces();
|
|
return list[0].catalogPath;
|
|
}
|
|
|
|
// Overwrite the version field on the first plugin entry in the cached catalog.
|
|
async function bumpCatalogVersion(newVersion: string): Promise<void> {
|
|
const catalogPath = await getCatalogPath();
|
|
const content = await Bun.file(catalogPath).text();
|
|
const catalog = JSON.parse(content) as { plugins: Array<Record<string, unknown>> };
|
|
catalog.plugins[0] = { ...catalog.plugins[0], version: newVersion };
|
|
await Bun.write(catalogPath, `${JSON.stringify(catalog, null, 2)}\n`);
|
|
}
|
|
|
|
// Directly patch updatedAt in the marketplaces registry file.
|
|
function setMarketplaceUpdatedAt(iso: string): void {
|
|
const regPath = path.join(ctx.tmpDir, "marketplaces.json");
|
|
const reg = JSON.parse(fs.readFileSync(regPath, "utf-8")) as {
|
|
version: number;
|
|
marketplaces: Array<{ updatedAt: string }>;
|
|
};
|
|
reg.marketplaces[0].updatedAt = iso;
|
|
fs.writeFileSync(regPath, JSON.stringify(reg, null, 2));
|
|
}
|
|
|
|
it("checkForUpdates returns outdated plugins", async () => {
|
|
await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
await ctx.manager.installPlugin("hello-plugin", "test-marketplace");
|
|
await bumpCatalogVersion("2.0.0");
|
|
|
|
const updates = await ctx.manager.checkForUpdates();
|
|
|
|
expect(updates).toHaveLength(1);
|
|
expect(updates[0]).toEqual({
|
|
pluginId: "hello-plugin@test-marketplace",
|
|
scope: "user",
|
|
from: "1.0.0",
|
|
to: "2.0.0",
|
|
});
|
|
});
|
|
|
|
it("checkForUpdates returns empty when up to date", async () => {
|
|
await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
await ctx.manager.installPlugin("hello-plugin", "test-marketplace");
|
|
// Catalog and installed version are both 1.0.0 — nothing to report.
|
|
|
|
const updates = await ctx.manager.checkForUpdates();
|
|
expect(updates).toEqual([]);
|
|
});
|
|
|
|
it("checkForUpdates skips plugins with no catalog version", async () => {
|
|
await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
await ctx.manager.installPlugin("hello-plugin", "test-marketplace");
|
|
|
|
// Strip the version field from the cached catalog entry.
|
|
const catalogPath = await getCatalogPath();
|
|
const content = await Bun.file(catalogPath).text();
|
|
const catalog = JSON.parse(content) as { plugins: Array<Record<string, unknown>> };
|
|
delete catalog.plugins[0].version;
|
|
await Bun.write(catalogPath, `${JSON.stringify(catalog, null, 2)}\n`);
|
|
|
|
const updates = await ctx.manager.checkForUpdates();
|
|
expect(updates).toEqual([]);
|
|
});
|
|
|
|
it("checkForUpdates handles missing catalog gracefully", async () => {
|
|
await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
await ctx.manager.installPlugin("hello-plugin", "test-marketplace");
|
|
|
|
// Delete the cached catalog file; checkForUpdates must skip rather than throw.
|
|
const catalogPath = await getCatalogPath();
|
|
fs.unlinkSync(catalogPath);
|
|
|
|
const updates = await ctx.manager.checkForUpdates();
|
|
expect(updates).toEqual([]);
|
|
});
|
|
|
|
it("upgradePlugin updates the installed version", async () => {
|
|
await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
await ctx.manager.installPlugin("hello-plugin", "test-marketplace");
|
|
await bumpCatalogVersion("2.0.0");
|
|
|
|
const entry = await ctx.manager.upgradePlugin("hello-plugin@test-marketplace");
|
|
expect(entry.version).toBe("2.0.0");
|
|
|
|
// Confirm the registry reflects the new version.
|
|
const installed = await ctx.manager.listInstalledPlugins();
|
|
expect(installed).toHaveLength(1);
|
|
expect(installed[0].entries[0].version).toBe("2.0.0");
|
|
});
|
|
|
|
it("upgradePlugin rejects invalid plugin ID", async () => {
|
|
await expect(ctx.manager.upgradePlugin("no-at-sign")).rejects.toThrow(/Invalid plugin ID/);
|
|
});
|
|
|
|
it("upgradePlugin preserves the scope of the existing install", async () => {
|
|
await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
await ctx.manager.installPlugin("hello-plugin", "test-marketplace", { scope: "project" });
|
|
await bumpCatalogVersion("2.0.0");
|
|
|
|
const entry = await ctx.manager.upgradePlugin("hello-plugin@test-marketplace");
|
|
expect(entry.scope).toBe("project");
|
|
expect(entry.version).toBe("2.0.0");
|
|
});
|
|
|
|
it("upgradeAllPlugins upgrades outdated plugins and returns results", async () => {
|
|
await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
await ctx.manager.installPlugin("hello-plugin", "test-marketplace");
|
|
|
|
// Inject a second plugin that has no catalog entry — checkForUpdates will skip it,
|
|
// proving upgradeAllPlugins only acts on genuinely outdated plugins.
|
|
const instRegPath = path.join(ctx.tmpDir, "installed_plugins.json");
|
|
const reg = JSON.parse(fs.readFileSync(instRegPath, "utf-8")) as {
|
|
version: number;
|
|
plugins: Record<string, unknown[]>;
|
|
};
|
|
const now = new Date().toISOString();
|
|
reg.plugins["phantom-plugin@test-marketplace"] = [
|
|
{ scope: "user", installPath: "/nonexistent", version: "1.0.0", installedAt: now, lastUpdated: now },
|
|
];
|
|
fs.writeFileSync(instRegPath, JSON.stringify(reg, null, 2));
|
|
|
|
// Only hello-plugin gets a version bump in the catalog.
|
|
await bumpCatalogVersion("2.0.0");
|
|
|
|
const results = await ctx.manager.upgradeAllPlugins();
|
|
|
|
expect(results).toHaveLength(1);
|
|
expect(results[0]).toEqual({
|
|
pluginId: "hello-plugin@test-marketplace",
|
|
scope: "user",
|
|
from: "1.0.0",
|
|
to: "2.0.0",
|
|
});
|
|
});
|
|
|
|
it("upgradeAllPlugins returns empty array when all plugins are up to date", async () => {
|
|
await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
await ctx.manager.installPlugin("hello-plugin", "test-marketplace");
|
|
// No catalog modification — installed and catalog both at 1.0.0.
|
|
|
|
const results = await ctx.manager.upgradeAllPlugins();
|
|
expect(results).toEqual([]);
|
|
});
|
|
|
|
it("refreshStaleMarketplaces skips fresh marketplaces", async () => {
|
|
await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
// updatedAt is just now — not past the 24-hour threshold.
|
|
await bumpCatalogVersion("2.0.0");
|
|
|
|
await ctx.manager.refreshStaleMarketplaces();
|
|
|
|
// Catalog should remain at 2.0.0 — the marketplace was not re-fetched.
|
|
const catalogPath = await getCatalogPath();
|
|
const content = await Bun.file(catalogPath).text();
|
|
const catalog = JSON.parse(content) as { plugins: Array<{ version?: string }> };
|
|
expect(catalog.plugins[0].version).toBe("2.0.0");
|
|
});
|
|
|
|
it("refreshStaleMarketplaces re-fetches stale marketplaces", async () => {
|
|
await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
// Tamper with catalog to simulate drift from the real source.
|
|
await bumpCatalogVersion("2.0.0");
|
|
|
|
// Force updatedAt to 25 hours ago — past the 24-hour staleness threshold.
|
|
const staleDate = new Date(Date.now() - 25 * 60 * 60 * 1000).toISOString();
|
|
setMarketplaceUpdatedAt(staleDate);
|
|
|
|
await ctx.manager.refreshStaleMarketplaces();
|
|
|
|
// updateMarketplace re-fetches from FIXTURE_DIR which has version 1.0.0.
|
|
const catalogPath = await getCatalogPath();
|
|
const content = await Bun.file(catalogPath).text();
|
|
const catalog = JSON.parse(content) as { plugins: Array<{ version?: string }> };
|
|
expect(catalog.plugins[0].version).toBe("1.0.0");
|
|
});
|
|
|
|
it("upgradePluginAcrossScopes upgrades in all scopes, returns both entries", async () => {
|
|
await ctx.manager.addMarketplace(FIXTURE_DIR);
|
|
await ctx.manager.installPlugin("hello-plugin", "test-marketplace", { scope: "user" });
|
|
await ctx.manager.installPlugin("hello-plugin", "test-marketplace", { scope: "project" });
|
|
await bumpCatalogVersion("2.0.0");
|
|
|
|
const entries = await ctx.manager.upgradePluginAcrossScopes("hello-plugin@test-marketplace");
|
|
|
|
expect(entries).toHaveLength(2);
|
|
const scopes = entries.map(e => e.scope).sort();
|
|
expect(scopes).toEqual(["project", "user"]);
|
|
for (const entry of entries) {
|
|
expect(entry.version).toBe("2.0.0");
|
|
}
|
|
});
|
|
});
|
|
});
|