roboomp
73a12c7ea2
The postmortem SIGTERM/SIGHUP/uncaughtException handlers only ran the registered cleanup callback list before process.exit, and the only session-related callback was session-manager-flush. So a real kernel signal (terminal close, process manager killing omp, IDE stop) skipped saveDraft, session.dispose (session_shutdown emit, owned async job disposal, kernel disposal, MCP disconnect, browser tab release), and violated the SessionShutdownEvent docstring contract that promises delivery on SIGINT/SIGTERM. The LSP client also owned its own SIGINT/SIGTERM handlers that called shutdownAll then process.exit(0), which could race postmortem's async runCleanup and short-circuit the session teardown. - Extracted a promise-memoized createSessionTeardown helper (modes/session-teardown.ts) that snapshots the editor draft, persists it via sessionManager.saveDraft, then invokes session.dispose. A saveDraft failure is logged but never aborts disposal. - Memoized AgentSession.dispose so the keypress path and the signal path share one settled promise and cannot double-emit session_shutdown or double-drain the owned AsyncJobManager. - Registered the teardown on postmortem as "session-teardown" in InteractiveMode.init, replacing the narrower session-manager-flush callback. InteractiveMode.shutdown now delegates the draft+dispose steps to the same helper. - Replaced the LSP client's SIGINT/SIGTERM handlers with a "lsp-shutdown" postmortem callback so LSP cleanup runs alongside every other session teardown instead of racing them via process.exit(0). beforeExit is unchanged. - Added session-teardown.test.ts covering: draft-then-dispose ordering, disposal after saveDraft rejects, empty-string clears stale sidecar, promise memoization under concurrent invocation, and snapshot-at-first-call semantics. Fixes #4080
@oh-my-pi/pi-coding-agent
Core implementation package for the omp coding agent in the oh-my-pi monorepo.
For installation, setup, provider configuration, model roles, slash commands, and full CLI reference, see:
Package-specific references:
Memory backends
The agent supports three mutually-exclusive memory backends, selected via the memory.backend setting (Settings → Memory tab, or ~/.omp/config.yml):
off(default) — no memory subsystem runs.local— existing rollout-summarisation pipeline; writesmemory_summary.mdand consolidated artifacts under the agent dir.hindsight— talks to a Hindsight server (Cloud or self-hosted Docker), retains transcripts every Nth user turn, recalls memories on the first turn of a session, and exposesretain,recall, andreflect.
Hindsight quickstart
- Run a Hindsight server (Cloud or
docker run -p 8888:8888 ghcr.io/vectorize-io/hindsight:latest). - Set
memory.backend = "hindsight"andhindsight.apiUrl = "http://localhost:8888"(or your Cloud URL). - Optional environment overrides (env wins over settings):
HINDSIGHT_API_URL,HINDSIGHT_API_TOKEN— connectionHINDSIGHT_BANK_ID,HINDSIGHT_DYNAMIC_BANK_ID,HINDSIGHT_AGENT_NAME— bank addressingHINDSIGHT_AUTO_RECALL,HINDSIGHT_AUTO_RETAIN,HINDSIGHT_RETAIN_MODE— lifecycleHINDSIGHT_RECALL_BUDGET,HINDSIGHT_RECALL_MAX_TOKENS— recall sizingHINDSIGHT_BANK_MISSION,HINDSIGHT_DEBUG
Switching backends mid-session is honoured on the next system-prompt rebuild and the next /memory slash command. Existing users with memories.enabled = true|false are migrated to memory.backend = "local"|"off" exactly once on first launch.