roboomp
71e3316d69
Restricted mid-prompt /skill:<name> parsing to non-slash drafts so builtin/custom slash-command arguments such as /compact /skill:foo are not intercepted before the command dispatcher runs. Added parser and RPC dispatch regression coverage for the precedence case while keeping leading /skill:<name> (including leading whitespace) working. Fixes #3913
88 lines
2.9 KiB
TypeScript
88 lines
2.9 KiB
TypeScript
import { describe, expect, test } from "bun:test";
|
|
import * as fs from "node:fs/promises";
|
|
import * as os from "node:os";
|
|
import * as path from "node:path";
|
|
import { tryRunRpcSkillCommand } from "@oh-my-pi/pi-coding-agent/modes/rpc/rpc-mode";
|
|
import { type CustomMessage, SKILL_PROMPT_MESSAGE_TYPE } from "@oh-my-pi/pi-coding-agent/session/messages";
|
|
import { removeWithRetries, Snowflake } from "@oh-my-pi/pi-utils";
|
|
|
|
describe("tryRunRpcSkillCommand", () => {
|
|
test("dispatches registered /skill commands as skill prompt messages", async () => {
|
|
const dir = await fs.mkdtemp(path.join(os.tmpdir(), `omp-rpc-skill-${Snowflake.next()}-`));
|
|
const skillPath = path.join(dir, "SKILL.md");
|
|
await Bun.write(
|
|
skillPath,
|
|
"---\nname: reviewer\ndescription: Review code\n---\n\nReview the supplied code carefully.\n",
|
|
);
|
|
|
|
let message: Pick<CustomMessage, "attribution" | "content" | "customType" | "details" | "display"> | undefined;
|
|
|
|
const handled = await tryRunRpcSkillCommand(
|
|
{
|
|
skillsSettings: { enableSkillCommands: true },
|
|
skills: [
|
|
{ name: "reviewer", description: "Review code", filePath: skillPath, baseDir: dir, source: "project" },
|
|
],
|
|
async promptCustomMessage(nextMessage: typeof message) {
|
|
message = nextMessage;
|
|
},
|
|
},
|
|
"/skill:reviewer focus on risks",
|
|
);
|
|
|
|
expect(handled).toEqual({ agentInvoked: true });
|
|
expect(message?.customType).toBe(SKILL_PROMPT_MESSAGE_TYPE);
|
|
expect(message?.content).toContain("Review the supplied code carefully.");
|
|
expect(message?.content).toContain("User: focus on risks");
|
|
expect(message?.display).toBe(true);
|
|
expect(message?.attribution).toBe("user");
|
|
|
|
await removeWithRetries(dir);
|
|
});
|
|
|
|
test("ignores unknown skill commands so normal prompt handling can continue", async () => {
|
|
const handled = await tryRunRpcSkillCommand(
|
|
{
|
|
skillsSettings: { enableSkillCommands: true },
|
|
skills: [],
|
|
async promptCustomMessage() {
|
|
throw new Error("should not dispatch unknown skills");
|
|
},
|
|
},
|
|
"/skill:missing",
|
|
);
|
|
|
|
expect(handled).toBe(false);
|
|
});
|
|
|
|
test("does not steal builtin slash-command arguments that mention registered skills", async () => {
|
|
const dir = await fs.mkdtemp(path.join(os.tmpdir(), `omp-rpc-skill-${Snowflake.next()}-`));
|
|
const skillPath = path.join(dir, "SKILL.md");
|
|
await Bun.write(
|
|
skillPath,
|
|
"---\nname: reviewer\ndescription: Review code\n---\n\nReview the supplied code carefully.\n",
|
|
);
|
|
|
|
let dispatched = false;
|
|
try {
|
|
const handled = await tryRunRpcSkillCommand(
|
|
{
|
|
skillsSettings: { enableSkillCommands: true },
|
|
skills: [
|
|
{ name: "reviewer", description: "Review code", filePath: skillPath, baseDir: dir, source: "project" },
|
|
],
|
|
async promptCustomMessage() {
|
|
dispatched = true;
|
|
},
|
|
},
|
|
"/compact /skill:reviewer",
|
|
);
|
|
|
|
expect(handled).toBe(false);
|
|
expect(dispatched).toBe(false);
|
|
} finally {
|
|
await removeWithRetries(dir);
|
|
}
|
|
});
|
|
});
|