David Marshallandomp
6b63903cf2
`AgentSession.sessionId` is a getter that reads through to `sessionManager.getSessionId()` and mutates when an extension command calls `ctx.newSession` or `ctx.switchSession` (both exposed in the same #configureExtensions block). Snapshotting the id once at factory time routed later elicitations to the pre-switch id — diverging from every other sessionUpdate call in this file, which already reads record.session.sessionId live. createAcpExtensionUiContext now takes `getSessionId: () => string` and calls it per elicitation. Caller passes `() => record.session.sessionId` so each select / confirm / input picks up the current id. Also simplifies elicitFromAcpClient: `onAbort` and `finish` had identical settlement bodies differing only by the resolve value, with a hand-rolled `removeEventListener` symmetry comment to keep them in sync. Collapsed to a single settle path — `onAbort = () => finish(undefined)` — so future changes to settlement apply to both paths automatically. Doc-comment tightened to call out that late SDK `accept` responses (not just rejections) after abort/timeout are also dropped silently. New regression test asserts that mutating the captured sessionId between elicitations is reflected in the next request. Co-Authored-By: omp <noreply@oh-my-pi.dev>
@oh-my-pi/pi-coding-agent
Core implementation package for the omp coding agent in the oh-my-pi monorepo.
For installation, setup, provider configuration, model roles, slash commands, and full CLI reference, see:
Package-specific references:
- CHANGELOG
- MCP configuration guide
- MCP runtime lifecycle
- MCP server/tool authoring
- DEVELOPMENT
- RenderMermaid guide
Memory backends
The agent supports three mutually-exclusive memory backends, selected via the memory.backend setting (Settings → Memory tab, or ~/.omp/config.yml):
off(default) — no memory subsystem runs.local— existing rollout-summarisation pipeline; writesmemory_summary.mdand consolidated artifacts under the agent dir.hindsight— talks to a Hindsight server (Cloud or self-hosted Docker), retains transcripts every Nth user turn, recalls memories on the first turn of a session, and exposesretain,recall, andreflect.
Hindsight quickstart
- Run a Hindsight server (Cloud or
docker run -p 8888:8888 ghcr.io/vectorize-io/hindsight:latest). - Set
memory.backend = "hindsight"andhindsight.apiUrl = "http://localhost:8888"(or your Cloud URL). - Optional environment overrides (env wins over settings):
HINDSIGHT_API_URL,HINDSIGHT_API_TOKEN— connectionHINDSIGHT_BANK_ID,HINDSIGHT_DYNAMIC_BANK_ID,HINDSIGHT_AGENT_NAME— bank addressingHINDSIGHT_AUTO_RECALL,HINDSIGHT_AUTO_RETAIN,HINDSIGHT_RETAIN_MODE— lifecycleHINDSIGHT_RECALL_BUDGET,HINDSIGHT_RECALL_MAX_TOKENS— recall sizingHINDSIGHT_BANK_MISSION,HINDSIGHT_DEBUG
Switching backends mid-session is honoured on the next system-prompt rebuild and the next /memory slash command. Existing users with memories.enabled = true|false are migrated to memory.backend = "local"|"off" exactly once on first launch.