roboomp
6598c69a2f
Per second review on #1711: when notify()'s write failed, #handleClose() flipped #connected=false before the throw. connectToServer()'s catch then called transport.close(), but close() early-returned because #connected was already false — so #process.kill() and the readLoop await never ran. A subprocess that closed its stdin without exiting (parent EPIPE, transport dead, subprocess alive) would leak. close() no longer guards on #connected for the resource phase. It still calls #handleClose() once (idempotent — only if #connected is true), then unconditionally walks the cleanup chain (kill process, null #process, await + null #readLoop), each step individually guarded so repeat calls remain no-ops. onClose still fires exactly once per transport lifetime. Two new tests in StdioTransport.close: (1) close() called after the read-loop has already EOF'd and torn down still completes cleanup without throwing and without re-firing onClose; (2) repeated close() calls fire onClose exactly once and leave #connected=false.
@oh-my-pi/pi-coding-agent
Core implementation package for the omp coding agent in the oh-my-pi monorepo.
For installation, setup, provider configuration, model roles, slash commands, and full CLI reference, see:
Package-specific references:
- CHANGELOG
- MCP configuration guide
- MCP runtime lifecycle
- MCP server/tool authoring
- DEVELOPMENT
- RenderMermaid guide
Memory backends
The agent supports three mutually-exclusive memory backends, selected via the memory.backend setting (Settings → Memory tab, or ~/.omp/config.yml):
off(default) — no memory subsystem runs.local— existing rollout-summarisation pipeline; writesmemory_summary.mdand consolidated artifacts under the agent dir.hindsight— talks to a Hindsight server (Cloud or self-hosted Docker), retains transcripts every Nth user turn, recalls memories on the first turn of a session, and exposesretain,recall, andreflect.
Hindsight quickstart
- Run a Hindsight server (Cloud or
docker run -p 8888:8888 ghcr.io/vectorize-io/hindsight:latest). - Set
memory.backend = "hindsight"andhindsight.apiUrl = "http://localhost:8888"(or your Cloud URL). - Optional environment overrides (env wins over settings):
HINDSIGHT_API_URL,HINDSIGHT_API_TOKEN— connectionHINDSIGHT_BANK_ID,HINDSIGHT_DYNAMIC_BANK_ID,HINDSIGHT_AGENT_NAME— bank addressingHINDSIGHT_AUTO_RECALL,HINDSIGHT_AUTO_RETAIN,HINDSIGHT_RETAIN_MODE— lifecycleHINDSIGHT_RECALL_BUDGET,HINDSIGHT_RECALL_MAX_TOKENS— recall sizingHINDSIGHT_BANK_MISSION,HINDSIGHT_DEBUG
Switching backends mid-session is honoured on the next system-prompt rebuild and the next /memory slash command. Existing users with memories.enabled = true|false are migrated to memory.backend = "local"|"off" exactly once on first launch.