can1357
e7009452b4
- Remove the per-call `save` option from `tab.screenshot()` to simplify usage. - Update `tab.screenshot()` to return the saved file path as a promise string. - Configure screenshot persistence to use daemon path or custom `browser.screenshotDir`. - Add comprehensive tests verifying temp path return and custom directory saving.
39 lines
1.5 KiB
TypeScript
39 lines
1.5 KiB
TypeScript
import { describe, expect, it } from "bun:test";
|
|
import {
|
|
describeInflight,
|
|
describeScreenshot,
|
|
type InflightOp,
|
|
} from "@oh-my-pi/pi-coding-agent/tools/browser/tab-worker";
|
|
|
|
describe("browser op tracking — timeout diagnostics", () => {
|
|
it("labels a screenshot op by its distinguishing argument", () => {
|
|
expect(describeScreenshot({ selector: ".wb-paper-popover" })).toBe(
|
|
'tab.screenshot({ selector: ".wb-paper-popover" })',
|
|
);
|
|
expect(describeScreenshot({ fullPage: true })).toBe("tab.screenshot({ fullPage: true })");
|
|
expect(describeScreenshot()).toBe("tab.screenshot()");
|
|
expect(describeScreenshot({})).toBe("tab.screenshot()");
|
|
});
|
|
|
|
it("names every still-running helper so a cell timeout is attributable", () => {
|
|
const now = Date.now();
|
|
// Inserted newest-first to prove the summary sorts by start time, not insertion order.
|
|
const inflight = new Map<number, InflightOp>([
|
|
[1, { label: "tab.observe()", startedAt: now - 1_000 }],
|
|
[0, { label: 'tab.screenshot({ selector: ".x" })', startedAt: now - 3_000 }],
|
|
]);
|
|
|
|
const summary = describeInflight(inflight);
|
|
|
|
// Oldest op (most likely the culprit) is listed first.
|
|
expect(summary.indexOf("tab.screenshot")).toBeLessThan(summary.indexOf("tab.observe"));
|
|
// Each op carries an elapsed-seconds annotation.
|
|
expect(summary).toMatch(/tab\.screenshot\(\{ selector: "\.x" \}\) \(\d+\.\d+s\)/);
|
|
expect(summary).toMatch(/tab\.observe\(\) \(\d+\.\d+s\)/);
|
|
});
|
|
|
|
it("returns an empty summary when nothing is in flight", () => {
|
|
expect(describeInflight(new Map())).toBe("");
|
|
});
|
|
});
|