oh-my-pi/packages/coding-agent/test/core/atom.test.ts

import { describe, expect, it } from "bun:test";
import {
	type AtomEdit,
	applyAtomEdits,
	computeLineHash,
	HashlineMismatchError,
	resolveAtomEntryPaths,
	resolveAtomToolEdit,
} from "@oh-my-pi/pi-coding-agent/edit";
import type { Anchor } from "@oh-my-pi/pi-coding-agent/edit/modes/hashline";

function tag(line: number, content: string): Anchor {
	return { line, hash: computeLineHash(line, content) };
}

describe("applyAtomEdits — set", () => {
	it("replaces a single line", () => {
		const content = "aaa\nbbb\nccc";
		const edits: AtomEdit[] = [{ op: "set", pos: tag(2, "bbb"), lines: ["BBB"] }];
		const result = applyAtomEdits(content, edits);
		expect(result.lines).toBe("aaa\nBBB\nccc");
		expect(result.firstChangedLine).toBe(2);
	});

	it("expands one line into many", () => {
		const content = "aaa\nbbb\nccc";
		const edits: AtomEdit[] = [{ op: "set", pos: tag(2, "bbb"), lines: ["X", "Y", "Z"] }];
		const result = applyAtomEdits(content, edits);
		expect(result.lines).toBe("aaa\nX\nY\nZ\nccc");
	});

	it("rejects on stale hash", () => {
		const content = "aaa\nbbb\nccc";
		const edits: AtomEdit[] = [{ op: "set", pos: { line: 2, hash: "ZZ" }, lines: ["BBB"] }];
		expect(() => applyAtomEdits(content, edits)).toThrow(HashlineMismatchError);
	});
});

describe("applyAtomEdits — del", () => {
	it("removes a line", () => {
		const content = "aaa\nbbb\nccc";
		const edits: AtomEdit[] = [{ op: "del", pos: tag(2, "bbb") }];
		const result = applyAtomEdits(content, edits);
		expect(result.lines).toBe("aaa\nccc");
	});

	it("multiple deletes apply bottom-up so anchors stay valid", () => {
		const content = "aaa\nbbb\nccc\nddd";
		const edits: AtomEdit[] = [
			{ op: "del", pos: tag(2, "bbb") },
			{ op: "del", pos: tag(3, "ccc") },
		];
		const result = applyAtomEdits(content, edits);
		expect(result.lines).toBe("aaa\nddd");
	});
});

describe("applyAtomEdits — pre/post", () => {
	it("pre inserts above the anchor", () => {
		const content = "aaa\nbbb\nccc";
		const edits: AtomEdit[] = [{ op: "pre", pos: tag(2, "bbb"), lines: ["NEW"] }];
		const result = applyAtomEdits(content, edits);
		expect(result.lines).toBe("aaa\nNEW\nbbb\nccc");
	});

	it("post inserts below the anchor", () => {
		const content = "aaa\nbbb\nccc";
		const edits: AtomEdit[] = [{ op: "post", pos: tag(2, "bbb"), lines: ["NEW"] }];
		const result = applyAtomEdits(content, edits);
		expect(result.lines).toBe("aaa\nbbb\nNEW\nccc");
	});

	it("pre + post on same anchor coexist with set", () => {
		const content = "aaa\nbbb\nccc";
		const edits: AtomEdit[] = [
			{ op: "pre", pos: tag(2, "bbb"), lines: ["B"] },
			{ op: "set", pos: tag(2, "bbb"), lines: ["BBB"] },
			{ op: "post", pos: tag(2, "bbb"), lines: ["A"] },
		];
		const result = applyAtomEdits(content, edits);
		expect(result.lines).toBe("aaa\nB\nBBB\nA\nccc");
	});
});

describe("applyAtomEdits — sub", () => {
	it("replaces a unique substring", () => {
		const content = "const timeout = 5000;";
		const edits: AtomEdit[] = [{ op: "sub", pos: tag(1, content), find: "5000", to: "30_000" }];
		const result = applyAtomEdits(content, edits);
		expect(result.lines).toBe("const timeout = 30_000;");
	});

	it("preserves the line tail (trailing semicolon, comma, brace)", () => {
		const content = "      required: true,";
		const edits: AtomEdit[] = [{ op: "sub", pos: tag(1, content), find: "true", to: "false" }];
		const result = applyAtomEdits(content, edits);
		expect(result.lines).toBe("      required: false,");
	});

	it("swaps an operator without restating the surrounding expression", () => {
		const content = "\tfor (let i = 0; i < value.length; i--) {";
		const edits: AtomEdit[] = [{ op: "sub", pos: tag(1, content), find: "i--", to: "i++" }];
		const result = applyAtomEdits(content, edits);
		expect(result.lines).toBe("\tfor (let i = 0; i < value.length; i++) {");
	});

	it("errors when find is absent", () => {
		const content = "abc def";
		const edits: AtomEdit[] = [{ op: "sub", pos: tag(1, content), find: "missing", to: "x" }];
		expect(() => applyAtomEdits(content, edits)).toThrow(/not found/);
	});

	it("errors when find is non-unique", () => {
		const content = "abc abc";
		const edits: AtomEdit[] = [{ op: "sub", pos: tag(1, content), find: "abc", to: "Z" }];
		expect(() => applyAtomEdits(content, edits)).toThrow(/more than once/);
	});

	it("rejects conflict with set on same anchor", () => {
		const content = "abc";
		const edits: AtomEdit[] = [
			{ op: "sub", pos: tag(1, "abc"), find: "abc", to: "x" },
			{ op: "set", pos: tag(1, "abc"), lines: ["y"] },
		];
		expect(() => applyAtomEdits(content, edits)).toThrow(/Conflicting ops/);
	});
});

describe("resolveAtomToolEdit — loc syntax", () => {
	it('loc:"$" appends at EOF', () => {
		const content = "aaa\nbbb";
		const resolved = resolveAtomToolEdit({ loc: "$", post: ["ccc"] });
		expect(resolved).toHaveLength(1);
		expect(resolved[0]?.op).toBe("append_file");
		const result = applyAtomEdits(content, resolved);
		expect(result.lines).toBe("aaa\nbbb\nccc");
	});

	it('loc:"^" prepends at BOF', () => {
		const content = "aaa\nbbb";
		const resolved = resolveAtomToolEdit({ loc: "^", pre: ["ZZZ"] });
		expect(resolved).toHaveLength(1);
		expect(resolved[0]?.op).toBe("prepend_file");
		const result = applyAtomEdits(content, resolved);
		expect(result.lines).toBe("ZZZ\naaa\nbbb");
	});

	it("expands pre + set + post from one entry", () => {
		const content = "aaa\nbbb\nccc";
		const loc = `2${computeLineHash(2, "bbb")}`;
		const resolved = resolveAtomToolEdit({ loc, pre: ["B"], set: ["BBB"], post: ["A"] });
		const result = applyAtomEdits(content, resolved);
		expect(result.lines).toBe("aaa\nB\nBBB\nA\nccc");
	});

	it("set: [] deletes the anchor line", () => {
		const content = "aaa\nbbb\nccc";
		const loc = `2${computeLineHash(2, "bbb")}`;
		const resolved = resolveAtomToolEdit({ loc, set: [] });
		expect(resolved[0]?.op).toBe("del");
		const result = applyAtomEdits(content, resolved);
		expect(result.lines).toBe("aaa\nccc");
	});

	it('set:[""] preserves a blank line', () => {
		const content = "aaa\nbbb\nccc";
		const loc = `2${computeLineHash(2, "bbb")}`;
		const resolved = resolveAtomToolEdit({ loc, set: [""] });
		expect(resolved[0]?.op).toBe("set");
		const result = applyAtomEdits(content, resolved);
		expect(result.lines).toBe("aaa\n\nccc");
	});

	it("supports path override inside loc", () => {
		const resolved = resolveAtomEntryPaths([{ loc: "a.ts:1ab", set: "X" }], undefined);
		expect(resolved[0]?.path).toBe("a.ts");
		expect(resolved[0]?.loc).toBe("1ab");
	});
});

describe("applyAtomEdits — out of range", () => {
	it("rejects line beyond file length", () => {
		const content = "aaa\nbbb";
		const edits: AtomEdit[] = [{ op: "set", pos: { line: 99, hash: "ZZ" }, lines: ["x"] }];
		expect(() => applyAtomEdits(content, edits)).toThrow(/does not exist/);
	});
});

describe("parseAnchor (atom tolerant) + applyAtomEdits", () => {
	it("surfaces correct anchor + content when the model invents an out-of-alphabet hash", () => {
		const content = "alpha\nbravo\ncharlie";
		// `XG` is not in the alphabet; should be rejected with the actual anchor exposed.
		const toolEdit = { path: "a.ts", loc: "2XG", set: "BRAVO" };
		const resolved = resolveAtomToolEdit(toolEdit);
		expect(() => applyAtomEdits(content, resolved)).toThrow(HashlineMismatchError);
		try {
			applyAtomEdits(content, resolved);
		} catch (err) {
			const msg = (err as Error).message;
			expect(msg).toMatch(/^\d+[a-z]{2}:/m);
			expect(msg).toContain("bravo");
			expect(msg).toContain(`2${computeLineHash(2, "bravo")}`);
		}
	});

	it("surfaces correct anchor + content when the model omits the hash entirely", () => {
		const content = "alpha\nbravo\ncharlie";
		const toolEdit = { path: "a.ts", loc: "2", set: "BRAVO" };
		const resolved = resolveAtomToolEdit(toolEdit);
		expect(() => applyAtomEdits(content, resolved)).toThrow(HashlineMismatchError);
	});

	it("surfaces correct anchor when the model uses pipe-separator (LINE|content) form", () => {
		const content = "alpha\nbravo\ncharlie";
		const toolEdit = { path: "a.ts", loc: "2|bravo", set: "BRAVO" };
		const resolved = resolveAtomToolEdit(toolEdit);
		expect(() => applyAtomEdits(content, resolved)).toThrow(HashlineMismatchError);
	});

	it("throws a usage-style error when no line number can be extracted", () => {
		const toolEdit = { path: "a.ts", loc: "  if (!x) return;", set: "x" };
		expect(() => resolveAtomToolEdit(toolEdit)).toThrow(/Could not find a line number/);
	});
});

describe("applyAtomEdits — between", () => {
	it("replaces lines strictly between two surviving anchors (function body, keep braces)", () => {
		const content = "function alpha() {\n\told();\n\tmore();\n}";
		const edits: AtomEdit[] = [
			{
				op: "between",
				after: tag(1, "function alpha() {"),
				before: tag(4, "}"),
				lines: ["\tvalidate();", "\tlog();", "\tcleanup();"],
			},
		];
		const result = applyAtomEdits(content, edits);
		expect(result.lines).toBe("function alpha() {\n\tvalidate();\n\tlog();\n\tcleanup();\n}");
		expect(result.firstChangedLine).toBe(2);
	});

	it("deletes the body when lines is empty", () => {
		const content = "function alpha() {\n\told();\n\tmore();\n}";
		const edits: AtomEdit[] = [
			{ op: "between", after: tag(1, "function alpha() {"), before: tag(4, "}"), lines: [] },
		];
		const result = applyAtomEdits(content, edits);
		expect(result.lines).toBe("function alpha() {\n}");
	});

	it("is a pure insertion when after.line + 1 == before.line", () => {
		const content = "top\nbottom";
		const edits: AtomEdit[] = [{ op: "between", after: tag(1, "top"), before: tag(2, "bottom"), lines: ["middle"] }];
		const result = applyAtomEdits(content, edits);
		expect(result.lines).toBe("top\nmiddle\nbottom");
	});

	it("rejects when after.line >= before.line", () => {
		const content = "a\nb\nc";
		const edits: AtomEdit[] = [{ op: "between", after: tag(2, "b"), before: tag(2, "b"), lines: ["x"] }];
		expect(() => applyAtomEdits(content, edits)).toThrow(/after\.line < before\.line/);
	});

	it("rejects when another op targets a line strictly inside the region", () => {
		const content = "open\nbody1\nbody2\nclose";
		const edits: AtomEdit[] = [
			{ op: "between", after: tag(1, "open"), before: tag(4, "close"), lines: ["X"] },
			{ op: "set", pos: tag(2, "body1"), lines: ["Y"] },
		];
		expect(() => applyAtomEdits(content, edits)).toThrow(/inside a `between` region/);
	});

	it("rejects overlapping between regions", () => {
		const content = "a\nb\nc\nd\ne";
		const edits: AtomEdit[] = [
			{ op: "between", after: tag(1, "a"), before: tag(4, "d"), lines: ["X"] },
			{ op: "between", after: tag(3, "c"), before: tag(5, "e"), lines: ["Y"] },
		];
		expect(() => applyAtomEdits(content, edits)).toThrow(/Overlapping `between` ops/);
	});

	it("coexists with set on the closing-anchor line (the anchor is preserved by between, then set rewrites it)", () => {
		const content = "open\nbody\nclose";
		const edits: AtomEdit[] = [
			{ op: "between", after: tag(1, "open"), before: tag(3, "close"), lines: ["X", "Y"] },
			{ op: "set", pos: tag(3, "close"), lines: ["END"] },
		];
		const result = applyAtomEdits(content, edits);
		expect(result.lines).toBe("open\nX\nY\nEND");
	});

	it("coexists with set on the opening-anchor line", () => {
		const content = "open\nbody\nclose";
		const edits: AtomEdit[] = [
			{ op: "between", after: tag(1, "open"), before: tag(3, "close"), lines: ["X", "Y"] },
			{ op: "set", pos: tag(1, "open"), lines: ["BEGIN"] },
		];
		const result = applyAtomEdits(content, edits);
		expect(result.lines).toBe("BEGIN\nX\nY\nclose");
	});

	it("rejects on stale hash for either anchor", () => {
		const content = "open\nbody\nclose";
		const edits: AtomEdit[] = [
			{ op: "between", after: { line: 1, hash: "ZZ" }, before: tag(3, "close"), lines: ["X"] },
		];
		expect(() => applyAtomEdits(content, edits)).toThrow(HashlineMismatchError);
	});

	it("resolveAtomToolEdit accepts range loc and parses both anchors", () => {
		const toolEdit = {
			path: "a.ts",
			loc: "1xx-4yy",
			set: ["X"],
		};
		const resolved = resolveAtomToolEdit(toolEdit);
		expect(resolved).toHaveLength(1);
		const between = resolved[0];
		expect(between?.op).toBe("between");
		if (!between || between.op !== "between") throw new Error("unreachable");
		expect(between.after.line).toBe(1);
		expect(between.before.line).toBe(4);
		expect(between.lines).toEqual(["X"]);
	});

	it("resolveAtomToolEdit rejects range loc without set", () => {
		expect(() => resolveAtomToolEdit({ path: "a.ts", loc: "1xx-4yy", pre: ["X"] })).toThrow(/range loc requires set/);
	});
});