can1357
22bb6b9927
- Enabled DEC 2026 for Alacritty/VS Code and via TERM_FEATURES Sy token. - Stopped blanket-disabling SSH for recognized direct terminals. - Made the DECRQM probe enable sync on a positive report, not just disable. - Extracted synchronizedOutputUserOverride so opt-out beats force-on.
388 lines
14 KiB
TypeScript
388 lines
14 KiB
TypeScript
import { beforeAll, describe, expect, it } from "bun:test";
|
|
import type { AssistantMessage } from "@oh-my-pi/pi-ai";
|
|
import { TERMINAL, Text, TUI } from "@oh-my-pi/pi-tui";
|
|
import { VirtualTerminal } from "../../tui/test/virtual-terminal";
|
|
import { Settings } from "../src/config/settings";
|
|
import { AssistantMessageComponent } from "../src/modes/components/assistant-message";
|
|
import { ToolExecutionComponent } from "../src/modes/components/tool-execution";
|
|
import { TranscriptContainer } from "../src/modes/components/transcript-container";
|
|
import { initTheme } from "../src/modes/theme/theme";
|
|
|
|
type MutableTerminalInfo = {
|
|
eagerEraseScrollbackRisk: boolean;
|
|
};
|
|
|
|
const mutableTerminalInfo = TERMINAL as unknown as MutableTerminalInfo;
|
|
|
|
async function withTerminalRisk<T>(risk: boolean, run: () => T | Promise<T>): Promise<T> {
|
|
const saved = TERMINAL.eagerEraseScrollbackRisk;
|
|
mutableTerminalInfo.eagerEraseScrollbackRisk = risk;
|
|
try {
|
|
return await run();
|
|
} finally {
|
|
mutableTerminalInfo.eagerEraseScrollbackRisk = saved;
|
|
}
|
|
}
|
|
|
|
describe("tool live-region scrollback", () => {
|
|
beforeAll(async () => {
|
|
await initTheme();
|
|
});
|
|
|
|
it("does not splice stale pending eval preview above the running eval viewport", async () => {
|
|
if (process.platform === "win32") return;
|
|
|
|
await withTerminalRisk(true, async () => {
|
|
const term = new VirtualTerminal(120, 12);
|
|
(term as unknown as { isNativeViewportAtBottom: () => boolean | undefined }).isNativeViewportAtBottom = () =>
|
|
undefined;
|
|
const tui = new TUI(term);
|
|
const chat = new TranscriptContainer();
|
|
const code = Array.from({ length: 20 }, (_unused, i) => `const line${i} = ${i};`).join("\n");
|
|
const title = "call model with new prompt + check box heights";
|
|
const args = { cells: [{ language: "js", title, code }] };
|
|
const component = new ToolExecutionComponent("eval", args, {}, undefined, tui, process.cwd());
|
|
|
|
try {
|
|
chat.addChild(
|
|
new Text("Now let me verify by calling the model and checking the box heights it produces:", 0, 0),
|
|
);
|
|
chat.addChild(new Text("prior filler\n".repeat(8).trimEnd(), 0, 0));
|
|
tui.addChild(chat);
|
|
tui.start();
|
|
tui.setEagerNativeScrollbackRebuild(true);
|
|
await term.waitForRender();
|
|
|
|
chat.addChild(component);
|
|
tui.requestRender();
|
|
await term.waitForRender();
|
|
|
|
component.updateResult(
|
|
{
|
|
content: [{ type: "text", text: "" }],
|
|
details: { cells: [{ index: 0, title, code, language: "js", output: "", status: "running" }] },
|
|
},
|
|
true,
|
|
);
|
|
tui.requestRender();
|
|
await term.waitForRender();
|
|
|
|
const bufferText = term
|
|
.getScrollBuffer()
|
|
.map(row => Bun.stripANSI(row).trimEnd())
|
|
.join("\n");
|
|
expect(bufferText).not.toContain("pending [1/1]");
|
|
expect(bufferText).toContain("const line9 = 9;");
|
|
expect(bufferText).toContain("const line19 = 19;");
|
|
} finally {
|
|
component.stopAnimation();
|
|
tui.stop();
|
|
await term.flush();
|
|
}
|
|
});
|
|
});
|
|
|
|
it("repaints a finalized write whose result lands after a card was appended below it", async () => {
|
|
if (process.platform === "win32") return;
|
|
|
|
await withTerminalRisk(true, async () => {
|
|
const term = new VirtualTerminal(120, 20);
|
|
(term as unknown as { isNativeViewportAtBottom: () => boolean | undefined }).isNativeViewportAtBottom = () =>
|
|
undefined;
|
|
const tui = new TUI(term);
|
|
const chat = new TranscriptContainer();
|
|
const content = Array.from({ length: 5 }, (_unused, i) => `const line${i} = ${i};`).join("\n");
|
|
const args = { file_path: "packages/coding-agent/test/probe.ts", content };
|
|
const component = new ToolExecutionComponent("write", args, {}, undefined, tui, process.cwd());
|
|
|
|
try {
|
|
chat.addChild(new Text("prior filler", 0, 0));
|
|
tui.addChild(chat);
|
|
tui.start();
|
|
tui.setEagerNativeScrollbackRebuild(true);
|
|
await term.waitForRender();
|
|
|
|
// The write streams its preview while it is the live block.
|
|
chat.addChild(component);
|
|
tui.requestRender();
|
|
await term.waitForRender();
|
|
|
|
// An out-of-band card (e.g. a TTSR rule notification) is appended below
|
|
// the still-in-flight write. Previously this froze the write on its
|
|
// streaming preview, so the eventual result never repainted.
|
|
chat.addChild(new Text("⚠ Injecting rule: ts-set-map", 0, 0));
|
|
tui.requestRender();
|
|
await term.waitForRender();
|
|
|
|
const beforeResult = term
|
|
.getScrollBuffer()
|
|
.map(row => Bun.stripANSI(row).trimEnd())
|
|
.join("\n");
|
|
expect(beforeResult).toContain("(streaming)");
|
|
|
|
// The write finishes after the card is already below it.
|
|
component.updateResult({ content: [{ type: "text", text: "" }], details: { path: args.file_path } }, false);
|
|
tui.requestRender();
|
|
await term.waitForRender();
|
|
|
|
const afterResult = term
|
|
.getScrollBuffer()
|
|
.map(row => Bun.stripANSI(row).trimEnd())
|
|
.join("\n");
|
|
// The streaming preview is gone and the finalized header repainted in place.
|
|
expect(afterResult).not.toContain("(streaming)");
|
|
expect(afterResult).toContain("· 5 lines");
|
|
} finally {
|
|
component.stopAnimation();
|
|
tui.stop();
|
|
await term.flush();
|
|
}
|
|
});
|
|
});
|
|
|
|
it("commits the scrolled-off head of an over-tall expanded streaming write to scrollback", async () => {
|
|
if (process.platform === "win32") return;
|
|
|
|
await withTerminalRisk(true, async () => {
|
|
const term = new VirtualTerminal(120, 12);
|
|
(term as unknown as { isNativeViewportAtBottom: () => boolean | undefined }).isNativeViewportAtBottom = () =>
|
|
undefined;
|
|
const tui = new TUI(term);
|
|
const chat = new TranscriptContainer();
|
|
const body = (n: number) => Array.from({ length: n }, (_unused, i) => `MARK-${i}`).join("\n");
|
|
const filePath = "packages/coding-agent/test/probe.txt";
|
|
// Expanded (Ctrl+O) lifts the tail-window cap, so the preview renders the
|
|
// whole content top-anchored — append-only growth as chunks stream in.
|
|
const component = new ToolExecutionComponent(
|
|
"write",
|
|
{ file_path: filePath, content: body(4) },
|
|
{},
|
|
undefined,
|
|
tui,
|
|
process.cwd(),
|
|
);
|
|
component.setExpanded(true);
|
|
|
|
try {
|
|
chat.addChild(component);
|
|
tui.addChild(chat);
|
|
tui.start();
|
|
tui.setEagerNativeScrollbackRebuild(true);
|
|
await term.waitForRender();
|
|
|
|
// A short preview that fits, then the full preview that alone overflows
|
|
// the 12-row viewport — the frame that scrolls the head above the top.
|
|
component.updateArgs({ file_path: filePath, content: body(4) });
|
|
tui.requestRender();
|
|
await term.waitForRender();
|
|
|
|
component.updateArgs({ file_path: filePath, content: body(40) });
|
|
tui.requestRender();
|
|
await term.waitForRender();
|
|
|
|
const strip = (rows: string[]) => rows.map(row => Bun.stripANSI(row).trimEnd()).join("\n");
|
|
const scrollText = strip(term.getScrollBuffer());
|
|
const viewportText = strip(term.getViewport());
|
|
|
|
// MARK-0 scrolled above the viewport: it must live in native scrollback
|
|
// (committed), not nowhere. Before the fix the tool block was not
|
|
// append-only, so its scrolled-off head was dropped — a yanked stream.
|
|
expect(viewportText).not.toContain("MARK-0");
|
|
expect(scrollText).toContain("MARK-0");
|
|
// The streaming tail stays on screen, and nothing went missing between.
|
|
expect(viewportText).toContain("MARK-39");
|
|
expect(viewportText).toContain("(streaming)");
|
|
expect(scrollText).toContain("MARK-20");
|
|
} finally {
|
|
component.stopAnimation();
|
|
tui.stop();
|
|
await term.flush();
|
|
}
|
|
});
|
|
});
|
|
|
|
it("treats a tool block as append-only only while its expanded preview streams", async () => {
|
|
const filePath = "packages/coding-agent/test/probe.txt";
|
|
const tui = new TUI(new VirtualTerminal(80, 24));
|
|
const args = { file_path: filePath, content: "MARK-0\nMARK-1\nMARK-2" };
|
|
const component = new ToolExecutionComponent("write", args, {}, undefined, tui, process.cwd());
|
|
type AppendOnly = { isTranscriptBlockAppendOnly(): boolean };
|
|
const probe = component as unknown as AppendOnly;
|
|
try {
|
|
// Collapsed: the preview slides a bounded tail window — not append-only.
|
|
expect(probe.isTranscriptBlockAppendOnly()).toBe(false);
|
|
// Expanded + streaming: append-only, eligible for head commit.
|
|
component.setExpanded(true);
|
|
expect(probe.isTranscriptBlockAppendOnly()).toBe(true);
|
|
// Once a final result lands the preview may collapse — boundary closes.
|
|
component.updateResult({ content: [{ type: "text", text: "" }], details: { path: filePath } }, false);
|
|
expect(probe.isTranscriptBlockAppendOnly()).toBe(false);
|
|
} finally {
|
|
component.stopAnimation();
|
|
}
|
|
});
|
|
|
|
it("commits the scrolled-off head of an expanded eval whose output streams past the viewport", async () => {
|
|
if (process.platform === "win32") return;
|
|
|
|
await withTerminalRisk(true, async () => {
|
|
const term = new VirtualTerminal(120, 12);
|
|
(term as unknown as { isNativeViewportAtBottom: () => boolean | undefined }).isNativeViewportAtBottom = () =>
|
|
undefined;
|
|
const tui = new TUI(term);
|
|
const chat = new TranscriptContainer();
|
|
const title = "stream lots of output";
|
|
const code = "for (let i = 0; i < 40; i++) console.log('MARK-' + i);";
|
|
const args = { cells: [{ language: "js", title, code }] };
|
|
const component = new ToolExecutionComponent("eval", args, {}, undefined, tui, process.cwd());
|
|
component.setExpanded(true);
|
|
const out = (n: number) => Array.from({ length: n }, (_unused, i) => `MARK-${i}`).join("\n");
|
|
const partial = (output: string) =>
|
|
component.updateResult(
|
|
{
|
|
content: [{ type: "text", text: "" }],
|
|
details: { cells: [{ index: 0, title, code, language: "js", output, status: "running" }] },
|
|
},
|
|
true,
|
|
);
|
|
|
|
try {
|
|
chat.addChild(component);
|
|
tui.addChild(chat);
|
|
tui.start();
|
|
tui.setEagerNativeScrollbackRebuild(true);
|
|
await term.waitForRender();
|
|
|
|
// A short output that fits, then the full stream that alone overflows the
|
|
// 12-row viewport — the frame that scrolls the output head above the top.
|
|
partial(out(4));
|
|
tui.requestRender();
|
|
await term.waitForRender();
|
|
|
|
partial(out(40));
|
|
tui.requestRender();
|
|
await term.waitForRender();
|
|
|
|
const strip = (rows: string[]) => rows.map(row => Bun.stripANSI(row).trimEnd()).join("\n");
|
|
const scrollText = strip(term.getScrollBuffer());
|
|
const viewportText = strip(term.getViewport());
|
|
|
|
// The streamed output head scrolled above the viewport: it must live in
|
|
// native scrollback (committed), not nowhere. The fixed code cell rides
|
|
// along as the stable prefix above it.
|
|
expect(viewportText).not.toContain("MARK-0");
|
|
expect(scrollText).toContain("MARK-0");
|
|
expect(scrollText).toContain("MARK-20");
|
|
// The streaming tail stays on screen, and nothing went missing between.
|
|
expect(viewportText).toContain("MARK-39");
|
|
} finally {
|
|
component.stopAnimation();
|
|
tui.stop();
|
|
await term.flush();
|
|
}
|
|
});
|
|
});
|
|
|
|
it("keeps a streaming eval append-only only while expanded and unfinalized", () => {
|
|
const tui = new TUI(new VirtualTerminal(80, 24));
|
|
const title = "t";
|
|
const code = "console.log('x')";
|
|
const args = { cells: [{ language: "js", title, code }] };
|
|
const component = new ToolExecutionComponent("eval", args, {}, undefined, tui, process.cwd());
|
|
type AppendOnly = { isTranscriptBlockAppendOnly(): boolean };
|
|
const probe = component as unknown as AppendOnly;
|
|
const details = {
|
|
cells: [{ index: 0, title, code, language: "js", output: "MARK-0\nMARK-1", status: "running" }],
|
|
};
|
|
try {
|
|
// Collapsed: bounded sliding tail windows — not append-only.
|
|
expect(probe.isTranscriptBlockAppendOnly()).toBe(false);
|
|
component.setExpanded(true);
|
|
// Expanded + partial (streaming output): append-only.
|
|
component.updateResult({ content: [{ type: "text", text: "" }], details }, true);
|
|
expect(probe.isTranscriptBlockAppendOnly()).toBe(true);
|
|
// Final result may collapse to a capped view — boundary closes.
|
|
component.updateResult({ content: [{ type: "text", text: "" }], details }, false);
|
|
expect(probe.isTranscriptBlockAppendOnly()).toBe(false);
|
|
} finally {
|
|
component.stopAnimation();
|
|
}
|
|
});
|
|
});
|
|
|
|
function makeAssistantMessage(text: string): AssistantMessage {
|
|
return {
|
|
role: "assistant",
|
|
content: [{ type: "text", text }],
|
|
api: "anthropic",
|
|
provider: "anthropic",
|
|
model: "test-model",
|
|
usage: {
|
|
input: 0,
|
|
output: 0,
|
|
cacheRead: 0,
|
|
cacheWrite: 0,
|
|
totalTokens: 0,
|
|
cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0, total: 0 },
|
|
},
|
|
stopReason: "stop",
|
|
timestamp: Date.now(),
|
|
};
|
|
}
|
|
|
|
describe("assistant live-region scrollback", () => {
|
|
beforeAll(async () => {
|
|
await initTheme();
|
|
await Settings.init({ inMemory: true, cwd: process.cwd() });
|
|
});
|
|
|
|
it("commits a streamed reply's scrolled-off head to scrollback instead of dropping it", async () => {
|
|
if (process.platform === "win32") return;
|
|
|
|
await withTerminalRisk(true, async () => {
|
|
const term = new VirtualTerminal(120, 12);
|
|
(term as unknown as { isNativeViewportAtBottom: () => boolean | undefined }).isNativeViewportAtBottom = () =>
|
|
undefined;
|
|
const tui = new TUI(term);
|
|
const chat = new TranscriptContainer();
|
|
// A streaming assistant reply, mid-stream (no message in the ctor → live).
|
|
// A markdown list yields one stable row per item, so growth is append-only.
|
|
const component = new AssistantMessageComponent(undefined, false);
|
|
const markers = Array.from({ length: 40 }, (_unused, i) => `- MARK-${i}`);
|
|
|
|
try {
|
|
chat.addChild(component);
|
|
tui.addChild(chat);
|
|
tui.start();
|
|
tui.setEagerNativeScrollbackRebuild(true);
|
|
await term.waitForRender();
|
|
|
|
// First a short reply that fits, then the full reply that overflows the
|
|
// 12-row viewport — the frame that scrolls the head above the top.
|
|
component.updateContent(makeAssistantMessage(markers.slice(0, 4).join("\n")));
|
|
tui.requestRender();
|
|
await term.waitForRender();
|
|
|
|
component.updateContent(makeAssistantMessage(markers.join("\n")));
|
|
tui.requestRender();
|
|
await term.waitForRender();
|
|
|
|
const strip = (rows: string[]) => rows.map(row => Bun.stripANSI(row).trimEnd()).join("\n");
|
|
const scrollText = strip(term.getScrollBuffer());
|
|
const viewportText = strip(term.getViewport());
|
|
|
|
// MARK-0 scrolled above the viewport: with the fix it lives in native
|
|
// scrollback (committed), not nowhere. The regression dropped it.
|
|
expect(viewportText).not.toContain("MARK-0");
|
|
expect(scrollText).toContain("MARK-0");
|
|
// The tail is still on screen, and nothing went missing in between.
|
|
expect(viewportText).toContain("MARK-39");
|
|
expect(scrollText).toContain("MARK-20");
|
|
} finally {
|
|
tui.stop();
|
|
await term.flush();
|
|
}
|
|
});
|
|
});
|
|
});
|