alexis@epsilver.xyz
3854c1c3b1
- Reconcile inspect_image centrally from setModelWithProviderSessionReset so retry-fallback model changes (turn-recovery.ts) that bypass syncAfterModelChange cannot leave a stale tool set - Apply persisted inspect_image.mode changes immediately from the settings selector via a new handleSettingChange branch - Refresh the read tool's advertised description during reconciliation, before applyActiveToolsByName rebuilds the prompt, instead of only lazily on the next image read - Fix the flat (quoted-dotted) enabled->mode migration to write the nested target form the resolver actually reads - Add committed regression tests: tri-state x capability matrix, override precedence, and enabled->mode migration (nested, flat, and explicit-mode-wins)
94 lines
3.5 KiB
TypeScript
94 lines
3.5 KiB
TypeScript
/**
|
|
* Regression tests for the inspect_image tri-state mode (`inspect_image.mode`),
|
|
* the `/vision` session override precedence, and the legacy
|
|
* `inspect_image.enabled` → `inspect_image.mode` migration.
|
|
*/
|
|
import { afterEach, describe, expect, test } from "bun:test";
|
|
import * as fs from "node:fs";
|
|
import * as os from "node:os";
|
|
import * as path from "node:path";
|
|
import type { Model } from "@oh-my-pi/pi-ai";
|
|
import { Settings } from "../src/config/settings";
|
|
import { isInspectImageToolActive } from "../src/utils/inspect-image-mode";
|
|
|
|
const visionModel = { provider: "kimi-code", id: "k3", input: ["text", "image"] } as unknown as Model;
|
|
const textModel = { provider: "openai", id: "gpt-x", input: ["text"] } as unknown as Model;
|
|
|
|
function activeFor(
|
|
overrides: Record<string, unknown>,
|
|
model: Model | undefined,
|
|
sessionOverride?: "on" | "off",
|
|
): boolean {
|
|
const settings = Settings.isolated(overrides);
|
|
return isInspectImageToolActive({
|
|
settings,
|
|
getActiveModel: () => model,
|
|
getInspectImageModeOverride: () => sessionOverride,
|
|
});
|
|
}
|
|
|
|
describe("isInspectImageToolActive", () => {
|
|
test("auto hides the tool for image-capable models", () => {
|
|
expect(activeFor({}, visionModel)).toBe(false);
|
|
});
|
|
|
|
test("auto exposes the tool for text-only models", () => {
|
|
expect(activeFor({}, textModel)).toBe(true);
|
|
});
|
|
|
|
test("auto treats an unresolved model as text-only", () => {
|
|
expect(activeFor({}, undefined)).toBe(true);
|
|
});
|
|
|
|
test("on forces the tool even for image-capable models", () => {
|
|
expect(activeFor({ "inspect_image.mode": "on" }, visionModel)).toBe(true);
|
|
});
|
|
|
|
test("off suppresses the tool even for text-only models", () => {
|
|
expect(activeFor({ "inspect_image.mode": "off" }, textModel)).toBe(false);
|
|
});
|
|
|
|
test("session override wins over the persisted setting", () => {
|
|
expect(activeFor({}, visionModel, "on")).toBe(true);
|
|
expect(activeFor({ "inspect_image.mode": "on" }, visionModel, "off")).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe("inspect_image.enabled migration", () => {
|
|
test("nested enabled=true migrates to mode on", () => {
|
|
const settings = Settings.isolated({ "inspect_image.enabled": true });
|
|
expect(settings.get("inspect_image.mode")).toBe("on");
|
|
});
|
|
|
|
test("nested enabled=false migrates to mode off", () => {
|
|
const settings = Settings.isolated({ "inspect_image.enabled": false });
|
|
expect(settings.get("inspect_image.mode")).toBe("off");
|
|
});
|
|
|
|
test("explicit mode wins over a stale legacy key", () => {
|
|
const settings = Settings.isolated({ "inspect_image.enabled": true, "inspect_image.mode": "off" });
|
|
expect(settings.get("inspect_image.mode")).toBe("off");
|
|
});
|
|
|
|
describe("flat dotted key in config.yml", () => {
|
|
let agentDir: string;
|
|
afterEach(() => {
|
|
if (agentDir) fs.rmSync(agentDir, { recursive: true, force: true });
|
|
});
|
|
|
|
test("flat inspect_image.enabled migrates to mode", async () => {
|
|
agentDir = fs.mkdtempSync(path.join(os.tmpdir(), "omp-vision-migration-"));
|
|
fs.writeFileSync(path.join(agentDir, "config.yml"), '"inspect_image.enabled": true\n');
|
|
const settings = await Settings.loadReadOnly({ agentDir, cwd: agentDir });
|
|
expect(settings.get("inspect_image.mode")).toBe("on");
|
|
});
|
|
|
|
test("nested inspect_image.enabled in config.yml migrates to mode", async () => {
|
|
agentDir = fs.mkdtempSync(path.join(os.tmpdir(), "omp-vision-migration-"));
|
|
fs.writeFileSync(path.join(agentDir, "config.yml"), "inspect_image:\n enabled: false\n");
|
|
const settings = await Settings.loadReadOnly({ agentDir, cwd: agentDir });
|
|
expect(settings.get("inspect_image.mode")).toBe("off");
|
|
});
|
|
});
|
|
});
|