3119bfced5
* fix(coding-agent): add explicit initiator attribution Use message-level attribution for Copilot X-Initiator with role-based fallback, and persist attribution across custom/hook session paths. Fixes #237 * fix(coding-agent): preserve legacy custom attribution fallback * fix(coding-agent): remove async-result role special-case * fix(coding-agent): inherit before_agent_start attribution from prompt * test(coding-agent): tighten typing in attribution regressions
195 lines
5.8 KiB
TypeScript
195 lines
5.8 KiB
TypeScript
import { describe, expect, it } from "bun:test";
|
|
import {
|
|
buildCopilotDynamicHeaders,
|
|
getCopilotInitiatorOverride,
|
|
hasCopilotVisionInput,
|
|
inferCopilotInitiator,
|
|
} from "../src/providers/github-copilot-headers";
|
|
import type { Message } from "../src/types";
|
|
|
|
describe("inferCopilotInitiator", () => {
|
|
it("returns 'user' when there are no messages", () => {
|
|
expect(inferCopilotInitiator([])).toBe("user");
|
|
});
|
|
|
|
it("returns 'agent' when last message role is assistant", () => {
|
|
const messages: Message[] = [
|
|
{ role: "user", content: "hello", timestamp: Date.now() },
|
|
{
|
|
role: "assistant",
|
|
content: [{ type: "text", text: "hi" }],
|
|
api: "openai-completions",
|
|
provider: "github-copilot",
|
|
model: "gpt-4o",
|
|
usage: {
|
|
input: 0,
|
|
output: 0,
|
|
cacheRead: 0,
|
|
cacheWrite: 0,
|
|
totalTokens: 0,
|
|
cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0, total: 0 },
|
|
},
|
|
stopReason: "stop",
|
|
timestamp: Date.now(),
|
|
},
|
|
];
|
|
expect(inferCopilotInitiator(messages)).toBe("agent");
|
|
});
|
|
|
|
it("returns 'agent' when last message is toolResult", () => {
|
|
const messages: Message[] = [
|
|
{
|
|
role: "toolResult",
|
|
toolCallId: "tc_1",
|
|
toolName: "bash",
|
|
content: [{ type: "text", text: "output" }],
|
|
isError: false,
|
|
timestamp: Date.now(),
|
|
},
|
|
];
|
|
expect(inferCopilotInitiator(messages)).toBe("agent");
|
|
});
|
|
|
|
it("returns 'user' when last message is user with text content", () => {
|
|
const messages: Message[] = [{ role: "user", content: "what time is it?", timestamp: Date.now() }];
|
|
expect(inferCopilotInitiator(messages)).toBe("user");
|
|
});
|
|
|
|
it("returns 'user' when last message is user with text content blocks", () => {
|
|
const messages: Message[] = [
|
|
{
|
|
role: "user",
|
|
content: [{ type: "text", text: "explain this image" }],
|
|
timestamp: Date.now(),
|
|
},
|
|
];
|
|
expect(inferCopilotInitiator(messages)).toBe("user");
|
|
});
|
|
|
|
it("prefers explicit attribution over role when attribution is agent", () => {
|
|
const messages: Message[] = [
|
|
{ role: "user", content: "internal reminder", attribution: "agent", timestamp: Date.now() },
|
|
];
|
|
expect(inferCopilotInitiator(messages)).toBe("agent");
|
|
});
|
|
|
|
it("prefers explicit attribution over role when attribution is user", () => {
|
|
const messages: Message[] = [
|
|
{ role: "developer", content: "forward user note", attribution: "user", timestamp: Date.now() },
|
|
];
|
|
expect(inferCopilotInitiator(messages)).toBe("user");
|
|
});
|
|
it("returns 'agent' when last message is user but last content block is tool_result", () => {
|
|
const messages: unknown[] = [
|
|
{
|
|
role: "user",
|
|
content: [{ type: "tool_result", tool_use_id: "tc_1", content: "done" }],
|
|
},
|
|
];
|
|
expect(inferCopilotInitiator(messages)).toBe("agent");
|
|
});
|
|
|
|
it("returns 'agent' for any non-user role", () => {
|
|
const messages: unknown[] = [
|
|
{
|
|
role: "tool",
|
|
tool_call_id: "call_abc123",
|
|
content: "tool output",
|
|
},
|
|
];
|
|
expect(inferCopilotInitiator(messages)).toBe("agent");
|
|
});
|
|
});
|
|
|
|
describe("getCopilotInitiatorOverride", () => {
|
|
it("returns undefined when no initiator header is configured", () => {
|
|
expect(getCopilotInitiatorOverride(undefined)).toBeUndefined();
|
|
expect(getCopilotInitiatorOverride({})).toBeUndefined();
|
|
});
|
|
|
|
it("returns the last valid case-insensitive initiator value", () => {
|
|
const headers = {
|
|
"x-initiator": "agent",
|
|
"X-Initiator": "user",
|
|
"X-INITIATOR": "invalid",
|
|
"x-InItIaToR": "agent",
|
|
};
|
|
expect(getCopilotInitiatorOverride(headers)).toBe("agent");
|
|
});
|
|
|
|
it("ignores invalid initiator values", () => {
|
|
expect(getCopilotInitiatorOverride({ "X-Initiator": "system" })).toBeUndefined();
|
|
});
|
|
});
|
|
describe("hasCopilotVisionInput", () => {
|
|
it("returns false when no messages have images", () => {
|
|
const messages: Message[] = [{ role: "user", content: "hello", timestamp: Date.now() }];
|
|
expect(hasCopilotVisionInput(messages)).toBe(false);
|
|
});
|
|
|
|
it("returns true when a user message has image content", () => {
|
|
const messages: Message[] = [
|
|
{
|
|
role: "user",
|
|
content: [
|
|
{ type: "text", text: "describe this" },
|
|
{ type: "image", data: "abc123", mimeType: "image/png" },
|
|
],
|
|
timestamp: Date.now(),
|
|
},
|
|
];
|
|
expect(hasCopilotVisionInput(messages)).toBe(true);
|
|
});
|
|
|
|
it("returns true when a toolResult has image content", () => {
|
|
const messages: Message[] = [
|
|
{
|
|
role: "toolResult",
|
|
toolCallId: "tc_1",
|
|
toolName: "screenshot",
|
|
content: [{ type: "image", data: "def456", mimeType: "image/jpeg" }],
|
|
isError: false,
|
|
timestamp: Date.now(),
|
|
},
|
|
];
|
|
expect(hasCopilotVisionInput(messages)).toBe(true);
|
|
});
|
|
|
|
it("returns false when user message has only text content", () => {
|
|
const messages: Message[] = [
|
|
{
|
|
role: "user",
|
|
content: [{ type: "text", text: "just text" }],
|
|
timestamp: Date.now(),
|
|
},
|
|
];
|
|
expect(hasCopilotVisionInput(messages)).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe("buildCopilotDynamicHeaders", () => {
|
|
it("sets X-Initiator and Openai-Intent", () => {
|
|
const headers = buildCopilotDynamicHeaders({ messages: [], hasImages: false });
|
|
expect(headers["X-Initiator"]).toBe("user");
|
|
expect(headers["Openai-Intent"]).toBe("conversation-edits");
|
|
});
|
|
|
|
it("preserves explicit initiator override over inferred value", () => {
|
|
const headers = buildCopilotDynamicHeaders({
|
|
messages: [{ role: "user", content: "what time is it?" }],
|
|
hasImages: false,
|
|
initiatorOverride: "agent",
|
|
});
|
|
expect(headers["X-Initiator"]).toBe("agent");
|
|
});
|
|
it("sets Copilot-Vision-Request when hasImages is true", () => {
|
|
const headers = buildCopilotDynamicHeaders({ messages: [], hasImages: true });
|
|
expect(headers["Copilot-Vision-Request"]).toBe("true");
|
|
});
|
|
|
|
it("does not set Copilot-Vision-Request when hasImages is false", () => {
|
|
const headers = buildCopilotDynamicHeaders({ messages: [], hasImages: false });
|
|
expect(headers["Copilot-Vision-Request"]).toBeUndefined();
|
|
});
|
|
});
|