can1357
72b036dcc0
- Renamed parameter names in ast-grep and ast-edit tools from `patterns`/`selector` to `pat`/`sel` for brevity across schema, implementation, and tests. - Expanded ast-grep and ast-edit tool documentation with 12+ new usage guidelines, examples, and critical notes on pattern syntax, metavariable placement, and error handling. - Updated CHANGELOG.md to document parameter renames and expanded tool guidance for AST pattern syntax and metavariable usage. - Reformatted test assertions and type annotations across ast-edit and ast-grep test files for improved readability.
88 lines
3.5 KiB
TypeScript
88 lines
3.5 KiB
TypeScript
import { describe, expect, it } from "bun:test";
|
|
import * as fs from "node:fs/promises";
|
|
import * as os from "node:os";
|
|
import * as path from "node:path";
|
|
import { Settings } from "@oh-my-pi/pi-coding-agent/config/settings";
|
|
import { createTools, type ToolSession } from "@oh-my-pi/pi-coding-agent/tools";
|
|
|
|
function createTestSession(cwd = "/tmp/test", overrides: Partial<ToolSession> = {}): ToolSession {
|
|
return {
|
|
cwd,
|
|
hasUI: true,
|
|
getSessionFile: () => null,
|
|
getSessionSpawns: () => "*",
|
|
settings: Settings.isolated(),
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
describe("ast_grep parse errors", () => {
|
|
it("collapses per-pattern parse errors for the same file", async () => {
|
|
const tempDir = await fs.mkdtemp(path.join(os.tmpdir(), "ast-grep-parse-"));
|
|
try {
|
|
const filePath = path.join(tempDir, "broken.ts");
|
|
await Bun.write(filePath, "export function broken( { return 1; }");
|
|
|
|
const tools = await createTools(createTestSession(tempDir));
|
|
const tool = tools.find(entry => entry.name === "ast_grep");
|
|
expect(tool).toBeDefined();
|
|
|
|
const result = await tool!.execute("ast-grep-parse", {
|
|
pat: ["someUnlikelyCall($A)", "anotherUnlikelyCall($A)"],
|
|
lang: "typescript",
|
|
path: filePath,
|
|
});
|
|
|
|
const text = result.content.find(content => content.type === "text")?.text ?? "";
|
|
const details = result.details as { parseErrors?: string[]; matchCount?: number } | undefined;
|
|
|
|
expect(details?.matchCount).toBe(0);
|
|
expect(text).toContain("No matches found");
|
|
expect(details?.parseErrors).toHaveLength(1);
|
|
expect(details?.parseErrors?.[0]).toContain("broken.ts: parse error (syntax tree contains error nodes)");
|
|
expect(details?.parseErrors?.[0]).not.toContain("someUnlikelyCall($A):");
|
|
expect(details?.parseErrors?.[0]).not.toContain("anotherUnlikelyCall($A):");
|
|
expect(text.match(/parse error \(syntax tree contains error nodes\)/g)?.length ?? 0).toBe(1);
|
|
} finally {
|
|
await fs.rm(tempDir, { recursive: true, force: true });
|
|
}
|
|
});
|
|
it("combines globbing from path and glob parameters", async () => {
|
|
const tempDir = await fs.mkdtemp(path.join(os.tmpdir(), "ast-grep-glob-"));
|
|
try {
|
|
const packagesDir = path.join(tempDir, "packages");
|
|
const sourceDir = path.join(packagesDir, "pkg-123", "src");
|
|
const nestedDir = path.join(sourceDir, "nested");
|
|
await fs.mkdir(nestedDir, { recursive: true });
|
|
await Bun.write(path.join(sourceDir, "root.ts"), "const providerOptions = {};\n");
|
|
await Bun.write(path.join(nestedDir, "child.ts"), "const providerOptions = { nested: true };\n");
|
|
await Bun.write(path.join(sourceDir, "ignore.js"), "const providerOptions = {};\n");
|
|
await Bun.write(path.join(tempDir, "outside.ts"), "const providerOptions = {};\n");
|
|
|
|
const tools = await createTools(createTestSession(tempDir));
|
|
const tool = tools.find(entry => entry.name === "ast_grep");
|
|
expect(tool).toBeDefined();
|
|
|
|
const result = await tool!.execute("ast-grep-glob", {
|
|
pat: ["providerOptions"],
|
|
sel: "identifier",
|
|
lang: "typescript",
|
|
path: `${packagesDir}/pkg-*/src`,
|
|
glob: "**/*.ts",
|
|
});
|
|
|
|
const text = result.content.find(content => content.type === "text")?.text ?? "";
|
|
const details = result.details as { matchCount?: number; fileCount?: number } | undefined;
|
|
|
|
expect(text).toContain("## └─ root.ts");
|
|
expect(text).toContain("## └─ child.ts");
|
|
expect(text).not.toContain("ignore.js");
|
|
expect(text).not.toContain("outside.ts");
|
|
expect(details?.matchCount).toBe(2);
|
|
expect(details?.fileCount).toBe(2);
|
|
} finally {
|
|
await fs.rm(tempDir, { recursive: true, force: true });
|
|
}
|
|
});
|
|
});
|