Larry Gordon
2230361fcd
Review follow-up on #8052. A batched LSP write recorded only the destination, and the flush reread each entry from disk before post-processing. That reread tolerated `ENOENT` and rethrew everything else, so a destination a sandbox denies for reading as well as writing failed the flush after every write in the batch had already succeeded, the brokered one included. The tool call owning the flush then reported failure for bytes that were on disk, contradicting the seam's promise that a native tool continues as if its own write had worked. The pending entry now carries the content it committed. The flush still prefers a fresh read, so an external change made before the flush wins and a file deleted before it is still not recreated; the remembered bytes stand in only when the read is denied. Recovered content flows into `runLspWritethrough`, whose `writeContent` already routes through `writeFileWithFallback`, so a formatter rewrite of it is brokered too. This also fixes a shape that predates the seam: a plain write-only file (mode `0o200`) failed the same flush with nothing registered at all. Covered by a real-permission test in `test/tools/lsp-batching.test.ts` that brokers a write to a `0o000` file inside a batch and then flushes; rethrowing instead of substituting the remembered bytes fails it with `EACCES` from `flushWritethroughBatch`.
@oh-my-pi/pi-coding-agent
Core implementation package for the omp coding agent in the oh-my-pi monorepo.
For installation, setup, provider configuration, model roles, slash commands, and full CLI reference, see:
Package-specific references:
Memory backends
The agent supports three mutually-exclusive memory backends, selected via the memory.backend setting (Settings → Memory tab, or ~/.omp/config.yml):
off(default) — no memory subsystem runs.local— existing rollout-summarisation pipeline; writesmemory_summary.mdand consolidated artifacts under the agent dir.hindsight— talks to a Hindsight server (Cloud or self-hosted Docker), retains transcripts every Nth user turn, recalls memories on the first turn of a session, and exposesretain,recall, andreflect.
Hindsight quickstart
- Run a Hindsight server (Cloud or
docker run -p 8888:8888 ghcr.io/vectorize-io/hindsight:latest). - Set
memory.backend = "hindsight"andhindsight.apiUrl = "http://localhost:8888"(or your Cloud URL). - Optional environment overrides (env wins over settings):
HINDSIGHT_API_URL,HINDSIGHT_API_TOKEN— connectionHINDSIGHT_BANK_ID,HINDSIGHT_DYNAMIC_BANK_ID,HINDSIGHT_AGENT_NAME— bank addressingHINDSIGHT_AUTO_RECALL,HINDSIGHT_AUTO_RETAIN,HINDSIGHT_RETAIN_MODE— lifecycleHINDSIGHT_RECALL_BUDGET,HINDSIGHT_RECALL_MAX_TOKENS— recall sizingHINDSIGHT_BANK_MISSION,HINDSIGHT_DEBUG
Switching backends mid-session immediately replaces the live backend, memory tools, listeners, and system-prompt context. Existing users with memories.enabled = true|false are migrated to memory.backend = "local"|"off" exactly once on first launch; afterward, memory.backend is the sole runtime selector.