metaphorics
2b126ffb80
Always-on LoopWatchdog (armed in TUI.start/stop) logs ui.loop-blocked with blockedMs and the current loop phase on the rising edge of a late probe tick. New pushLoopPhase/popLoopPhase/currentLoopPhase stack in pi-utils feeds it; breadcrumbs at in-process subagent dispatch (subagent:<id>) and the SelectList fuzzy filter (ui.select-filter) attribute residual main-thread stalls.
82 lines
3.0 KiB
TypeScript
82 lines
3.0 KiB
TypeScript
import { afterEach, beforeEach, describe, expect, test } from "bun:test";
|
|
import { currentLoopPhase, popLoopPhase, pushLoopPhase, takeRecentLoopPhase } from "@oh-my-pi/pi-utils";
|
|
|
|
/**
|
|
* Contract: the loop-phase breadcrumb is a LIFO string stack. `currentLoopPhase()`
|
|
* reports the most recently pushed, still-unpopped label and `undefined` once the
|
|
* stack drains. The watchdog reads this to name the work that blocked the loop, so
|
|
* the ordering and empty-state behavior are the externally observable guarantee.
|
|
*
|
|
* The stack is a process-global; drain it around each case so a leaked phase from
|
|
* this or any other suite cannot poison an assertion or leak outward.
|
|
*/
|
|
function drain(): void {
|
|
while (currentLoopPhase() !== undefined) popLoopPhase();
|
|
takeRecentLoopPhase(); // clear the consume-on-read recent slot between cases
|
|
}
|
|
|
|
beforeEach(drain);
|
|
afterEach(drain);
|
|
|
|
describe("loop phase stack", () => {
|
|
test("currentLoopPhase() is undefined on an empty stack", () => {
|
|
expect(currentLoopPhase()).toBeUndefined();
|
|
});
|
|
|
|
test("push/pop expose the top label in strict LIFO order through nested phases", () => {
|
|
pushLoopPhase("render");
|
|
expect(currentLoopPhase()).toBe("render");
|
|
|
|
pushLoopPhase("layout");
|
|
expect(currentLoopPhase()).toBe("layout");
|
|
|
|
pushLoopPhase("paint");
|
|
expect(currentLoopPhase()).toBe("paint");
|
|
|
|
// Unwinding reveals each enclosing phase in reverse insertion order.
|
|
popLoopPhase();
|
|
expect(currentLoopPhase()).toBe("layout");
|
|
|
|
popLoopPhase();
|
|
expect(currentLoopPhase()).toBe("render");
|
|
|
|
popLoopPhase();
|
|
expect(currentLoopPhase()).toBeUndefined();
|
|
});
|
|
|
|
test("popping an already-empty stack stays undefined without underflow", () => {
|
|
// Unbalanced pops (error paths popping more than they pushed) must not throw
|
|
// or wrap around to a stale label.
|
|
popLoopPhase();
|
|
popLoopPhase();
|
|
expect(currentLoopPhase()).toBeUndefined();
|
|
|
|
// And the stack is still usable afterward.
|
|
pushLoopPhase("after-underflow");
|
|
expect(currentLoopPhase()).toBe("after-underflow");
|
|
});
|
|
|
|
test("takeRecentLoopPhase surfaces a popped phase once, then clears it", () => {
|
|
// A synchronous hot path pushes then pops its phase entirely before the
|
|
// watchdog's delayed tick runs, so the live stack is empty by then.
|
|
pushLoopPhase("ui.select-filter");
|
|
popLoopPhase();
|
|
expect(currentLoopPhase()).toBeUndefined();
|
|
|
|
// The recent slot still names the just-finished phase for that one read,
|
|
// then is consumed so a later phase-less block is not blamed on it.
|
|
expect(takeRecentLoopPhase()).toBe("ui.select-filter");
|
|
expect(takeRecentLoopPhase()).toBeUndefined();
|
|
});
|
|
|
|
test("takeRecentLoopPhase prefers a still-held live phase over the recent slot", () => {
|
|
pushLoopPhase("outer"); // stays held across the inner phase
|
|
pushLoopPhase("inner");
|
|
popLoopPhase(); // inner done; recent slot last saw "inner", outer still live
|
|
|
|
// A live phase wins over the recent slot — the block is still inside it.
|
|
expect(takeRecentLoopPhase()).toBe("outer");
|
|
popLoopPhase();
|
|
});
|
|
});
|