oh-my-pi/packages/coding-agent/test/write-read-selector-misfire.test.ts

import { describe, expect, it } from "bun:test";
import * as fs from "node:fs/promises";
import * as os from "node:os";
import * as path from "node:path";
import { Settings } from "@oh-my-pi/pi-coding-agent/config/settings";
import type { ToolSession } from "@oh-my-pi/pi-coding-agent/tools";
import { WriteTool } from "@oh-my-pi/pi-coding-agent/tools/write";
import { readArchiveEntries, writeArchive } from "@oh-my-pi/pi-coding-agent/utils/zip";

// A read-only step that mis-dispatches `read` as `write` passes the full read
// expression (`src/foo.tsx:1-260:raw`) as the target. Because a literal colon
// filename is legal on POSIX (issue #4618), that used to resolve to filesystem
// creation and report success, leaving a stray zero-byte file the model could
// not recover from (issue #6387 — local analogue of the #6123 xd:// guard).

function session(cwd: string): ToolSession {
	return {
		cwd,
		hasUI: false,
		enableLsp: false,
		getSessionFile: () => null,
		getSessionSpawns: () => "*",
		settings: Settings.isolated({}),
	} as ToolSession;
}

async function makeWorkspace(): Promise<string> {
	const dir = await fs.mkdtemp(path.join(os.tmpdir(), "write-selector-misfire-"));
	await fs.mkdir(path.join(dir, "src/components"), { recursive: true });
	await Bun.write(path.join(dir, "src/components/LoraSelector.tsx"), "export const x = 1;\n");
	return dir;
}

describe("write refuses read-selector misfires", () => {
	it("fails closed on a missing selector-suffixed target with empty content and points at read()", async () => {
		const dir = await makeWorkspace();
		const write = new WriteTool(session(dir));
		const literal = "src/components/LoraSelector.tsx:1-260:raw";
		await expect(write.execute("c", { path: literal, content: "" })).rejects.toThrow(
			/read-tool selector ':1-260:raw'.*read\(\{ path: "src\/components\/LoraSelector\.tsx:1-260:raw" \}\)/s,
		);
		expect(await Bun.file(path.join(dir, literal)).exists()).toBe(false);
		await fs.rm(dir, { recursive: true, force: true });
	});

	it("lets non-empty content deliberately create a selector-shaped filename", async () => {
		const dir = await makeWorkspace();
		const write = new WriteTool(session(dir));
		const literal = "src/components/LoraSelector.tsx:1-260:raw";
		const res = await write.execute("c", { path: literal, content: "hi" });
		expect(res.isError).toBeUndefined();
		expect(await Bun.file(path.join(dir, literal)).text()).toBe("hi");
		await fs.rm(dir, { recursive: true, force: true });
	});

	it("keeps an existing literal colon filename writable with empty content", async () => {
		const dir = await makeWorkspace();
		await Bun.write(path.join(dir, "log:1-5"), "old");
		const write = new WriteTool(session(dir));
		const res = await write.execute("c", { path: "log:1-5", content: "" });
		expect(res.isError).toBeUndefined();
		expect(await Bun.file(path.join(dir, "log:1-5")).text()).toBe("");
		await fs.rm(dir, { recursive: true, force: true });
	});

	it("still allows ordinary empty-file creation without a read-shaped suffix", async () => {
		const dir = await makeWorkspace();
		const write = new WriteTool(session(dir));
		const res = await write.execute("c", { path: "src/empty.txt", content: "" });
		expect(res.isError).toBeUndefined();
		expect(await Bun.file(path.join(dir, "src/empty.txt")).exists()).toBe(true);
		await fs.rm(dir, { recursive: true, force: true });
	});

	it("rejects a missing selector-suffixed archive member without mutating the archive", async () => {
		const dir = await makeWorkspace();
		const archivePath = path.join(dir, "bundle.zip");
		const archiveEntries: Array<readonly [string, string]> = [["src/foo.ts", "export const x = 1;\n"]];
		await writeArchive(archivePath, "zip", archiveEntries);
		const before = await Bun.file(archivePath).bytes();
		const write = new WriteTool(session(dir));
		const target = "bundle.zip:src/foo.ts:1-20:raw";
		await expect(write.execute("c", { path: target, content: "" })).rejects.toThrow(
			/read-tool selector ':1-20:raw'.*read\(\{ path: "bundle\.zip:src\/foo\.ts:1-20:raw" \}\)/s,
		);
		expect(await Bun.file(archivePath).bytes()).toEqual(before);
		const entries = await readArchiveEntries({ bytes: before, format: "zip" });
		expect(entries.has("src/foo.ts")).toBe(true);
		expect(entries.has("src/foo.ts:1-20:raw")).toBe(false);
		await fs.rm(dir, { recursive: true, force: true });
	});

	it("keeps an existing literal selector-shaped archive member writable", async () => {
		const dir = await makeWorkspace();
		const archivePath = path.join(dir, "bundle.zip");
		const member = "src/foo.ts:1-20:raw";
		const archiveEntries: Array<readonly [string, string]> = [[member, "old"]];
		await writeArchive(archivePath, "zip", archiveEntries);
		const write = new WriteTool(session(dir));
		const result = await write.execute("c", { path: `bundle.zip:${member}`, content: "" });
		expect(result.isError).toBeUndefined();
		const entries = await readArchiveEntries({ bytes: await Bun.file(archivePath).bytes(), format: "zip" });
		expect(entries.get(member)).toEqual(new Uint8Array());
		await fs.rm(dir, { recursive: true, force: true });
	});
});