2ebb55134e
- Updated OpenAI completions parameterization to honor `disableReasoning` on effort-based compatible models by sending the minimum supported effort. - Expanded commit and title generation token budgets so reasoning models can return output after internal thinking while non-reasoning calls keep existing limits. - Switched title generation to request a `set_title` tool call, added extraction from tool-call arguments, and updated tests for the new behavior.
106 lines
2.8 KiB
TypeScript
106 lines
2.8 KiB
TypeScript
import { afterEach, describe, expect, it, vi } from "bun:test";
|
|
import * as ai from "@oh-my-pi/pi-ai";
|
|
import { type Api, getBundledModel, type Model } from "@oh-my-pi/pi-ai";
|
|
import { generateSessionTitle } from "../src/utils/title-generator";
|
|
|
|
function getModelOrThrow(id: string): Model<Api> {
|
|
const model = getBundledModel("anthropic", id);
|
|
if (!model) throw new Error(`Expected model ${id}`);
|
|
return model;
|
|
}
|
|
|
|
function createSettings(model: Model<Api>) {
|
|
return {
|
|
getModelRole(role: string) {
|
|
return role === "smol" ? `${model.provider}/${model.id}` : undefined;
|
|
},
|
|
getStorage() {
|
|
return undefined;
|
|
},
|
|
} as never;
|
|
}
|
|
|
|
function createRegistry(model: Model<Api>) {
|
|
return {
|
|
getAvailable: () => [model],
|
|
getApiKey: async () => "test-key",
|
|
} as never;
|
|
}
|
|
|
|
afterEach(() => {
|
|
vi.restoreAllMocks();
|
|
});
|
|
|
|
describe("title generator", () => {
|
|
it("returns the title from a forced set_title tool call", async () => {
|
|
const model = getModelOrThrow("claude-sonnet-4-5");
|
|
const completeSimpleMock = vi.spyOn(ai, "completeSimple").mockResolvedValue({
|
|
stopReason: "stop",
|
|
content: [
|
|
{
|
|
type: "toolCall",
|
|
id: "call-title",
|
|
name: "set_title",
|
|
arguments: { title: "Structured Title" },
|
|
},
|
|
],
|
|
} as never);
|
|
|
|
const title = await generateSessionTitle(
|
|
"Investigate the resolver",
|
|
createRegistry(model),
|
|
createSettings(model),
|
|
);
|
|
|
|
expect(title).toBe("Structured Title");
|
|
expect(completeSimpleMock.mock.calls[0]?.[1]).toMatchObject({
|
|
tools: [expect.objectContaining({ name: "set_title" })],
|
|
});
|
|
expect(completeSimpleMock.mock.calls[0]?.[2]).toMatchObject({
|
|
disableReasoning: true,
|
|
toolChoice: { type: "tool", name: "set_title" },
|
|
});
|
|
});
|
|
|
|
it("falls back to text content when no set_title tool call is returned", async () => {
|
|
const model = getModelOrThrow("claude-sonnet-4-5");
|
|
vi.spyOn(ai, "completeSimple").mockResolvedValue({
|
|
stopReason: "stop",
|
|
content: [{ type: "text", text: "Text Title" }],
|
|
} as never);
|
|
|
|
const title = await generateSessionTitle(
|
|
"Investigate the resolver",
|
|
createRegistry(model),
|
|
createSettings(model),
|
|
);
|
|
|
|
expect(title).toBe("Text Title");
|
|
});
|
|
|
|
it("uses a reasoning-safe output budget for reasoning models", async () => {
|
|
const model = getModelOrThrow("claude-sonnet-4-5");
|
|
const completeSimpleMock = vi.spyOn(ai, "completeSimple").mockResolvedValue({
|
|
stopReason: "stop",
|
|
content: [
|
|
{
|
|
type: "toolCall",
|
|
id: "call-title",
|
|
name: "set_title",
|
|
arguments: { title: "Budget Title" },
|
|
},
|
|
],
|
|
} as never);
|
|
|
|
const title = await generateSessionTitle(
|
|
"Investigate the resolver",
|
|
createRegistry(model),
|
|
createSettings(model),
|
|
);
|
|
const maxTokens = (completeSimpleMock.mock.calls[0]?.[2] as { maxTokens?: number } | undefined)?.maxTokens;
|
|
|
|
expect(title).toBe("Budget Title");
|
|
expect(maxTokens).toBeGreaterThanOrEqual(1024);
|
|
});
|
|
});
|