can1357
2e40fb250b
- Added splitInternalUrlSel to iteratively peel internal-URL selector chunks while preserving unsupported schemes like mcp://. - Updated ReadTool to use the internal splitter before routing so selector parsing is handled via parseSel. - Added unit tests covering malformed selectors, namespaced skill hosts, and unchanged behavior for non-URLs or unsupported schemes.
76 lines
2.9 KiB
TypeScript
76 lines
2.9 KiB
TypeScript
import { describe, expect, it } from "bun:test";
|
|
import { splitInternalUrlSel } from "@oh-my-pi/pi-coding-agent/tools/path-utils";
|
|
|
|
describe("splitInternalUrlSel", () => {
|
|
it("returns the input unchanged when there is no selector tail", () => {
|
|
expect(splitInternalUrlSel("artifact://3")).toEqual({ path: "artifact://3" });
|
|
expect(splitInternalUrlSel("agent://reviewer_0")).toEqual({ path: "agent://reviewer_0" });
|
|
expect(splitInternalUrlSel("memory://root")).toEqual({ path: "memory://root" });
|
|
});
|
|
|
|
it("peels a single line-range selector", () => {
|
|
expect(splitInternalUrlSel("artifact://3:1-100")).toEqual({ path: "artifact://3", sel: "1-100" });
|
|
expect(splitInternalUrlSel("artifact://3:50+150")).toEqual({ path: "artifact://3", sel: "50+150" });
|
|
expect(splitInternalUrlSel("artifact://3:50-")).toEqual({ path: "artifact://3", sel: "50-" });
|
|
});
|
|
|
|
it("peels a `raw` selector", () => {
|
|
expect(splitInternalUrlSel("artifact://3:raw")).toEqual({ path: "artifact://3", sel: "raw" });
|
|
});
|
|
|
|
it("peels compound `raw:range` selectors in either order", () => {
|
|
expect(splitInternalUrlSel("artifact://3:raw:1-100")).toEqual({
|
|
path: "artifact://3",
|
|
sel: "raw:1-100",
|
|
});
|
|
expect(splitInternalUrlSel("artifact://3:1-100:raw")).toEqual({
|
|
path: "artifact://3",
|
|
sel: "1-100:raw",
|
|
});
|
|
});
|
|
|
|
it("peels the malformed `:-N` selector that the strict splitter misses (the original bug)", () => {
|
|
expect(splitInternalUrlSel("artifact://3:raw:-100")).toEqual({
|
|
path: "artifact://3",
|
|
sel: "raw:-100",
|
|
});
|
|
expect(splitInternalUrlSel("artifact://3:-100")).toEqual({ path: "artifact://3", sel: "-100" });
|
|
});
|
|
|
|
it("peels selectors from skill URLs with namespaced hosts", () => {
|
|
expect(splitInternalUrlSel("skill://superpowers:brainstorming:1-5")).toEqual({
|
|
path: "skill://superpowers:brainstorming",
|
|
sel: "1-5",
|
|
});
|
|
});
|
|
|
|
it("does not peel chunks that are not selector-shaped", () => {
|
|
// `name` is part of the host, not a selector.
|
|
expect(splitInternalUrlSel("skill://plugin:name")).toEqual({ path: "skill://plugin:name" });
|
|
});
|
|
|
|
it("stops at the scheme separator `://`", () => {
|
|
expect(splitInternalUrlSel("agent://1-50")).toEqual({ path: "agent://1-50" });
|
|
});
|
|
|
|
it("leaves mcp:// URLs alone (mcp resource URIs may legitimately contain colons)", () => {
|
|
expect(splitInternalUrlSel("mcp://some/resource:1234")).toEqual({
|
|
path: "mcp://some/resource:1234",
|
|
});
|
|
expect(splitInternalUrlSel("mcp://server://uri:1-50")).toEqual({
|
|
path: "mcp://server://uri:1-50",
|
|
});
|
|
});
|
|
|
|
it("returns the input unchanged for non-URL strings", () => {
|
|
expect(splitInternalUrlSel("/abs/path:1-50")).toEqual({ path: "/abs/path:1-50" });
|
|
expect(splitInternalUrlSel("plain-text")).toEqual({ path: "plain-text" });
|
|
});
|
|
|
|
it("does not peel for unknown schemes", () => {
|
|
expect(splitInternalUrlSel("http://example.com:1-50")).toEqual({
|
|
path: "http://example.com:1-50",
|
|
});
|
|
});
|
|
});
|