re2zero
6fad3772fb
Persistence is lazy: getSessionFile() returns an allocated path from the start, but the JSONL is only materialized once an assistant message (or an explicit ensureOnDisk()) crosses the persistence gate. The shutdown banner printed the resume hint based solely on the path, so any session that ended before the first assistant message advertised a copy-pasteable command that always fails with Session not found. Gate the hint on the new SessionManager#isSessionOnDisk() (file exists in the active storage backend) and add unit tests. Fixes #8860
41 lines
1.8 KiB
TypeScript
41 lines
1.8 KiB
TypeScript
/**
|
|
* Issue #8860 — the exit banner advertises `--resume <id>` for sessions that
|
|
* were never written to disk. Persistence is lazy: `getSessionFile()` returns
|
|
* an allocated path from the start, but the JSONL is only materialized once the
|
|
* history crosses the persistence gate (first assistant message / explicit
|
|
* `ensureOnDisk()`). Consumers advertising a resume command must gate on
|
|
* `isSessionOnDisk()` instead of just the allocated path.
|
|
*/
|
|
import { describe, expect, it } from "bun:test";
|
|
import { join } from "node:path";
|
|
import { SessionManager } from "@oh-my-pi/pi-coding-agent/session/session-manager";
|
|
import { MemorySessionStorage } from "@oh-my-pi/pi-coding-agent/session/session-storage";
|
|
|
|
function freshSession(): SessionManager {
|
|
const cwd = join("/tmp", `omp-on-disk-test-${Date.now()}-${Math.random().toString(36).slice(2)}`);
|
|
return SessionManager.create(cwd, join(cwd, "sessions"), new MemorySessionStorage());
|
|
}
|
|
|
|
describe("SessionManager.isSessionOnDisk (issue #8860)", () => {
|
|
it("returns false for a fresh lazy session whose JSONL was never materialized", () => {
|
|
const session = freshSession();
|
|
expect(session.getSessionId()).not.toBe("");
|
|
expect(session.getSessionFile()).toBeTruthy();
|
|
// The path is allocated up front, but no file exists yet.
|
|
expect(session.isSessionOnDisk()).toBe(false);
|
|
});
|
|
|
|
it("returns true once ensureOnDisk() materializes the session file", async () => {
|
|
const session = freshSession();
|
|
expect(session.isSessionOnDisk()).toBe(false);
|
|
await session.ensureOnDisk();
|
|
expect(session.isSessionOnDisk()).toBe(true);
|
|
expect(session.getSessionFile()).toBeTruthy();
|
|
});
|
|
|
|
it("stays false for an in-memory (non-persisting) session", () => {
|
|
const session = SessionManager.inMemory();
|
|
expect(session.isSessionOnDisk()).toBe(false);
|
|
});
|
|
});
|