roboomp
1fa80a89ad
Legacy find and ls tool definitions still emit tool-result events through omp's custom-event branch. Export their historical named guards so static legacy imports validate, while narrowing only toolName and retaining unknown details. Fixes #8161
60 lines
2.1 KiB
TypeScript
60 lines
2.1 KiB
TypeScript
import { describe, expect, it } from "bun:test";
|
|
import {
|
|
isBashToolResult,
|
|
isEditToolResult,
|
|
isFindToolResult,
|
|
isGrepToolResult,
|
|
isLsToolResult,
|
|
isReadToolResult,
|
|
isWriteToolResult,
|
|
type ToolResultEvent,
|
|
} from "@oh-my-pi/pi-coding-agent/extensibility/legacy-pi-coding-agent-shim";
|
|
|
|
// Issue #8161: pi-lean-ctx@3.9.18 imports `isEditToolResult`/`isWriteToolResult`
|
|
// from `@earendil-works/pi-coding-agent`, which aliases to this shim. The shim's
|
|
// `export * from "../index"` never forwarded the `is<Tool>ToolResult` guard
|
|
// family (dropped from the public API in 10.2.3), so a named import threw Bun's
|
|
// static "Export named X not found" error and aborted `omp install`.
|
|
|
|
function resultEvent(toolName: string): ToolResultEvent {
|
|
return {
|
|
type: "tool_result",
|
|
toolCallId: "call-1",
|
|
input: {},
|
|
content: [],
|
|
isError: false,
|
|
toolName,
|
|
details: undefined,
|
|
};
|
|
}
|
|
|
|
describe("legacy shim tool-result guards", () => {
|
|
it("exports the guard family as callable functions", () => {
|
|
expect(typeof isBashToolResult).toBe("function");
|
|
expect(typeof isReadToolResult).toBe("function");
|
|
expect(typeof isEditToolResult).toBe("function");
|
|
expect(typeof isWriteToolResult).toBe("function");
|
|
expect(typeof isGrepToolResult).toBe("function");
|
|
expect(typeof isFindToolResult).toBe("function");
|
|
expect(typeof isLsToolResult).toBe("function");
|
|
});
|
|
|
|
it("narrows a tool_result event by tool name", () => {
|
|
expect(isEditToolResult(resultEvent("edit"))).toBe(true);
|
|
expect(isEditToolResult(resultEvent("write"))).toBe(false);
|
|
|
|
expect(isWriteToolResult(resultEvent("write"))).toBe(true);
|
|
expect(isWriteToolResult(resultEvent("edit"))).toBe(false);
|
|
|
|
expect(isBashToolResult(resultEvent("bash"))).toBe(true);
|
|
expect(isReadToolResult(resultEvent("read"))).toBe(true);
|
|
expect(isGrepToolResult(resultEvent("grep"))).toBe(true);
|
|
expect(isFindToolResult(resultEvent("find"))).toBe(true);
|
|
expect(isLsToolResult(resultEvent("ls"))).toBe(true);
|
|
expect(isFindToolResult(resultEvent("ls"))).toBe(false);
|
|
expect(isLsToolResult(resultEvent("find"))).toBe(false);
|
|
|
|
expect(isBashToolResult(resultEvent("read"))).toBe(false);
|
|
});
|
|
});
|