import { afterEach, describe, expect, it } from "bun:test"; import * as fs from "node:fs/promises"; import * as os from "node:os"; import * as path from "node:path"; import { createDaemonBrokerClient, type DaemonBrokerClient } from "../../src/launch/client"; import { registerDaemonProjectPresence } from "../../src/launch/presence"; import type { DaemonSpec } from "../../src/launch/protocol"; const cleanupDirs: string[] = []; async function tempDir(prefix: string): Promise { const dir = await fs.mkdtemp(path.join(os.tmpdir(), prefix)); cleanupDirs.push(dir); return dir; } // Cross-process integration: fake timers cannot advance a detached broker or OS process table. async function waitUntil(condition: () => boolean | Promise, timeoutMs: number): Promise { const deadline = Date.now() + timeoutMs; while (Date.now() < deadline) { if (await condition()) return true; await Bun.sleep(50); } return condition(); } function processExists(pid: number): boolean { try { process.kill(pid, 0); return true; } catch { return false; } } async function shutdown(client: DaemonBrokerClient): Promise { try { await client.request({ op: "shutdown" }); } catch { // A last-client shutdown may already have closed the broker. } client.close(); } async function startPtyDaemonWithShell(shell: string, initialMarker: string, expectedMarker: string): Promise { const projectDir = await tempDir("omp-daemon-shell-project-"); const runtimeDir = await tempDir("omp-daemon-shell-runtime-"); const runner = ` import { createDaemonBrokerClient } from "./src/launch/client"; const projectDir = ${JSON.stringify(projectDir)}; const runtimeDir = ${JSON.stringify(runtimeDir)}; const expectedMarker = ${JSON.stringify(expectedMarker)}; const client = await createDaemonBrokerClient(projectDir, { runtimeDir, idleGraceMs: 5_000, }); try { const started = await client.request({ op: "start", spec: { name: "shell", application: process.execPath, args: [ "-e", "process.stdout.write(process.env.OMP_TEST_SHELL_MARKER); process.stdout.write(String.fromCharCode(10)); process.stdin.resume();", ], env: {}, cwd: projectDir, pty: true, ready: { log: expectedMarker, timeoutMs: 5_000 }, restart: "no", persist: false, detached: false, }, owner: "shell-test", }); if (started.op !== "start") throw new Error("unexpected start response"); if (started.daemon.state !== "ready") { const logs = await client.request({ op: "logs", name: "shell", lines: 20, head: false, follow: false, timeoutMs: 1_000, }); throw new Error( "daemon did not become ready: " + (started.daemon.exitReason ?? "unknown error") + "; logs: " + (logs.op === "logs" ? logs.text : "unavailable"), ); } process.stdout.write(JSON.stringify({ state: started.daemon.state, readyTimedOut: started.readyTimedOut })); await client.request({ op: "stop", name: "shell", timeoutMs: 2_000 }); } finally { try { await client.request({ op: "shutdown" }); } catch { // A last-client shutdown may already have closed the broker. } client.close(); } `; const child = Bun.spawn([process.execPath, "--eval", runner], { cwd: path.resolve(import.meta.dir, "../.."), env: { ...process.env, SHELL: shell, OMP_TEST_SHELL_MARKER: initialMarker, }, stdout: "pipe", stderr: "pipe", }); const [exitCode, stdout, stderr] = await Promise.all([ child.exited, new Response(child.stdout).text(), new Response(child.stderr).text(), ]); expect({ exitCode, stderr }).toEqual({ exitCode: 0, stderr: "" }); expect(JSON.parse(stdout)).toEqual({ state: "ready", readyTimedOut: false }); } afterEach(async () => { while (cleanupDirs.length > 0) { const dir = cleanupDirs.pop(); if (dir) await fs.rm(dir, { recursive: true, force: true }); } }); describe("daemon broker", () => { it("shares PTY output and input across project clients", async () => { const projectDir = await tempDir("omp-daemon-project-"); const runtimeDir = await tempDir("omp-daemon-runtime-"); const scriptPath = path.join(projectDir, "service.ts"); await Bun.write( scriptPath, `process.stdin.setRawMode?.(true); process.stdin.setEncoding("utf8"); process.stdin.resume(); process.stdout.write("\\x1b[2J\\x1b[H"); for (let index = 0; index < 25; index++) process.stdout.write("BOOT:" + index + "\\n"); process.stdout.write("\\x1b[1;32mREADY\\x1b[0m\\n"); process.stdin.on("data", chunk => process.stdout.write("INPUT:" + JSON.stringify(chunk) + "\\n")); setInterval(() => {}, 1000); `, ); const first = await createDaemonBrokerClient(projectDir, { runtimeDir, idleGraceMs: 5_000 }); const second = await createDaemonBrokerClient(projectDir, { runtimeDir, idleGraceMs: 5_000 }); try { const spec: DaemonSpec = { name: "debugger", application: process.execPath, args: [scriptPath], env: {}, cwd: projectDir, pty: true, ready: { log: "READY", timeoutMs: 5_000 }, restart: "no", persist: false, detached: false, }; const started = await first.request({ op: "start", spec, owner: "first-client" }); expect(started.op).toBe("start"); if (started.op !== "start") throw new Error("unexpected start result"); expect(started.readyTimedOut).toBeFalse(); expect(started.daemon.state).toBe("ready"); const listed = await second.request({ op: "list" }); expect(listed.op).toBe("list"); if (listed.op !== "list") throw new Error("unexpected list result"); expect(listed.daemons.map(daemon => daemon.name)).toEqual(["debugger"]); await second.request({ op: "send", name: "debugger", data: "run\r" }); const waited = await first.request({ op: "wait", name: "debugger", for: "exit", pattern: "INPUT", timeoutMs: 3_000, }); expect(waited.op).toBe("wait"); if (waited.op !== "wait") throw new Error("unexpected wait result"); expect(waited.timedOut).toBeFalse(); expect(waited.matched).toBe("INPUT"); const logs = await second.request({ op: "logs", name: "debugger", lines: 20, head: false, follow: false, timeoutMs: 1_000, }); expect(logs.op).toBe("logs"); if (logs.op !== "logs") throw new Error("unexpected logs result"); expect(logs.text).toContain("READY"); expect(logs.text).not.toContain("\x1b"); expect(logs.text).not.toContain("BOOT:0"); expect(logs.text).toContain('INPUT:"run\\r"'); expect(logs.terminalText).toContain("\x1b[2J\x1b[H"); expect(logs.terminalText).toContain("\x1b[1;32mREADY\x1b[0m"); expect(logs.terminalText).toContain("BOOT:0"); const stopped = await first.request({ op: "stop", name: "debugger", timeoutMs: 2_000 }); expect(stopped.op).toBe("stop"); if (stopped.op !== "stop") throw new Error("unexpected stop result"); expect(stopped.daemon.state).toBe("exited"); } finally { await shutdown(first); second.close(); } }, 20_000); it("uses a basic shell when the login shell cannot run POSIX commands", async () => { if (process.platform === "win32") return; const shellPath = path.join(await tempDir("omp-daemon-nonposix-shell-"), "csh"); await Bun.write(shellPath, "#!/bin/sh\nexit 1\n"); await fs.chmod(shellPath, 0o755); await startPtyDaemonWithShell(shellPath, "basic-shell", "basic-shell"); }, 20_000); it("preserves compatible login shells for PTY daemons", async () => { if (process.platform === "win32") return; const shellPath = path.join(await tempDir("omp-daemon-posix-shell-"), "zsh"); await Bun.write(shellPath, '#!/bin/sh\nexport OMP_TEST_SHELL_MARKER="compatible-shell"\nexec /bin/sh "$@"\n'); await fs.chmod(shellPath, 0o755); await startPtyDaemonWithShell(shellPath, "basic-shell", "compatible-shell"); }, 20_000); it("returns promptly when a finite PTY child does not write the broker PID file", async () => { if (process.platform === "win32") return; const shellPath = path.join(await tempDir("omp-daemon-no-pid-shell-"), "zsh"); await Bun.write( shellPath, `#!/bin/sh case "$2" in *process.pid*) command=\${2#*; exec } exec /bin/sh -c "exec $command" ;; *) exec /bin/sh "$@" ;; esac `, ); await fs.chmod(shellPath, 0o755); const projectDir = await tempDir("omp-daemon-finite-project-"); const runtimeDir = await tempDir("omp-daemon-finite-runtime-"); const runner = ` import { createDaemonBrokerClient } from "./src/launch/client"; const client = await createDaemonBrokerClient(${JSON.stringify(projectDir)}, { runtimeDir: ${JSON.stringify(runtimeDir)}, idleGraceMs: 5_000, }); try { const startedAt = performance.now(); const started = await client.request({ op: "start", spec: { name: "finite-pty", application: "/bin/sh", args: ["-c", "sleep 5"], env: {}, cwd: ${JSON.stringify(projectDir)}, pty: true, restart: "no", persist: false, detached: false, }, }); if (started.op !== "start") throw new Error("unexpected start response"); process.stdout.write(JSON.stringify({ elapsedMs: Math.round(performance.now() - startedAt), state: started.daemon.state, pid: started.daemon.pid, })); if (started.daemon.state === "running") { await client.request({ op: "stop", name: "finite-pty", timeoutMs: 2_000 }); } } finally { try { await client.request({ op: "shutdown" }); } catch {} client.close(); } `; const child = Bun.spawn([process.execPath, "--eval", runner], { cwd: path.resolve(import.meta.dir, "../.."), env: { ...process.env, SHELL: shellPath }, stdout: "pipe", stderr: "pipe", }); const [exitCode, stdout, stderr] = await Promise.all([ child.exited, new Response(child.stdout).text(), new Response(child.stderr).text(), ]); expect({ exitCode, stderr }).toEqual({ exitCode: 0, stderr: "" }); const started = JSON.parse(stdout) as { elapsedMs: number; state: string; pid?: number }; // This is cross-process startup latency; fake timers cannot drive the broker or PTY child. expect(started.elapsedMs).toBeLessThan(3_000); expect(started.state).toBe("running"); expect(started.pid).toBeGreaterThan(0); }, 20_000); it("stops non-persistent daemons after the last project omp exits", async () => { const projectDir = await tempDir("omp-daemon-exit-project-"); const runtimeDir = await tempDir("omp-daemon-exit-runtime-"); const scriptPath = path.join(projectDir, "service.ts"); await Bun.write(scriptPath, `process.stdout.write("READY\\n"); setInterval(() => {}, 1000);\n`); const presence = await registerDaemonProjectPresence(projectDir, runtimeDir); const first = await createDaemonBrokerClient(projectDir, { runtimeDir, idleGraceMs: 200 }); const second = await createDaemonBrokerClient(projectDir, { runtimeDir, idleGraceMs: 200 }); let pid: number | undefined; try { const started = await first.request({ op: "start", spec: { name: "server", application: process.execPath, args: [scriptPath], env: {}, cwd: projectDir, pty: false, ready: { log: "READY", timeoutMs: 5_000 }, restart: "no", persist: false, detached: false, }, }); if (started.op !== "start" || started.daemon.pid === undefined) throw new Error("daemon did not start"); const daemonPid = started.daemon.pid; pid = daemonPid; await second.request({ op: "list" }); first.close(); second.close(); // Cross-process integration: the real broker grace clock cannot be advanced with test fake timers. await Bun.sleep(500); expect(processExists(daemonPid)).toBeTrue(); await presence.close(); const stopped = await waitUntil(() => !processExists(daemonPid), 5_000); const socketRemoved = await waitUntil( () => Bun.file(path.join(runtimeDir, "broker.sock")) .exists() .then(exists => !exists), 5_000, ); expect(stopped).toBeTrue(); expect(socketRemoved).toBeTrue(); } finally { first.close(); second.close(); await presence.close(); if (pid !== undefined && processExists(pid)) { const rescue = await createDaemonBrokerClient(projectDir, { runtimeDir, idleGraceMs: 1_000 }); await shutdown(rescue); } } }, 20_000); it("keeps detached daemons alive through broker replacement", async () => { const projectDir = await tempDir("omp-daemon-detached-project-"); const runtimeDir = await tempDir("omp-daemon-detached-runtime-"); const scriptPath = path.join(projectDir, "service.ts"); await Bun.write(scriptPath, `process.stdout.write("READY\\n"); setInterval(() => {}, 1000);\n`); const first = await createDaemonBrokerClient(projectDir, { runtimeDir, idleGraceMs: 5_000 }); let recovered: DaemonBrokerClient | undefined; let pid: number | undefined; try { const started = await first.request({ op: "start", spec: { name: "detached", application: process.execPath, args: [scriptPath], env: {}, cwd: projectDir, pty: false, ready: { log: "READY", timeoutMs: 5_000 }, restart: "no", persist: false, detached: true, }, }); if (started.op !== "start" || started.daemon.pid === undefined) throw new Error("detached daemon did not start"); pid = started.daemon.pid; expect(started.daemon.persist).toBeTrue(); expect(started.daemon.detached).toBeTrue(); await first.request({ op: "shutdown" }); first.close(); // Broker shutdown happens in another process, so fake timers cannot observe its lease release. const brokerStopped = await waitUntil( () => Bun.file(path.join(runtimeDir, "broker.pid")) .exists() .then(exists => !exists), 5_000, ); expect(brokerStopped).toBeTrue(); expect(processExists(pid)).toBeTrue(); recovered = await createDaemonBrokerClient(projectDir, { runtimeDir, idleGraceMs: 5_000 }); const described = await recovered.request({ op: "describe", name: "detached" }); if (described.op !== "describe") throw new Error("detached daemon did not recover"); expect(described.daemon.pid).toBe(pid); expect(described.daemon.detached).toBeTrue(); expect(described.spec.persist).toBeTrue(); const stopped = await recovered.request({ op: "stop", name: "detached", timeoutMs: 2_000 }); if (stopped.op !== "stop") throw new Error("detached daemon did not stop"); expect(stopped.daemon.state).toBe("exited"); await shutdown(recovered); recovered = undefined; } finally { first.close(); recovered?.close(); if (pid !== undefined && processExists(pid)) { const rescue = await createDaemonBrokerClient(projectDir, { runtimeDir, idleGraceMs: 1_000 }); try { await rescue.request({ op: "stop", name: "detached", timeoutMs: 2_000 }); } finally { await shutdown(rescue); } } } }, 20_000); // Regression: a start whose log pattern matched but whose port never accepted // used to report "Ready: " AND "Readiness timed out" with no hint of // which condition failed. The snapshot now names the unmet condition(s). it("names the unmet readiness condition when start times out", async () => { const projectDir = await tempDir("omp-daemon-ready-project-"); const runtimeDir = await tempDir("omp-daemon-ready-runtime-"); const scriptPath = path.join(projectDir, "service.ts"); await Bun.write(scriptPath, `process.stdout.write("LISTENING\\n"); setInterval(() => {}, 1000);\n`); // Reserve an ephemeral port and release it so nothing accepts connections there. const probe = Bun.listen({ hostname: "127.0.0.1", port: 0, socket: { data() {} } }); const deadPort = probe.port; probe.stop(true); const client = await createDaemonBrokerClient(projectDir, { runtimeDir, idleGraceMs: 5_000 }); try { const spec: DaemonSpec = { name: "never-ready", application: process.execPath, args: [scriptPath], env: {}, cwd: projectDir, pty: false, ready: { log: "LISTENING", port: deadPort, timeoutMs: 3_000 }, restart: "no", persist: false, detached: false, }; const started = await client.request({ op: "start", spec }); expect(started.op).toBe("start"); if (started.op !== "start") throw new Error("unexpected start result"); expect(started.readyTimedOut).toBeTrue(); expect(started.daemon.state).toBe("starting"); expect(started.daemon.readyMatch).toBe("LISTENING"); expect(started.daemon.readyPending).toEqual(["port"]); const stopped = await client.request({ op: "stop", name: "never-ready", timeoutMs: 2_000 }); if (stopped.op !== "stop") throw new Error("unexpected stop result"); // Terminal states carry no stale readiness noise. expect(stopped.daemon.readyPending).toBeUndefined(); } finally { await shutdown(client); } }, 20_000); // Regression: a process that flips starting→ready→exited within one 50ms poll // interval used to hang `start` for the full readiness timeout, because // #waitUntil sampled the live (already "exited") state instead of the sticky // readyAt marker #markReady durably recorded. it("returns promptly when the process becomes ready then exits within a poll", async () => { const projectDir = await tempDir("omp-daemon-fast-project-"); const runtimeDir = await tempDir("omp-daemon-fast-runtime-"); const scriptPath = path.join(projectDir, "fast.ts"); await Bun.write(scriptPath, `process.stdout.write("done\\n");\n`); const client = await createDaemonBrokerClient(projectDir, { runtimeDir, idleGraceMs: 5_000 }); try { const spec: DaemonSpec = { name: "fast", application: process.execPath, args: [scriptPath], env: {}, cwd: projectDir, pty: false, ready: { log: ".+", timeoutMs: 60_000 }, restart: "no", persist: false, detached: false, }; const t0 = Date.now(); const started = await client.request({ op: "start", spec }); const elapsed = Date.now() - t0; expect(started.op).toBe("start"); if (started.op !== "start") throw new Error("unexpected start result"); // Woke on readyAt/terminal, not the full 60s timeout. expect(elapsed).toBeLessThan(10_000); expect(started.readyTimedOut).toBeFalse(); expect(started.daemon.readyAt).toBeDefined(); // A for:"ready" wait on the settled daemon reports success via the sticky // readyAt marker even though the process has already exited. const waited = await client.request({ op: "wait", name: "fast", for: "ready", timeoutMs: 60_000, }); expect(waited.op).toBe("wait"); if (waited.op !== "wait") throw new Error("unexpected wait result"); expect(waited.timedOut).toBeFalse(); expect(waited.daemon.readyAt).toBeDefined(); } finally { await shutdown(client); } }, 20_000); // Regression: a process that exits before ever becoming ready used to block the // caller for the full timeout, and a for:"ready" wait on the settled daemon did // the same. Terminal states now wake both waits immediately. it('wakes start and for:"ready" waits when the process exits before readiness', async () => { const projectDir = await tempDir("omp-daemon-preexit-project-"); const runtimeDir = await tempDir("omp-daemon-preexit-runtime-"); const scriptPath = path.join(projectDir, "preexit.ts"); // Exits without ever printing the ready pattern. await Bun.write(scriptPath, `process.stdout.write("nope\\n"); process.exit(0);\n`); const client = await createDaemonBrokerClient(projectDir, { runtimeDir, idleGraceMs: 5_000 }); try { const spec: DaemonSpec = { name: "preexit", application: process.execPath, args: [scriptPath], env: {}, cwd: projectDir, pty: false, ready: { log: "LISTENING", timeoutMs: 60_000 }, restart: "no", persist: false, detached: false, }; const t0 = Date.now(); const started = await client.request({ op: "start", spec }); const startElapsed = Date.now() - t0; expect(started.op).toBe("start"); if (started.op !== "start") throw new Error("unexpected start result"); expect(startElapsed).toBeLessThan(10_000); // Woke on the terminal exit rather than timing out; the readyAt marker is // absent because the ready pattern never matched. expect(started.readyTimedOut).toBeFalse(); expect(started.daemon.readyAt).toBeUndefined(); expect(["exited", "failed"]).toContain(started.daemon.state); // A for:"ready" wait on the already-settled daemon must wake immediately, // but a process that never became ready is surfaced as not ready // (timedOut) so callers don't chain work against a dead process. const t1 = Date.now(); const waited = await client.request({ op: "wait", name: "preexit", for: "ready", timeoutMs: 60_000, }); const waitElapsed = Date.now() - t1; expect(waited.op).toBe("wait"); if (waited.op !== "wait") throw new Error("unexpected wait result"); expect(waitElapsed).toBeLessThan(10_000); expect(waited.timedOut).toBeTrue(); expect(waited.daemon.readyAt).toBeUndefined(); } finally { await shutdown(client); } }, 20_000); // Regression (PR #6305 review): readyAt belongs to the exited generation, so a // daemon in the restart backoff window must not report readiness. #settle now // clears readyAt/readyMatch when entering "restarting"; without that, start and // for:"ready" waits race a dead service during the backoff. it("clears stale readiness while a daemon is restarting", async () => { const projectDir = await tempDir("omp-daemon-restart-project-"); const runtimeDir = await tempDir("omp-daemon-restart-runtime-"); const scriptPath = path.join(projectDir, "flap.ts"); // Becomes ready (prints the pattern), then crashes shortly after. await Bun.write(scriptPath, `process.stdout.write("READY\\n"); setTimeout(() => process.exit(1), 50);\n`); const client = await createDaemonBrokerClient(projectDir, { runtimeDir, idleGraceMs: 5_000 }); try { const spec: DaemonSpec = { name: "flap", application: process.execPath, args: [scriptPath], env: {}, cwd: projectDir, pty: false, ready: { log: "READY", timeoutMs: 60_000 }, restart: "on-failure", persist: false, detached: false, }; const started = await client.request({ op: "start", spec }); expect(started.op).toBe("start"); if (started.op !== "start") throw new Error("unexpected start result"); expect(started.daemon.readyAt).toBeDefined(); // Catch the backoff window: once restarting, readiness must be cleared. const restarting = await waitUntil(async () => { const listed = await client.request({ op: "list" }); if (listed.op !== "list") return false; const daemon = listed.daemons.find(d => d.name === "flap"); return daemon?.state === "restarting"; }, 15_000); expect(restarting).toBeTrue(); const listed = await client.request({ op: "list" }); if (listed.op !== "list") throw new Error("unexpected list result"); const daemon = listed.daemons.find(d => d.name === "flap"); expect(daemon?.state).toBe("restarting"); expect(daemon?.readyAt).toBeUndefined(); expect(daemon?.readyMatch).toBeUndefined(); await client.request({ op: "stop", name: "flap", timeoutMs: 2_000 }); } finally { await shutdown(client); } }, 30_000); });